dblaikie added a comment. In D96778#2567255 <https://reviews.llvm.org/D96778#2567255>, @jankratochvil wrote:
> In D96778#2566208 <https://reviews.llvm.org/D96778#2566208>, @dblaikie wrote: > >> I expect it'd be good to have a test case showing the sort of DWARF that DWZ >> produces for cross-CU references of enumerators. > > There is a testcase in D91014 <https://reviews.llvm.org/D91014>: > lldb/test/Shell/SymbolFile/DWARF/DW_AT_decl_file-DW_AT_specification-crosscu.s > There is no testcase in this patch. That tests some other cross-cu references, but if it was testing the changes in this patch, wouldn't the test be failing (& I guess it isn't)? So seems like more test coverage might be in order? (Either in another test file, or as an addition to the existing one) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
