jankratochvil added a comment.

In D96778#2567261 <https://reviews.llvm.org/D96778#2567261>, @dblaikie wrote:

> That tests some other cross-cu references, but if it was testing the changes 
> in this patch, wouldn't the test be failing (& I guess it isn't)?

It isn't testing the specific cross-CU case of this patch.

> So seems like more test coverage might be in order? (Either in another test 
> file, or as an addition to the existing one)

Yes, I will try to extend/write one (or @werat can :-) ).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to