mgorny added inline comments.

================
Comment at: 
lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.h:62-63
   std::array<uint8_t, sizeof(reg) + sizeof(fpreg)> m_reg_data;
+  dbreg m_dbreg;
+  bool m_read_dbreg;
 
----------------
labath wrote:
> maybe Optional<dbreg>
Tried it but it feels really artificial here. I think the `bool` is both 
cleaner and results in less code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96548/new/

https://reviews.llvm.org/D96548

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to