This revision was automatically updated to reflect the committed changes. Closed by commit rG9f38001bf072: [lldb] [Process/FreeBSD] Ensure that errors are always handled (authored by mgorny). Herald added a project: LLDB.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96558/new/ https://reviews.llvm.org/D96558 Files: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp Index: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp =================================================================== --- lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp +++ lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp @@ -213,8 +213,9 @@ llvm::Error error = t.CopyWatchpointsFrom( static_cast<NativeThreadFreeBSD &>(*GetCurrentThread())); if (error) { - LLDB_LOG(log, "failed to copy watchpoints to new thread {0}: {1}", - info.pl_lwpid, llvm::toString(std::move(error))); + LLDB_LOG_ERROR(log, std::move(error), + "failed to copy watchpoints to new thread {1}: {0}", + info.pl_lwpid); SetState(StateType::eStateInvalid); return; }
Index: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp =================================================================== --- lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp +++ lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp @@ -213,8 +213,9 @@ llvm::Error error = t.CopyWatchpointsFrom( static_cast<NativeThreadFreeBSD &>(*GetCurrentThread())); if (error) { - LLDB_LOG(log, "failed to copy watchpoints to new thread {0}: {1}", - info.pl_lwpid, llvm::toString(std::move(error))); + LLDB_LOG_ERROR(log, std::move(error), + "failed to copy watchpoints to new thread {1}: {0}", + info.pl_lwpid); SetState(StateType::eStateInvalid); return; }
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits