labath added a reviewer: omjavaid. labath added a comment. I'm torn about the ReadHardwareDebugInfo interface. On one hand, there's no use case now for distinguishing the failure to retrieve breakpoint info from successfully determining that we support zero breakpoints. So we could make the function return void, move the log statement into the function, and simplify a bunch of stuff. OTOH, if those functions are later changed to propagate errors, they would become simpler too, and we might be able to forward this error all the way to the user...
Apart from that, I think this is fine, but maybe @omjavaid could take a quick look. ================ Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.h:62-63 std::array<uint8_t, sizeof(reg) + sizeof(fpreg)> m_reg_data; + dbreg m_dbreg; + bool m_read_dbreg; ---------------- maybe Optional<dbreg> CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
