[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith updated this revision to Diff 180992. asmith added a comment. Added lock suggested in review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 Files: include/lldb/Host/File.h include/lldb/Host/FileSystem.h source/Host/common/File.cpp

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added a comment. Please don't risk merging this before the branching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai created this revision. xiaobai added reviewers: sgraenitz, labath, zturner, JDevlieghere, davide, aprantl, stella.stamenova. Herald added a subscriber: mgorny. I did this for two reasons: - Using the CMake packages simplifies building LLDB Standalone. This is for two reasons: 1) We were

[Lldb-commits] [PATCH] D56517: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350788: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3. (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [lldb] r350788 - [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.

Author: davide Date: Wed Jan 9 17:15:18 2019 New Revision: 350788 URL: http://llvm.org/viewvc/llvm-project?rev=350788&view=rev Log: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3. Summary: In python 2, strings and bytes are the same, but they're not in python 3, hence the re

[Lldb-commits] [PATCH] D56517: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.

zturner added a comment. It's probably fine the way it is. The biggest advantage of using `universal_newlines=True` is that the result will always be a `string` in both Python 2 and Python 3. This makes it easier to reason about subsequent code , but if you're not doing much with the subseque

[Lldb-commits] [lldb] r350786 - A little cleanup / commenting on locating kernel binaries while I

Author: jmolenda Date: Wed Jan 9 16:57:54 2019 New Revision: 350786 URL: http://llvm.org/viewvc/llvm-project?rev=350786&view=rev Log: A little cleanup / commenting on locating kernel binaries while I was working on something else. DynamicLoaderDarwinKernel::SearchForKernelNearPC should have had a

[Lldb-commits] [PATCH] D56517: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.

davide added a comment. Given the name is really bizarre, I would stick with what I have now, which at least clarifies the intent (unless you feel strongly about it) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56517/new/ https://reviews.llvm.org/D56517

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith updated this revision to Diff 180965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234 Files: include/lldb/Host/PipeBase.h include/lldb/Host/posix/PipePosix.h include/lldb/Host/windows/PipeWindows.h include/lldb/lldb-types.h source

[Lldb-commits] [lldb] r350784 - [lldb-server] Add unnamed pipe support to PipeWindows

Author: asmith Date: Wed Jan 9 16:46:09 2019 New Revision: 350784 URL: http://llvm.org/viewvc/llvm-project?rev=350784&view=rev Log: [lldb-server] Add unnamed pipe support to PipeWindows Summary: This adds unnamed pipe support in PipeWindows to support communication between a debug server and ch

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

zturner marked 2 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:626 +// a series of namespaces. +// FIXME: do this. +CVSymbol global = m_index.ReadSymbolRecord(uid.asGlobalSym());

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/typedefs.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s labath wrote: > What's the reason f

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

lemo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:626 +// a series of namespaces. +// FIXME: do this. +CVSymbol global = m_index.ReadSymbolRecord(uid.asGlobalSym()); leftover comment?

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. This looks much nicer with the `pipe_t` type. Comment at: source/Host/posix/PipePosix.cpp:70 +PipePosix::PipePosix(lldb::pipe_t read, lldb::pipe_t write) +: m_fds{(int)

[Lldb-commits] [lldb] r350773 - Write PDB/variables.test to be more robust.

Author: zturner Date: Wed Jan 9 15:26:50 2019 New Revision: 350773 URL: http://llvm.org/viewvc/llvm-project?rev=350773&view=rev Log: Write PDB/variables.test to be more robust. CHECK-DAG can't really be mixed with CHECK-NEXT statements because each non DAG check sets a new search-origin for foll

[Lldb-commits] [PATCH] D56517: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.

zturner added a comment. Another way of dealing with this is to pass `universal_newlines=True` to `subprocess.Popen`. Despite the silly name, all this really means is "redirected pipes are text mode". As long as you expect the command being run to always return text rather than binary, it's s

[Lldb-commits] [PATCH] D56517: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.

davide created this revision. davide added reviewers: JDevlieghere, friss, zturner, aprantl. Herald added a reviewer: serge-sans-paille. In python 2, strings and bytes are the same, but they're not in python 3, hence the return of read() needs an explicit conversion. While I'm around, rename the r

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

asmith updated this revision to Diff 180939. asmith added a comment. Add lldb::pipe_t type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234 Files: include/lldb/Host/PipeBase.h include/lldb/Host/posix/PipePosix.h include/lldb/Host/windows/Pi

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350769: [Python] Update PyString_FromString() to work for python 2 and 3. (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [lldb] r350769 - [Python] Update PyString_FromString() to work for python 2 and 3.

Author: davide Date: Wed Jan 9 14:52:47 2019 New Revision: 350769 URL: http://llvm.org/viewvc/llvm-project?rev=350769&view=rev Log: [Python] Update PyString_FromString() to work for python 2 and 3. Reviewers: aprantl, JDevlieghere, friss, zturner Subscribers: lldb-commits Differential Revision

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

Hui added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1051 // and fill the data into "command_output_ptr" #if defined(__APPLE__) // Binding to port zero, we need to figure out what port it ends up My first

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

zturner accepted this revision. zturner added inline comments. This revision is now accepted and ready to land. Comment at: lldb/scripts/Python/python-wrapper.swig:827 lldb::SBFrame frame_sb(frame_sp); PyObject *arg = SBTypeToSWIGWrapper(frame_sb); Th

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

davide updated this revision to Diff 180924. davide added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56511/new/ https://reviews.llvm.org/D56511 Files: lldb/scripts/Python/python-swigsafecast.swig lldb/scripts/Python/python-wrapper.swig Index: lldb/s

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

zturner added inline comments. Comment at: lldb/scripts/Python/python-wrapper.swig:834 +#endif +PyObject* result = PyObject_CallMethodObjArgs(implementor, str_arg, arg, NULL); return result; Note that there appears to be an object leak here, as the `str

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. In D56511#1351768 , @JDevlieghere wrote: > There's two more mentions of this function: > > - `unittests/ScriptInterpreter/Python/PythonData

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. There's two more mentions of this function: - `unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp` - `source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp` I gu

[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350764: Change lldb-test to use ParseAllDebugSymbols. (authored by zturner, committed by ). Herald added subscribers: teemperor, abidh. Changed prior to commit: https://reviews.llvm.org/D56418?vs=180

[Lldb-commits] [lldb] r350764 - Change lldb-test to use ParseAllDebugSymbols.

Author: zturner Date: Wed Jan 9 13:20:44 2019 New Revision: 350764 URL: http://llvm.org/viewvc/llvm-project?rev=350764&view=rev Log: Change lldb-test to use ParseAllDebugSymbols. ParseDeclsForContext was originally created to serve the very specific case where the context is a function block. It

[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

davide created this revision. davide added reviewers: aprantl, JDevlieghere, friss, zturner. https://reviews.llvm.org/D56511 Files: lldb/scripts/Python/python-swigsafecast.swig lldb/scripts/Python/python-wrapper.swig Index: lldb/scripts/Python/python-wrapper.swig ===

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

xiaobai added inline comments. Comment at: CMakeLists.txt:72 endif() + if (compiler_used) +set(LLDB_TEST_COMPILER_USED ${compiler_used}) Is this check needed? `compiler_used` should be set always here because of the way the above block is written. CHAN

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

stella.stamenova added inline comments. Comment at: CMakeLists.txt:61 + # Use LLDB_TEST_COMPILER_IS_DEFAULT to determine whether or not to replace + # CMAKE_CFG_INTDIR with LLVM_BUILD_MODE for dotest. + if(LLDB_TEST_COMPILER) If it's true that we don't need th

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

sgraenitz added inline comments. Comment at: CMakeLists.txt:73 + if (compiler_used) +set(LLDB_TEST_COMPILER_USED ${compiler_used}) + else() Note: Using a different variable here to avoid force-overwriting the cached value of `LLDB_TEST_COMPILER`. If we did

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

sgraenitz updated this revision to Diff 180890. sgraenitz marked 5 inline comments as done. sgraenitz added a comment. Move BUILD_SHARED_LIBS and LLDB_HAVE_LLD to a separate commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56440/new/ https://reviews.llvm.org/D56440 Files: CMakeLi

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

zturner added a comment. In D56462#1351391 , @clayborg wrote: > So I like the ability to specify any symbol context to parse all types for. > If you pass in a symbol context with only a module filled in, we parse all > types. If we pass in a symbol conte

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

clayborg added a comment. But if everyone else thinks differently, I'll go with the majority. Just my initial thoughts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56462/new/ https://reviews.llvm.org/D56462 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

clayborg added a comment. So there really aren't that many things: - module only filled out, parse all types - compile unit only filled out, parse all type from a compile unit - function filled out, parse all types in a function - block filled out, parse all types in block, or we can skip this on

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

clayborg added a comment. So I like the ability to specify any symbol context to parse all types for. If you pass in a symbol context with only a module filled in, we parse all types. If we pass in a symbol context with only the compile unit filled in (no function), we parse all types in the co

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lit/CMakeLists.txt:14 -if (NOT LLDB_TEST_USE_CUSTOM_C_COMPILER) - string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

amccarth added a comment. So this Patch is effectively NFC, since no caller (not even a test) was using the functionality you've removed. Seems like a nice refactor. Comment at: lldb/source/Core/Module.cpp:382 // Parse all types for this compile unit + symbols->

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

This revision was automatically updated to reflect the committed changes. Closed by commit rL350742: ELF: create "container" sections from PT_LOAD segments (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] r350742 - ELF: create "container" sections from PT_LOAD segments

Author: labath Date: Wed Jan 9 08:50:45 2019 New Revision: 350742 URL: http://llvm.org/viewvc/llvm-project?rev=350742&view=rev Log: ELF: create "container" sections from PT_LOAD segments Summary: This is the result of the discussion in D55356, where it was suggested as a solution to representing

[Lldb-commits] [PATCH] D56443: [CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary directory

This revision was automatically updated to reflect the committed changes. Closed by commit rL350738: [CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary… (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES S

[Lldb-commits] [PATCH] D56399: [CMake] Fix standalone builds: workaround the cxx target not getting imported yet (unlike clang target)

This revision was automatically updated to reflect the committed changes. Closed by commit rL350737: [CMake] Fix standalone builds: workaround the cxx target not getting imported… (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[Lldb-commits] [lldb] r350738 - [CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary directory

Author: stefan.graenitz Date: Wed Jan 9 08:25:37 2019 New Revision: 350738 URL: http://llvm.org/viewvc/llvm-project?rev=350738&view=rev Log: [CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary directory Summary: In standalone builds `LLVM_BINARY_DIR` was equal to `LLDB_B

[Lldb-commits] [lldb] r350737 - [CMake] Fix standalone builds: workaround the cxx target not getting imported yet (unlike clang target)

Author: stefan.graenitz Date: Wed Jan 9 08:25:31 2019 New Revision: 350737 URL: http://llvm.org/viewvc/llvm-project?rev=350737&view=rev Log: [CMake] Fix standalone builds: workaround the cxx target not getting imported yet (unlike clang target) Summary: Handle standalone builds separately and p

Re: [Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

Yes I expect someone else to review more thoroughly, but I included you anyway since you may have to dtart caring about this soon :) On Wed, Jan 9, 2019 at 6:39 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > Is there any chance we can get someone w

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

labath added inline comments. Comment at: lit/Minidump/Windows/Sigsegv/sigsegv.test:6 +CHECK: * thread #1, stop reason = Exception 0xc005 encountered at address 0x7ff7a13110d9 +CHECK: * frame #0: 0x7ff7a13110d9 sigsegv.exe`crash at sigsegv.cpp:22 + tee

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

labath added a comment. Sounds good to me (not clicking accept to see if anyone else has an opinion here). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56462/new/ https://reviews.llvm.org/D56462 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

labath added a comment. Is there any chance we can get someone who knows something about pdbs take a look at this (@amccarth ? @aleksandr.urakov ?) ? Comment at: lldb/lit/SymbolFile/NativePDB/typedefs.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl --n

[Lldb-commits] [PATCH] D56443: [CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary directory

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:117 # For now check that the include directory exists. -set(cxx_dir "${LLVM_DIR}/../../../include/c++") +set(cxx_dir "${LLVM_BINRAY_DIR}/include/c++")

[Lldb-commits] [PATCH] D56443: [CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary directory

sgraenitz updated this revision to Diff 180830. sgraenitz marked an inline comment as done. sgraenitz added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56443/new/ https://reviews.llvm.org/D56443 Files: CMakeLists.txt cmake/modules/LLDBStandalone.cmake lit/Su

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

sgraenitz added a comment. In D56440#1349892 , @JDevlieghere wrote: > It looks like `LLDB_TEST_COMPILER_IS_DEFAULT` is set but never read. Why do > we need it exactly? Right, good you found that. I first used it to determine whether the replacement in

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added a comment. > It is not that applicable for the windows process launcher to determine which > entry in the args needs to be quoted unless given very specific flag or > option. Why not? Given the argv parsing rules described here https://docs.microsoft.com/en-us/cpp/cpp/parsing-cpp-

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

sgraenitz added a comment. I think this is going to be really nice! Here's a few details I found. Comment at: docs/use/map.rst:28 ++--+---+ +| Launch

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

teemperor added inline comments. Comment at: lit/Minidump/Windows/Sigsegv/sigsegv.test:6 +CHECK: * thread #1, stop reason = Exception 0xc005 encountered at address 0x7ff7a13110d9 +CHECK: * frame #0: 0x7ff7a13110d9 sigsegv.exe`crash at sigsegv.cpp:22 +