[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: lldb/scripts/Python/python-wrapper.swig:834
+#endif
+    PyObject* result = PyObject_CallMethodObjArgs(implementor, str_arg, arg, 
NULL);
     return result;
----------------
Note that there appears to be an object leak here, as the `str_arg` is never 
released.  Changing to `PythonString` should also fix that bug as a free side 
effect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56511/new/

https://reviews.llvm.org/D56511



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits