zturner marked 2 inline comments as done. zturner added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:626 + // a series of namespaces. + // FIXME: do this. + CVSymbol global = m_index.ReadSymbolRecord(uid.asGlobalSym()); ---------------- lemo wrote: > leftover comment? Yep, thanks. ================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.h:70-74 + if (m_kind == Struct || m_kind == Union) + return cvclass.Name; + if (m_kind == Enum) + return cvenum.Name; + return cvunion.Name; ---------------- lemo wrote: > this, in isolation at least, reads very strange : for m_kind==Union return > cvclass.Name and for everything else return cvunion.Name ? Oops, that's a bug. It's supposed to say ``` if (m_kind == Struct || m_kind == Class) return cvclass.Name; ``` I think the rest of the function makes sense after that. Thanks for catching that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56461/new/ https://reviews.llvm.org/D56461 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
