clayborg added a comment.
So I like the ability to specify any symbol context to parse all types for. If
you pass in a symbol context with only a module filled in, we parse all types.
If we pass in a symbol context with only the compile unit filled in (no
function), we parse all types in the compile unit. If we pass in a symbol
context with a function or block, we parse all types in that function or block.
Currently it is only being used for compile units, but I don't think we need to
change the API.
================
Comment at: lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp:228-238
size_t SymbolFileSymtab::ParseFunctionBlocks(const SymbolContext &sc) {
return 0;
}
-size_t SymbolFileSymtab::ParseTypes(const SymbolContext &sc) { return 0; }
+size_t SymbolFileSymtab::ParseTypesForCompileUnit(CompileUnit &comp_unit) {
+ return 0;
+}
----------------
All these functions that just return zero, error, fail, should have default
implementations in the SymbolFile class IMHO. Keeps diffs down.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56462/new/
https://reviews.llvm.org/D56462
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
