stella.stamenova requested changes to this revision.
stella.stamenova added inline comments.
This revision now requires changes to proceed.
================
Comment at: lit/CMakeLists.txt:14
-if (NOT LLDB_TEST_USE_CUSTOM_C_COMPILER)
- string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER
"${LLDB_TEST_C_COMPILER}")
----------------
Your change is removing the logic to setup this path correctly. This will cause
failures in the tests.
================
Comment at: lit/CMakeLists.txt:41
list(APPEND LLDB_TEST_DEPS lld)
- set(LLDB_HAVE_LLD 1)
-else()
----------------
It is better to do this in a separate change (the shared libs also) since they
are not related to the compiler properties
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56440/new/
https://reviews.llvm.org/D56440
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
