zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/scripts/Python/python-wrapper.swig:827
lldb::SBFrame frame_sb(frame_sp);
PyObject *arg = SBTypeToSWIGWrapper(frame_sb);
----------------
This looks like another possible object leak. The documentation for
`PyObject_CallMethodObjArgs` doesn't mention whether it takes ownership of the
argument, but I think it wouldn't make sense for it to do so, because you're
just calling a function. In any case, just make sure the current change
doesn't regress the test suite.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56511/new/
https://reviews.llvm.org/D56511
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
