zturner added a comment. It's probably fine the way it is. The biggest advantage of using `universal_newlines=True` is that the result will always be a `string` in both Python 2 and Python 3. This makes it easier to reason about subsequent code , but if you're not doing much with the subsequent code, it doesn't matter. In Python 2, the return type is a `Unicode` object, which is different than a `string`. For this code it's fine, it's just something to keep in mind in future code.
(BTW, if for whatever reason in the future we decide that we require a minimum of Python 3.7, we can change this to `text=True` and then it will "just work" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56517/new/ https://reviews.llvm.org/D56517 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
