Re: [PATCH] powerpc: Fix 64 bits vDSO dwarf info for CR register

2007-10-17 Thread Jakub Jelinek
On Wed, Oct 17, 2007 at 02:26:50PM +1000, Benjamin Herrenschmidt wrote: > Unfortunately, a bug in gcc cause it to not quite work either, but that > is being fixed separately with something around the lines of: > > linux-unwind.h: > > fs->regs.reg[R_CR2].loc.offset = (long) ®s->ccr - new_cfa;

Re: [PATCH v3 9/9] add MPC837x MDS board default device tree

2007-10-17 Thread Kumar Gala
On Oct 14, 2007, at 7:37 PM, David Gibson wrote: > On Fri, Oct 12, 2007 at 09:28:48PM +0800, Li Yang wrote: >> Signed-off-by: Li Yang <[EMAIL PROTECTED]> >> --- >> arch/powerpc/boot/dts/mpc8377_mds.dts | 288 + >> + >> arch/powerpc/boot/dts/mpc8378_mds.dts | 268 ++

Re: [PATCH v4 9/9] add MPC837x MDS board default device tree

2007-10-17 Thread Kumar Gala
On Oct 15, 2007, at 9:56 AM, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8377_mds.dts | 281 ++ > + > arch/powerpc/boot/dts/mpc8378_mds.dts | 263 ++ > +++ > arch/powerpc/boot/dts/mpc8379_mds

Re: [PATCH 3/4] [POWERPC] Add restart support for mpc52xx based platforms

2007-10-17 Thread Stephen Rothwell
On Wed, 17 Oct 2007 15:01:28 +0200 Marian Balakowicz <[EMAIL PROTECTED]> wrote: > > +void __init > +mpc52xx_map_wdt(void) > +{ > +const void *has_wdt; white space damage > + struct device_node *np; > + > + /* mpc52xx_wdt is mapped here and used in mpc52xx_restart, > +

Re: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-17 Thread Kumar Gala
> diff --git a/arch/powerpc/sysdev/fsl_serdes.c b/arch/powerpc/sysdev/ > fsl_serdes.c > new file mode 100644 > index 000..5e91eb7 > --- /dev/null > +++ b/arch/powerpc/sysdev/fsl_serdes.c > @@ -0,0 +1,152 @@ > +/* > + * arch/powerpc/sysdev/fsl_serdes.c > + * > + * Copyright (C) 2007 Freescale

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-17 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: >>I'd use (evt - 1) since the interrupt gets generated at 0x count, >>not 0 (on classic CPUs). With you removing of the code that compensated for > See commit d968014b7280e2c447b20363e576999040ac72ef; I already fixed > that. BTW, while fixing that

Re: can and mpc5200b

2007-10-17 Thread S. Fricke
Hello list, > > Hello Friends, > > what is the reasonable can-driver for a mpc5200b? > > > > I have seen for the peak-3.17 driver a port for the mpc5200 from denx on > > their > > website, but with kernel 2.6.23 I dont have a chance to use this? > > Check this out http://developer.berlios.de/pro

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-17 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: >>I don't see my own signoff or at least a reference to my prior work in >>this patch or even at -rt patch -- despite this code ha clearly borrowed from >>it. And I'm not sure why this crippled version (lacking 40x/ Book E specific >>clockevents implementation) i

Re: [PATCH 01/15] [POWERPC] TQM5200 DTS

2007-10-17 Thread Grant Likely
On 10/17/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > >> + memory { > >> + device_type = "memory"; > >> + reg = < 0400>; // 64MB > >> + }; > >> + > >> + [EMAIL PROTECTED] { > > > > I think we're moving to the

Re: [PATCH 04/15] [POWERPC] CM5200 DTS

2007-10-17 Thread Grant Likely
On 10/17/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > David Gibson wrote: > > [snip] > >> +[EMAIL PROTECTED] { > >> +device_type = "rom"; > >> +compatible = "direct-mapped"; > >> +reg = <0c00 0200>; > >> +

Re: [PATCH 1/4] [POWERPC] Add mpc52xx_find_and_map_path(), refactor utility functions

2007-10-17 Thread Grant Likely
On 10/17/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > > Add helper routine mpc52xx_find_and_map_path(). Extract common code to > mpc52xx_map_node() and refactor mpc52xx_find_and_map(). > > Signed-off-by: Jan Wrobel <[EMAIL PROTECTED]> > Reviewed-by: Grant Likely <[EMAIL PROTECTED]> Yeah, thi

Re: [PATCH 2/4] [POWERPC] Update device tree binding for mpc5200 gpt

2007-10-17 Thread Grant Likely
On 10/17/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > > Add 'fsl,' prefix to 'compatible' property for gpt nodes. > Add 'fsl,' prefix to empty, GPT0 specific 'has-wdt' property. > > diff --git a/drivers/char/watchdog/mpc5200_wdt.c > b/drivers/char/watchdog/mpc5200_wdt.c > index 564143d..9aab

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-17 Thread Joachim Fenkes
On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote: > One small change - I intend to remove the name and owner fields from > struct of_platform_driver, so you should not bother initialising the name > field and just initialise the name field of the embedded struct > device_driver instead. T

Re: [PATCH] qe_lib: export symbols to fix compile error when QE drivers compile as modules

2007-10-17 Thread Kumar Gala
On May 25, 2007, at 7:15 AM, Kumar Gala wrote: > > On May 24, 2007, at 9:45 PM, Li Yang-r58472 wrote: > >> >>> -Original Message- >>> From: Kumar Gala [mailto:[EMAIL PROTECTED] >>> Sent: Thursday, May 24, 2007 7:44 PM >>> To: Li Yang-r58472 >>> Cc: Paul; linuxppc-dev@ozlabs.org >>> Subjec

Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Stephen Hemminger
Please don't use double underscore, for this function name. There is no reason to not make it a normal API call. The sky2 fix I am working on will use napi_synchronize as well. --- a/include/linux/netdevice.h 2007-10-16 16:48:20.0 -0700 +++ b/include/linux/netdevice.h 2007-10-17 08:29:55.

Re: [POWERPC 03/15] [POWERPC] TQM5200 board support

2007-10-17 Thread Scott Wood
Marian Balakowicz wrote: > Scott Wood wrote: >>> +void tqm5200_show_cpuinfo(struct seq_file *m) >>> +{ >>> + struct device_node* np = of_find_all_nodes(NULL); >>> + const char *model = NULL; >>> + >>> + if (np) >>> + model = of_get_property(np, "model", NULL); >>> + >>> + seq_prin

Re: [PATCH v2 1/4] Implement {read,update}_persistent_clock.

2007-10-17 Thread Sergei Shtylyov
Hello. Tony Breeds wrote: > With these functions implemented we cooperate better with the generic > timekeeping code. This obsoletes the need for the timer sysdev as a bonus. Aha, I'm seeing it's not merged to mainline yet! And this can't be merged to -rt patch either, beucase -rt alsread

Re: linux-2.6.git: cannot build PS3 image

2007-10-17 Thread Scott Wood
Geert Uytterhoeven wrote: >> diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper >> index 39b27e5..795f988 100755 >> --- a/arch/powerpc/boot/wrapper >> +++ b/arch/powerpc/boot/wrapper >> @@ -232,7 +232,7 @@ base=0x`${CROSS}nm "$ofile" | grep ' _start$' | cut -d' >> ' -f1` >> entry=

Re: [PATCH 3/4] [POWERPC] Add restart support for mpc52xx based platforms

2007-10-17 Thread Grant Likely
On 10/17/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > > Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart(). > > This patch relies on Sascha Hauer's patch published in: > http://patchwork.ozlabs.org/linuxppc/patch?id=8910. > > Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED

Re: [PATCH 4/4] [POWERPC] Enable restart support for lite5200 board

2007-10-17 Thread Grant Likely
On 10/17/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > > Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> Looks good; I'll pick this one up when you respin the others. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. [EMAIL PROTECTED] (403) 399-0195 __

Re: [PATCH] powerpc: Fix 64 bits vDSO dwarf info for CR register

2007-10-17 Thread Andrew Haley
Jakub Jelinek writes: > On Wed, Oct 17, 2007 at 02:26:50PM +1000, Benjamin Herrenschmidt wrote: > > Unfortunately, a bug in gcc cause it to not quite work either, but that > > is being fixed separately with something around the lines of: > > > > linux-unwind.h: > > > > fs->regs.reg[R_

RE: Merge dtc

2007-10-17 Thread Stephen Neuendorffer
> -Original Message- > From: > [EMAIL PROTECTED] > g > [mailto:[EMAIL PROTECTED] zlabs.org] On Behalf Of Grant Likely > Sent: Wednesday, October 17, 2007 6:15 AM > To: Grant Likely; Paul Mackerras; Josh Boyer; linuxppc-dev@ozlabs.org > Subject: Re: Merge dtc > > On 10/16/07, David Gibs

[PATCH] bestcomm: Restrict disabling of bus prefetch to original mpc5200 silicon.

2007-10-17 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Only the MPC5200 needs this bug fix. MPC5200B is okay. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- Sven, Domen; Can you please test this patch? Thanks, g. arch/powerpc/sysdev/bestcomm/bestcomm.c |9 ++--- include/asm-powerpc/mpc52xx.h

Re: [PATCH] bestcomm: Restrict disabling of bus prefetch to original mpc5200 silicon.

2007-10-17 Thread Sven Luther
On Wed, Oct 17, 2007 at 10:36:27AM -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Only the MPC5200 needs this bug fix. MPC5200B is okay. > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > Sven, Domen; > > Can you please test this patch? I will test it tomor

[PATCH] [POWERPC] lite5200: Add bestcomm to defconfigs

2007-10-17 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Add bestcomm to lite5200 defconfig Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/configs/lite5200_defconfig | 56 --- 1 files changed, 43 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/configs/lit

Re: boards in arch/ppc -> arch/powerpc for 85xx

2007-10-17 Thread David Woodhouse
On Mon, 2007-10-15 at 18:07 -0500, Kumar Gala wrote: > Guys, > > I was wondering if you cared about the following boards existing in > arch/powerpc: > > * STX GP3 > * TQM 85xx > * SBC 8560 > > I'm told WR doesn't care about the SBC 8560, so I'll see if David does. Well, I found an sbc8560 in

[PATCH] fs_enet: Update for API changes

2007-10-17 Thread Scott Wood
This driver was recently broken by several changes for which this driver was not (or was improperly) updated: 1. SET_MODULE_OWNER() was removed. 2. netif_napi_add() was only being called when building with the old CPM binding. 3. The received/budget test was backwards. 4. to_net_dev() was wrong --

[PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Anton Vorontsov
Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 causing NAPI-less ethernet malfunctioning. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- if (...) #if ...; #endif good candidate for checkpatch? drivers/net

Re: Merge dtc

2007-10-17 Thread Timur Tabi
Kumar Gala wrote: > Just out of interest who's complaining? We don't include mkimage for > u-boot related builds and I haven't seen any gripes related to that. I think we should include mkimage *and* dtc. But then, I'm not sure how much weight my opinion has. :-) -- Timur Tabi Linux Kernel

Re: Merge dtc

2007-10-17 Thread Josh Boyer
On Wed, 17 Oct 2007 14:59:04 -0500 Timur Tabi <[EMAIL PROTECTED]> wrote: > Kumar Gala wrote: > > > Just out of interest who's complaining? We don't include mkimage for > > u-boot related builds and I haven't seen any gripes related to that. > > I think we should include mkimage *and* dtc. Bu

Re: [PATCH 1/2] qemu platform, v2

2007-10-17 Thread Grant Likely
On 9/30/07, David Gibson <[EMAIL PROTECTED]> wrote: > On Fri, Sep 28, 2007 at 06:53:28PM +0200, Segher Boessenkool wrote: > > >> I'd be following this more closely if compiling a device tree didn't > > >> currently > > >> require an external utility (dtc or some such) that doesn't come with > > >>

Re: Merge dtc

2007-10-17 Thread Grant Likely
On 10/17/07, Josh Boyer <[EMAIL PROTECTED]> wrote: > On Wed, 17 Oct 2007 14:59:04 -0500 > Timur Tabi <[EMAIL PROTECTED]> wrote: > > > Kumar Gala wrote: > > > > > Just out of interest who's complaining? We don't include mkimage for > > > u-boot related builds and I haven't seen any gripes related t

Re: Merge dtc

2007-10-17 Thread Linas Vepstas
On Wed, Oct 17, 2007 at 02:59:04PM -0500, Timur Tabi wrote: > Kumar Gala wrote: > > > Just out of interest who's complaining? We don't include mkimage for > > u-boot related builds and I haven't seen any gripes related to that. > > I think we should include mkimage *and* dtc. But then, I'm no

Re: Merge dtc

2007-10-17 Thread Jon Loeliger
So, like, the other day Linas Vepstas mumbled: > > Isn't anyone concerned about the defacto fork-of-source-code that > this causes? You betcha. That's why I'm negative on the notion, but I won't stand in front of _that_ train either. > Which will be the official version? The one I am maintain

Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 08:31 -0700, Stephen Hemminger wrote: > Please don't use double underscore, for this function name. There is no > reason to not make it a normal API call. > > The sky2 fix I am working on will use napi_synchronize as well. Allright. A compiler barrier in the !SMP case makes

[PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
net: Add __napi_synchronize() to sync with napi poll The EMAC driver which needs to handle multiple devices with one NAPI instance implements its own per-channel disable bit. However, when setting such a bit, it needs to synchronize with the poller (that is make sure that any pending poller instan

Re: [PATCH 1/2] qemu platform, v2

2007-10-17 Thread Rob Landley
On Wednesday 17 October 2007 3:28:41 pm Grant Likely wrote: > > Including .dtbs in the kernel tree has a big practical problem: > > they're binary, so can't be patch(1)ed, which makes updating them a > > complete PITA. I note that kconfig includes the lex/yacc output files (blah.c_shipped) so you

Re: [PATCH] fs_enet: Update for API changes

2007-10-17 Thread Vitaly Bordug
Hello Scott, On Wed, 17 Oct 2007 12:42:43 -0500 Scott Wood wrote: > This driver was recently broken by several changes for which this > driver was not (or was improperly) updated: > > 1. SET_MODULE_OWNER() was removed. > 2. netif_napi_add() was only being called when building with > the old CPM

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Linas Vepstas
On Wed, Oct 17, 2007 at 05:12:27PM +1000, Michael Ellerman wrote: > +struct device_node *of_get_pci_dev_node(struct pci_dev *pdev) > +{ > + return of_node_get(pci_device_to_OF_node(pdev)); > +} [...] > - dn = of_node_get(pci_device_to_OF_node(dev)); > + dn = of_get_pci_dev_node(dev

[PATCH] Move _rtc_time() routines under CONFIG_ADB_CUDA

2007-10-17 Thread Badari Pulavarty
Fix to clean up compile warnings (against 2.6.23-git12) Thanks, Badari to_rtc_time() and from_rtc_time() seems to be used only if CONFIG_ADB_CUDA defined. Moving them under that ifdef. arch/powerpc/platforms/powermac/time.c:88: warning: `to_rtc_time' defined but not used arch/powerpc/platforms/

[PATCH] fix EMAC driver for proper napi_synchronize API

2007-10-17 Thread Benjamin Herrenschmidt
The EMAC driver "fix" was merged by mistake before the dust had settled on the new napi synchronize interface (and before it got merged). The final version of that function is spelled without underscores. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- Index: linux-work/drivers/net

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Josh Boyer
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote: > net: Add __napi_synchronize() to sync with napi poll > > The EMAC driver which needs to handle multiple devices with one > NAPI instance implements its own per-channel disable bit. However, > when setting such a bit, it needs to sy

[PATCH] commit e8f605cd71aa09a8f8b73f410a15d2a46022a60e

2007-10-17 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> mpc8349emitx(gp): add UHCI and USB storage support USB support for the 8349itx got added a while back; but the defconfig never got updated. This patch adds the appropriate USB config options to defconfig Signed-off-by: Grant Likely <[EMAIL

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 18:36 -0500, Josh Boyer wrote: > On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote: > > net: Add __napi_synchronize() to sync with napi poll > > > > The EMAC driver which needs to handle multiple devices with one > > NAPI instance implements its own per-channel

Re: 2.6.23-mm1 - build failure with advansys

2007-10-17 Thread Paul Mackerras
Andrew Morton writes: > On Sat, 13 Oct 2007 10:14:22 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > The functions virt_to_bus and bus_to_virt are begin defined between ifdef > > CONFIG_PPC32 > > but when i compile allyesconfig with ppc64 box,i get this error. This patch > > removes the >

Re: [PATCH] fs_enet: Update for API changes

2007-10-17 Thread Jeff Garzik
Scott Wood wrote: > This driver was recently broken by several changes for which this > driver was not (or was improperly) updated: > > 1. SET_MODULE_OWNER() was removed. > 2. netif_napi_add() was only being called when building with > the old CPM binding. > 3. The received/budget test was backwar

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Jeff Garzik
Anton Vorontsov wrote: > Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 > causing NAPI-less ethernet malfunctioning. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> applied ___

Re: [PATCH] fix EMAC driver for proper napi_synchronize API

2007-10-17 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The EMAC driver "fix" was merged by mistake before the dust had settled on > the new napi synchronize interface (and before it got merged). The final > version of that function is spelled without underscores. > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECT

Re: [PATCH 04/15] [POWERPC] CM5200 DTS

2007-10-17 Thread David Gibson
On Wed, Oct 17, 2007 at 02:22:04PM +0200, Marian Balakowicz wrote: > David Gibson wrote: > > [snip] > >> + [EMAIL PROTECTED] { > >> + device_type = "rom"; > >> + compatible = "direct-mapped"; > >> + reg = <0c00 0200>; > >> +

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-17 Thread Paul Mackerras
Sergei Shtylyov writes: > > Tony started from an earlier patch by John Stultz, not from your > > patches. > > Well, that I can believe, yet the clockevents patch has traces of my > former work, and looking at read_persisitent_time() it looks suspiciously > close to my version too... There i

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-17 Thread Paul Mackerras
Sergei Shtylyov writes: > BTW, while fixing that for classic PPC, but you've broke it for 40x / > book > E CPU which interrupt at 0. Congratulations. :-) What problem do you see arising from this? Paul. ___ Linuxppc-dev mailing list Linuxppc-dev

Re: boards in arch/ppc -> arch/powerpc for 85xx

2007-10-17 Thread Kumar Gala
On Oct 17, 2007, at 1:39 PM, David Woodhouse wrote: > > On Mon, 2007-10-15 at 18:07 -0500, Kumar Gala wrote: >> Guys, >> >> I was wondering if you cared about the following boards existing in >> arch/powerpc: >> >> * STX GP3 >> * TQM 85xx >> * SBC 8560 >> >> I'm told WR doesn't care about the SBC

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Josh Boyer
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote: > net: Add __napi_synchronize() to sync with napi poll > > The EMAC driver which needs to handle multiple devices with one > NAPI instance implements its own per-channel disable bit. However, > when setting such a bit, it needs to sy

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
> This implements a low level __napi_synchronize() function to acheive > that. The underscores are to emphasis the low level aspect of it and > to discourage driver writers who don't know what they are doing to > use it (to please DaveM :-) And I forgot to remove that bit from the description...

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Michael Ellerman
On Wed, 2007-10-17 at 04:23 -0700, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Wed, 17 Oct 2007 04:22:29 -0700 (PDT) > > > From: Michael Ellerman <[EMAIL PROTECTED]> > > Date: Wed, 17 Oct 2007 17:12:27 +1000 (EST) > > > > > Use of_get_pci_dev_node() in axon_msi.c. Switch

[PATCH] synchronize_irq needs a barrier

2007-10-17 Thread Benjamin Herrenschmidt
synchronize_irq needs at the very least a compiler barrier and a read barrier on SMP, but there are enough cases around where a write barrier is also needed and it's not a hot path so I prefer using a full smp_mb() here. It will degrade to a compiler barrier on !SMP. Signed-off-by: Benjamin Herre

Re: [PATCH] commit e8f605cd71aa09a8f8b73f410a15d2a46022a60e

2007-10-17 Thread Grant Likely
On 10/17/07, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > mpc8349emitx(gp): add UHCI and USB storage support Oops, sorry about the subject line; I kind of messed that up in stgit. g. > > USB support for the 8349itx got added a while back; but the defc

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Michael Ellerman
On Wed, 2007-10-17 at 21:36 +1000, Benjamin Herrenschmidt wrote: > > I find it ironic that you add of_get_pci_dev_node() as a function > > which gets the node and grabs a reference to it, and then the very > > first usage you make of it doesn't drop the reference at all. > > > > That reference gra

Re: [PATCH] synchronize_irq needs a barrier

2007-10-17 Thread Andrew Morton
On Thu, 18 Oct 2007 11:25:42 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > synchronize_irq needs at the very least a compiler barrier and a > read barrier on SMP, Why? > but there are enough cases around where a > write barrier is also needed and it's not a hot path so I prefer > usi

Re: 2.6.23-mm1 - build failure with advansys

2007-10-17 Thread Matthew Wilcox
On Thu, Oct 18, 2007 at 10:07:54AM +1000, Paul Mackerras wrote: > The correct fix is to make advansys depend on CONFIG_VIRT_TO_BUS, or > alternatively fix advansys.c properly by making it use the interfaces > described in Documentation/DMA-mapping.txt (or the equivalent scsi > helpers). If you loo

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Michael Ellerman
On Wed, 2007-10-17 at 18:04 -0500, Linas Vepstas wrote: > On Wed, Oct 17, 2007 at 05:12:27PM +1000, Michael Ellerman wrote: > > > +struct device_node *of_get_pci_dev_node(struct pci_dev *pdev) > > +{ > > + return of_node_get(pci_device_to_OF_node(pdev)); > > +} > > [...] > > > - dn = of_

Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 20:02 -0500, Josh Boyer wrote: > k, trying again, leaving the actual patch below. In the above patch > description, you still call it __napi_synchronize. In the patch > below, > it's napi_syncronize. > > I was just trying to point out to whomever commits this patch that th

Re: [PATCH] synchronize_irq needs a barrier

2007-10-17 Thread Benjamin Herrenschmidt
> > Index: linux-work/kernel/irq/manage.c > > === > > --- linux-work.orig/kernel/irq/manage.c 2007-10-18 11:22:16.0 > > +1000 > > +++ linux-work/kernel/irq/manage.c 2007-10-18 11:22:20.0 +1000 > > @@ -33,6 +33,7

libfdt: Make fdt_string() return a const pointer

2007-10-17 Thread David Gibson
Currently, fdt_string() returns a (non-const) char *, despite taking a const void *fdt. This is inconsistent with all the other read-only functions which all return const pointers into the blob. This patch fixes that. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: dtc/libfdt/fdt_ro.c ==

Re: [PATCH] synchronize_irq needs a barrier

2007-10-17 Thread Linus Torvalds
On Thu, 18 Oct 2007, Benjamin Herrenschmidt wrote: > > + smp_mb(); > while (desc->status & IRQ_INPROGRESS) > cpu_relax(); So, what exactly does it protect against? At a minimum, this needs a comment in the changelog, and probably preferably in the source code too. The

[PATCH] bootwrapper: Allow wrapper script to execute verbosely

2007-10-17 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Allow wrapper script to print verbose progress when the V is set in the environment. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/boot/wrapper |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boo

Re: [PATCH] synchronize_irq needs a barrier

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 19:12 -0700, Linus Torvalds wrote: > > So, what exactly does it protect against? At a minimum, this needs a > comment in the changelog, and probably preferably in the source code too. I replied to Andrew, but I agree, it's worth a comment, I'll add one. > The thing is, sy

RE: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-17 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 10:13 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v3 3/9] add Freescale SerDes PHY support > {snip} This patch has been superseded by v

Re: [PATCH] synchronize_irq needs a barrier

2007-10-17 Thread Benjamin Herrenschmidt
> > In general, I tend to think that for this function to make any sense > (that is, to synchronize anything at all), it needs a barrier or you are > just making a decision based on a totally random value of desc->status > since it can have been re-ordered, speculatively loaded, pre-fetched, > wh

what's inside INT_FRAME_SIZE?

2007-10-17 Thread Wang, Baojun
hi, I need setup a stack frame manually under powerpc, sounds like I need prepare at least for size INT_FRAME_SIZE (192 bytes through asm-offset.h), I know the bottom 176 bytes are for struct pt_regs, how about the upper 16 (STACK_FRAME_OVERHEAD) bytes? what's inside this 16 bytes? Could you

RE: [PATCH v4 9/9] add MPC837x MDS board default device tree

2007-10-17 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 9:55 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v4 9/9] add MPC837x MDS board default device tree > > > On Oct 15, 2007, at 9:56 AM, L

RE: [PATCH v3 4/9] add platform support for MPC837x MDS board

2007-10-17 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 9:47 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v3 4/9] add platform support for MPC837x MDS board > > > On Oct 12, 2007, at 8:28 AM,

[PATCH] gianfar: fix compile warning

2007-10-17 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Eliminate an uninitialized variable warning. The code is correct, but a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent. Since addr has never been initialized, and the compiler doesn't know what dma_alloc_coherent will do with it, it

RE: [PATCH v3 2/9] ipic: add new interrupts introduced by new chip

2007-10-17 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 9:46 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v3 2/9] ipic: add new interrupts > introduced by new chip > > > On Oct 12, 2007, at 8

dtc: Make helper macros in trees.S more flexible

2007-10-17 Thread David Gibson
This patch makes the helper macros in trees.S use separate labels for the end of each dt subblock, rather than using only start labels. This means that the macros can now be used to create trees with the subblocks in non-standard orders. In addition, it adds a bunch of extra ; after lines of asm c

libfdt: Add missing RW_CHECK_HEADER to fdt_del_node()

2007-10-17 Thread David Gibson
fdt_del_node(), unlike most of the rw functions does not check the fdt's header with RW_CHECK_HEADER. However, it could make a mess of things if the conditions in RW_CHECK_HEADER aren't met. So, this patch adds the omitted check. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: dtc/libfdt

Re: [PATCH 1/2] [SPARC/64] Consolidate of_register_driver

2007-10-17 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 13:41:23 +1000 > Also of_unregister_driver. These will be shortly also used by the > PowerPC code. > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> I'll apply this and push it onward, thanks Stephen! __

Re: [PATCH 5/5] IB/ehca: Enable large page MRs by default

2007-10-17 Thread Roland Dreier
thanks, applied 1-5 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Stephen Rothwell
On Wed, 17 Oct 2007 18:04:49 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: > > Is this really useful or wise? Yes, it is. We are *replacing* an interface that does no ref counting with one that does. > As a matter of personal taste, I find stuff like this clutters What has taste got to do with

[PATCH 1/2] Introduce of_get_pci_dev_node()

2007-10-17 Thread Michael Ellerman
Both powerpc and sparc have a routine, pci_device_to_OF_node(), which returns the device_node associated with a given pci device. The new routine, of_get_pci_dev_node(), performs exactly the same function with the one exception that it returns a refcounted pointer to the device_node, callers must

[PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Michael Ellerman
Use of_get_pci_dev_node() in axon_msi.c. Switch to including so we get the prototype. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/axon_msi.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/cell/axon_msi.

Re: vga16fb doesn't build on powerpc (vgacon_remap_base)

2007-10-17 Thread Geert Uytterhoeven
On Tue, 16 Oct 2007, Joseph Fannin wrote: > vga16fb is an available config option on powerpc, but it won't link > with my .config: > > ERROR: "vgacon_remap_base" [drivers/video/vga16fb.ko] undefined! > > > I'm guessing this is because include/asm-powerpc/vga.h declares > vgacon_remap_base:

Re: [PATCH] Fix vmemmap warning in init_64..c

2007-10-17 Thread Geert Uytterhoeven
On Wed, 17 Oct 2007, Tony Breeds wrote: > Use the right printk format to silence the following warning. > > CC arch/powerpc/mm/init_64.o > arch/powerpc/mm/init_64.c: In function 'vmemmap_populate': > arch/powerpc/mm/init_64.c:243: warning: format '%p' expects type 'void *', > but argument

Re: vga16fb doesn't build on powerpc (vgacon_remap_base)

2007-10-17 Thread Benjamin Herrenschmidt
On Wed, 2007-10-17 at 10:49 +0200, Geert Uytterhoeven wrote: > > > > So VGACON probably doesn't work either on 32bit. I'm guessing > arch/powerpc > > doesn't support PREP. > > It's not only useful for PREP, but also for CHRP. > > > How best could this be fixed up? Or should I just let the thin

Re: [PATCH 01/15] [POWERPC] TQM5200 DTS

2007-10-17 Thread Marian Balakowicz
Grant Likely wrote: >> + memory { >> + device_type = "memory"; >> + reg = < 0400>; // 64MB >> + }; >> + >> + [EMAIL PROTECTED] { > > I think we're moving to the convetion of naming these nodes > "soc@" now. (You can drop the 5200 for

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread David Miller
From: Michael Ellerman <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 17:12:27 +1000 (EST) > Use of_get_pci_dev_node() in axon_msi.c. Switch to including > so we get the prototype. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> I find it ironic that you add of_get_pci_dev_node() as a funct

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 04:22:29 -0700 (PDT) > From: Michael Ellerman <[EMAIL PROTECTED]> > Date: Wed, 17 Oct 2007 17:12:27 +1000 (EST) > > > Use of_get_pci_dev_node() in axon_msi.c. Switch to including > > so we get the prototype. > > > > Signed-off-by: Mi

Re: [POWERPC 03/15] [POWERPC] TQM5200 board support

2007-10-17 Thread Marian Balakowicz
Grant Likely wrote: > Both this patch and the CM5200 support patch (#6 in your series) are > pretty much clones of lite5200.c. I don't think this is the right > approach. Don't duplicate code in this way. Determine the common > bits and put them in a common place to be usable by any 5200 board >

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Benjamin Herrenschmidt
> I find it ironic that you add of_get_pci_dev_node() as a function > which gets the node and grabs a reference to it, and then the very > first usage you make of it doesn't drop the reference at all. > > That reference grabbing aspect of the new interface is obviously very > useful! :-) > > Kid

Re: [POWERPC 03/15] [POWERPC] TQM5200 board support

2007-10-17 Thread Marian Balakowicz
Scott Wood wrote: > >> +void tqm5200_show_cpuinfo(struct seq_file *m) >> +{ >> +struct device_node* np = of_find_all_nodes(NULL); >> +const char *model = NULL; >> + >> +if (np) >> +model = of_get_property(np, "model", NULL); >> + >> +seq_printf(m, "vendor\t\t: Free

Re: dtc: Restore missing code for testcases

2007-10-17 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > Recent commits 333542fabf8720b881e992a5abca32ef4bcb841a and > fd1bf3a5ae46962528ef89a824261a88830758a2 added new testcases to dtc. > However, although the testcases were added to the Makefile and > run_tests.sh, one of the .c files for the testcase wa

Re: dtc: Improve -Odts output

2007-10-17 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > This patch makes improvements to the way properties are printed when > in dtc is producing dts output. > - Characters which need escaping are now properly handled when > printing properties as strings > - The heuristics for what format t

Re: [PATCH 04/15] [POWERPC] CM5200 DTS

2007-10-17 Thread Marian Balakowicz
David Gibson wrote: > [snip] >> +[EMAIL PROTECTED] { >> +device_type = "rom"; >> +compatible = "direct-mapped"; >> +reg = <0c00 0200>; >> +probe-type = "CFI"; >> +bank-width = <2>

Re: Please pull linux-2.6-mpc52xx.git

2007-10-17 Thread Paul Mackerras
Grant Likely writes: > There are remaining outstanding comments; but my opinion is that they > should be addressed in subsequent patches (performance optimization > for mp5200b boards and making the sram management code a generic > interface usable by other SoC support code). > > If you agree; pl

Re: [PATCH v2 1/4] Implement {read,update}_persistent_clock.

2007-10-17 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: >> Eh... poor you. Tony got clockevent driver reengineered for no apparent >>reason. And he's introduced the jiffy drift by deleting the main loop from >>timer_interrupt(). Yet this borken version was preferred to what was known >>working since about 2.6

Please pull powerpc.git merge branch

2007-10-17 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get some a collection of fixes for powerpc, plus a set of commits that add some new driver code for the "bestcomm" hardware on some Freescale embedded PowerPC chips. Thanks, Paul. arch/powerp

[PATCH 0/4] [POWERPC] MPC5200: update gpt binding, add restart support

2007-10-17 Thread Marian Balakowicz
This is a reworked version of patches to MPC5200 common code that were send together with the TQM5200/CM5200/Motion-PRO board support chnages. As there are some open issues in a board support code and to avoid additional respin I would like to have those reviewed first. [PATCH 1/4] [POWERPC] Add

[PATCH 2/4] [POWERPC] Update device tree binding for mpc5200 gpt

2007-10-17 Thread Marian Balakowicz
Add 'fsl,' prefix to 'compatible' property for gpt nodes. Add 'fsl,' prefix to empty, GPT0 specific 'has-wdt' property. Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> --- Documentation/powerpc/mpc52xx-device-tree-bindings.txt |4 +- arch/powerpc/boot/dts/lite5200.dts

[PATCH 3/4] [POWERPC] Add restart support for mpc52xx based platforms

2007-10-17 Thread Marian Balakowicz
Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart(). This patch relies on Sascha Hauer's patch published in: http://patchwork.ozlabs.org/linuxppc/patch?id=8910. Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> Signed-off-by: Sascha Hauer <[EMAIL PROTECTED]> --- arch/powerpc

[PATCH 4/4] [POWERPC] Enable restart support for lite5200 board

2007-10-17 Thread Marian Balakowicz
Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> --- lite5200.c |4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/platforms/52xx/lite5200.c b/arch/powerpc/platforms/52xx/lite5200.c index 0caa3d9..ce9e3ee 100644 --- a/arch/powerpc/platforms/52xx/lite5200.c +++ b/arch/po

  1   2   >