[PATCH 3/3] Use __weak macro for smp_setup_processor_id

2008-04-17 Thread Benjamin Herrenschmidt
Use the __weak macro instead of the longer __attribute__ ((weak)) form Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> -- init/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-work.orig/init/main.c 2008-04-18 16:44:32.0 +1000 +++ linux-work/init/main.c

[PATCH 2/3] [POWERPC] Fix kernel stack allocation alignment

2008-04-17 Thread Benjamin Herrenschmidt
The powerpc kernel stacks need to be naturally aligned, as they contain the thread info at the bottom, which is obtained by clearing the low bits of the stack pointer. However, when using 64K pages (the stack is smaller than a page), we use kmalloc to allocate it, which doesn't provide that guaran

[PATCH 1/3] Add thread_info_cache_init() weak hook

2008-04-17 Thread Benjamin Herrenschmidt
Some architecture need to maintain a kmem cache for thread info structures. (next patch adds that to powerpc to fix an alignment problem). There is no good arch callback to use to initialize that cache that I can find, so this adds a new one in the form of a weak function whose default is empty.

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Benjamin Herrenschmidt
> > so what > > about the patch below ? > > I like it, but the compiler won't ;) > > > If you're ok, I'll re-send with appropriate sob > > & adapted powerpc part. > > Sure. > > > +void __init __attribute__((weak) thread_info_cache_init(void) > > s/weak)/weak))/ Yeah, missing quilt ref :-) I

Re: 2.6.25-mm1 on the g5

2008-04-17 Thread Paul Mackerras
Andrew Morton writes: > It had been running happily and hard for a couple of hours when: Looks like the bug that Kamalesh Babulal reported and which I have been chasing without success so far. > That's a pretty crappy trace. Perhaps netconsole lost some of it, dunno. Yeah, there's a bug in the

2.6.25-mm1 on the g5

2008-04-17 Thread Andrew Morton
It had been running happily and hard for a couple of hours when: registered taskstats version 1 Freeing unused kernel memory: 304k freed windfarm: CPUs control loops started. EXT3-fs: INFO: recovery required on readonly filesystem. EXT3-fs: write access will be enabled during recovery. kjournald

[PATCH 2.6.26?] Raise the upper limit of NR_CPUS.

2008-04-17 Thread Tony Breeds
As the pacas are statically initialised increasing NR_CPUS beyond 128, means that any additional pacas will be empty ... which is bad. This patch adds the required functionality to fill in any excess pacas at runtime. Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> --- I know it's late, but can t

[POWERPC] Optimize fls64() on 64-bit processors

2008-04-17 Thread Paul Mackerras
64-bit powerpc processors can find the leftmost 1 bit in a 64-bit doubleword in one instruction, so use that rather than using the generic fls64(), which does two 32-bit fls() calls. Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]> --- This is on top of a patch from Alexander van Heukelum that wa

Re: [RFC/PATCH 3/4] Use pseries_setup_i8259_cascade() in pseries_mpic_init_IRQ()

2008-04-17 Thread Michael Ellerman
On Fri, 2008-04-18 at 14:15 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > > pseries_mpic_init_IRQ() implements the same logic as the xics code did to > > find the i8259 cascade irq. Now that we've pulled that logic out into > > pseries_setup_i82

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Michael Ellerman
On Thu, 2008-04-17 at 21:19 -0700, Andrew Morton wrote: > On Fri, 18 Apr 2008 13:58:06 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > > > > > > > otoh, if only one .c file will ever call this function then I think > > > > > that > > > > > all problems are solved by > > > > > > >

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Kyle McMartin
On Fri, Apr 18, 2008 at 01:58:06PM +1000, Benjamin Herrenschmidt wrote: > Well, looking there, I saw we already used weak symbols for that so what > about the patch below ? If you're ok, I'll re-send with appropriate sob > & adapted powerpc part. > This is definitely the cleanest way to do this f

Re: [PATCH 1/5] [POWERPC] sysdev: implement FSL GTM support

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 5:47 PM, Anton Vorontsov wrote: On Thu, Apr 17, 2008 at 11:28:32PM +0400, Anton Vorontsov wrote: GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Andrew Morton
On Fri, 18 Apr 2008 13:58:06 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > otoh, if only one .c file will ever call this function then I think that > > > > all problems are solved by > > > > > > > > a) moving the above ifdeffery into the .c file > > > > b) adding a comment e

Re: [RFC/PATCH 4/4] Simplify xics direct/lpar irq_host setup

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > The xics code currently has a direct and lpar variant of xics_host_map, the > only difference being which irq_chip they use. If we remember which irq_chip > we're using we can combine these two routines. That also allows us to have a > s

Re: [RFC/PATCH 3/4] Use pseries_setup_i8259_cascade() in pseries_mpic_init_IRQ()

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > pseries_mpic_init_IRQ() implements the same logic as the xics code did to > find the i8259 cascade irq. Now that we've pulled that logic out into > pseries_setup_i8259_cascade() we can use it in the mpic code. > > Signed-off-by: Michael

Re: [RFC/PATCH 2/4] Turn xics_setup_8259_cascade() into a generic pseries_setup_i8259_cascade()

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > Remove the xics references from xics_setup_8259_cascade(), and merge the > good bits from the almost identical logic in pseries_mpic_init_IRQ(). > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <

Re: [RFC/PATCH 1/4] Move xics_setup_8259_cascade() into platforms/pseries/setup.c

2008-04-17 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 17:42 +1100, Michael Ellerman wrote: > The code in xics.c to setup the i8259 cascaded irq handler is not really > xics specific, so move it into setup.c - we will clean this up further in > a subsequent patch. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

2008-04-17 Thread Benjamin Herrenschmidt
> > > otoh, if only one .c file will ever call this function then I think that > > > all problems are solved by > > > > > > a) moving the above ifdeffery into the .c file > > > b) adding a comment explaining which arch file must provide the override > > > c) directly including that file from with

Re: More patches pushed to powerpc.git master and powerpc-next branches (second try)

2008-04-17 Thread Michael Ellerman
Hi Paul, Can you grab these when you're bored? http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=17653 http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=17654 http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=17655 http://patchwork.ozlabs.org/linuxppc/patch?q=ellerman&id=1765

RE: [PATCH v2][POWERPC] qe_lib and ucc_geth: switch to the cpm_muram implementation

2008-04-17 Thread Li Yang
> -Original Message- > From: Wood Scott > Sent: Thursday, April 17, 2008 10:11 PM > To: Li Yang > Cc: [EMAIL PROTECTED]; Kumar Gala; > linuxppc-dev@ozlabs.org; Jeff Garzik; Tabi Timur; > [EMAIL PROTECTED] > Subject: Re: [PATCH v2][POWERPC] qe_lib and ucc_geth: switch > to the cpm_muram

[PATCH] [POWERPC] Port fixmap from x86 and use for kmap_atomic

2008-04-17 Thread Kumar Gala
The fixmap code from x86 allows us to have compile time virtual addresses that we change the physical addresses of at run time. This is useful for applications like kmap_atomic, PCI config that is done via direct memory map, kexec/kdump. We got ride of CONFIG_HIGHMEM_START as we can now determine

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 5:41 PM, Anton Vorontsov wrote: On Thu, Apr 17, 2008 at 05:35:53PM -0500, Kumar Gala wrote: index a3f9c3f..a4a195a 100644 --- a/arch/powerpc/sysdev/qe_lib/qe_io.c +++ b/arch/powerpc/sysdev/qe_lib/qe_io.c @@ -20,7 +20,8 @@ #include #include #include - +#include +#include

Re: [PATCH] 86xx: mark functions static, other minor cleanups

2008-04-17 Thread David Gibson
On Mon, Apr 14, 2008 at 09:32:44PM -0400, Paul Gortmaker wrote: > On Fri, Apr 11, 2008 at 3:11 PM, Segher Boessenkool > <[EMAIL PROTECTED]> wrote: > > > > > Updated as per above, and with tickerized prefixes for sbc8641. > > > > > > > Care to try once more? It's only "tickerized" if it's in all >

Re: [EFIKA] Really, don't pretend to be CHRP

2008-04-17 Thread David Gibson
On Thu, Apr 17, 2008 at 04:17:20PM +0100, Matt Sealey wrote: > > David Woodhouse wrote: >> On Thu, 2008-04-17 at 13:28 +0100, Matt Sealey wrote: >>> I thought we were using efika.forth for this in Fedora. >> >> We were, until you pointed out that the kernel actually works just fine >> these days wi

[PATCH] sysdev,mv64x60: initialization of mv64x60 ethernet, serial and I2C

2008-04-17 Thread Remi Machet
This patch affects only the mv64x60 driver. It fixes 2 problem: -If one of the devices of the mv64x60 init fails, the remaining devices are not initialized => I changed the code to display an error and continue the initialization. -I2C parameters freq_m and freq_n are assigned default in the cod

Re: [PATCH 1/5] [POWERPC] sysdev: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 11:28:32PM +0400, Anton Vorontsov wrote: > GTM stands for General-purpose Timers Module and able to generate > timer{1,2,3,4} interrupts. These timers are used by the drivers that > need time precise interrupts (like for USB transactions scheduling for > the Freescale USB Ho

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 05:35:53PM -0500, Kumar Gala wrote: >> index a3f9c3f..a4a195a 100644 >> --- a/arch/powerpc/sysdev/qe_lib/qe_io.c >> +++ b/arch/powerpc/sysdev/qe_lib/qe_io.c >> @@ -20,7 +20,8 @@ >> #include >> #include >> #include >> - >> +#include >> +#include >> #include >> #include

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Kumar Gala
index a3f9c3f..a4a195a 100644 --- a/arch/powerpc/sysdev/qe_lib/qe_io.c +++ b/arch/powerpc/sysdev/qe_lib/qe_io.c @@ -20,7 +20,8 @@ #include #include #include - +#include +#include #include #include #include @@ -214,6 +215,140 @@ int par_io_of_config(struct device_node *np) } EXPORT_SYMBOL(p

Re: [PATCH 3/5] [POWERPC] QE: split par_io_config_pin()

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 04:53:34PM -0500, Kumar Gala wrote: > > On Apr 17, 2008, at 2:28 PM, Anton Vorontsov wrote: >> This patch splits par_io_config_pin so we can use it with GPIO LIB >> API. >> >> Also add a comment regarding #ifdef CONFIG_PPC_85xx being legacy. > > legacy to what? If we'll e

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Timur Tabi
Anton Vorontsov wrote: > static inline bool qe_clock_is_brg(enum qe_clock clk) > { > return clk < QE_CLK1; > } I have no problem with this function (the UART driver could use it), except that your implementation is wrong. You would need to do this: static inline bool qe_clock_is_brg(enum

Re: [PATCH 3/5] [POWERPC] QE: split par_io_config_pin()

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 2:28 PM, Anton Vorontsov wrote: This patch splits par_io_config_pin so we can use it with GPIO LIB API. Also add a comment regarding #ifdef CONFIG_PPC_85xx being legacy. legacy to what? - k ___ Linuxppc-dev mailing list Linux

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 02:56:42PM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > > +config QE_USB > > + bool > > + help > > + QE USB Host Controller support > > Don't you need something like "depends on USB"? I would assume that you need > core USB support before any USB drivers

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Dale Farnsworth
On Thu, Apr 17, 2008 at 03:49:59PM -0500, Timur Tabi wrote: > Dale Farnsworth wrote: > > I find "is_brg" much more meaningful than "clk < QE_CLK1". > > > > Maybe the computer doesn't need it, but it's helpful to a > > reader of the code. > > That's what comments are for. I'm all for self-documen

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Timur Tabi
Dale Farnsworth wrote: > I find "is_brg" much more meaningful than "clk < QE_CLK1". > > Maybe the computer doesn't need it, but it's helpful to a > reader of the code. That's what comments are for. I'm all for self-documenting code, but not creating additional code to avoid comments. -- Timur

[PATCH] Fix for disabling BUG

2008-04-17 Thread Marcelo Dalmas
Hi, With CONFIG_BUG option disabled module_find_bug fuction (module_32.c and module_64.c) don't compile because struct bug_entry isn't defined. Marcelo Dalmas Abra sua conta no Yahoo! Mail, o único sem limite de espaço para armazenamento! http://br.mail.yahoo.com/Index: arch/powerpc/ke

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Dale Farnsworth
Timur Tabi wrote: > Anton Vorontsov wrote: > > > +int qe_usb_clock_set(enum qe_clock clk, int rate) > > +{ > > + struct qe_mux __iomem *mux = &qe_immr->qmx; > > + unsigned long flags; > > + const bool is_brg = clk < QE_CLK1; > > You don't really need "is_brg", since it's only used once. I

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Scott Wood
Timur Tabi wrote: Scott Wood wrote: That's implementation dependent, and support for accesses to uncached memory is being phased out of book E according to the E500 manual. What's wrong with uncached memory? The typical implementation of lwarx/stwcx depends on holding the reserved cache li

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Timur Tabi
Scott Wood wrote: > That's implementation dependent, and support for accesses to uncached > memory is being phased out of book E according to the E500 manual. What's wrong with uncached memory? >> The reservation is held within the processor, so it should work on I/O. > > Even if the core sup

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Scott Wood
Timur Tabi wrote: Scott Wood wrote: No. clrsetbits operates on I/O registers, not RAM. Does lwarx require the EA to be cached memory or something? That's implementation dependent, and support for accesses to uncached memory is being phased out of book E according to the E500 manual. T

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Timur Tabi
Scott Wood wrote: > No. clrsetbits operates on I/O registers, not RAM. Does lwarx require the EA to be cached memory or something? The reservation is held within the processor, so it should work on I/O. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Scott Wood
Timur Tabi wrote: + spin_lock_irqsave(&cmxgcr_lock, flags); + + clrsetbits_be32(&mux->cmxgcr, QE_CMXGCR_USBCS, val); Would it be useful if I made the clrsetbits functions atomic, using lwarx/stwcx.? No. clrsetbits operates on I/O registers, not RAM. -Scott _

Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Timur Tabi
Anton Vorontsov wrote: > +config QE_USB > + bool > + help > + QE USB Host Controller support Don't you need something like "depends on USB"? I would assume that you need core USB support before any USB drivers can be loaded. > --- /dev/null > +++ b/arch/powerpc/sysdev/qe_lib/usb.c

[PATCH] PowerPC 44x: Add NOR flash entry to Canyonlands DTS.

2008-04-17 Thread Valentine Barshak
This patch adds NOR flash entry to the PowerPC 460EX Canyonlands DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/canyonlands.dts | 36 ++ 1 files changed, 36 insertions(+) diff -pruN powerpc/arch/powerpc/boot/dts/canyonlands.d

[PATCH 5/5] [POWERPC] 83xx: new board support: MPC8360E-RDK

2008-04-17 Thread Anton Vorontsov
This is patch adds board file, device tree, and defconfig for the new board, made by Freescale Semiconductor Inc. and Logic Product Development. Currently supported: 1. UEC{1,2,7,4}; 2. I2C; 3. SPI; 4. NS16550 serial; 5. PCI and miniPCI; 6. Intel NOR StrataFlash X16 64Mbit PC28F640P30T85; 7. Graph

[PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Anton Vorontsov
This is needed to access QE GPIOs via Linux GPIO API. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 34 --- arch/powerpc/platforms/Kconfig |2 + arch/powerpc/sysdev/qe_lib/qe_io.c | 137

[PATCH 3/5] [POWERPC] QE: split par_io_config_pin()

2008-04-17 Thread Anton Vorontsov
This patch splits par_io_config_pin so we can use it with GPIO LIB API. Also add a comment regarding #ifdef CONFIG_PPC_85xx being legacy. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/qe_lib/qe_io.c | 60 +++ 1 files changed, 39 inse

[PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

2008-04-17 Thread Anton Vorontsov
This patch adds a function to the qe_lib to setup QE USB clocks routing. To setup clocks safely, cmxgcr register needs locking, so I just reused ucc_lock since it was used only to protect cmxgcr. The idea behind placing clocks routing functions into the qe_lib is that later we'll hopefully switch

[PATCH 1/5] [POWERPC] sysdev: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as found in some QE and CPM chips), or these timers could b

[PATCH 0/5] Few more patches for Kumar's powerpc.git

2008-04-17 Thread Anton Vorontsov
Hello Kumar, Here is respin of my pending patches. I have bunch of others, but they depend on the drivers which I'm going to send for the merge after OF GPIO will hit Linus' tree (otherwise respective subsystem maintainers will fail even to compile-test these drivers). Given that, in worst case,

[RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to support Rev B boards

2008-04-17 Thread Sean MacLennan
PIKA Warp: Update platform code to support Rev B boards. * Switched from 64M NOR/64M NAND to 4M NOR/256M NAND. * Full DTM support including critical temperature. * Added POST information. * Removed LED function, moved to new LED driver. * Moved ad7414 to new style I2C initialization. Signed-off-by

Re: Warp patches for 2.6.26

2008-04-17 Thread Dale Farnsworth
On Thu, Apr 17, 2008 at 01:26:23PM -0400, Sean MacLennan wrote: > On Thu, 17 Apr 2008 09:08:04 -0700 > "Dale Farnsworth" <[EMAIL PROTECTED]> wrote: > > > I didn't suggest splitting the patches or further modification of the > > patches themselves. What I found lacking were the patch descriptions.

Re: USB on MPC8641D

2008-04-17 Thread John Marc
Okie Friend , I will try the latest kernel 2.6.24, and let you know the results. With Regards John Kumar Gala <[EMAIL PROTECTED]> wrote: On Apr 17, 2008, at 3:36 AM, John Marc wrote: > Hi > I Have the kernel patches , but no one for the USB. > The changes for the USB are integrated in

Re: [PATCH 4/5] LED driver

2008-04-17 Thread Sean MacLennan
On Sat, 12 Apr 2008 19:41:30 -0500 Josh Boyer <[EMAIL PROTECTED]> wrote: > This should be sent to Richard Purdie. I spoke with Richard and we agreed that, since the GPIO library will make this driver obsolete, it is not worth committing this driver for, hopefully, only one release. If anybody se

Re: Warp patches for 2.6.26

2008-04-17 Thread Sean MacLennan
On Thu, 17 Apr 2008 09:08:04 -0700 "Dale Farnsworth" <[EMAIL PROTECTED]> wrote: > I didn't suggest splitting the patches or further modification of the > patches themselves. What I found lacking were the patch descriptions. > You need to describe in each patch (commit) commentary exactly what > t

回复: RE: A question about the 8250/1 6550 Driver

2008-04-17 Thread 旭 罗
Hello Leo: Follow your advises, i look the source code and find that you are right. In the source code, There are 2 functions can do some work for the serial port initralization. The code is followed. 1. static int __devinit serial8250_probe(struct platform_device *dev) 2. static void __init

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 11:14:00AM -0500, Scott Wood wrote: > Anton Vorontsov wrote: >> This isn't a timer with usec precision! This is a timer that silently >> crops precision as it wants to. Ahh, I see you dropped "u" prefix. > > It is a timer with usec precision, unless you ask for a timeout of

Re: [EFIKA] Really, don't pretend to be CHRP

2008-04-17 Thread David Woodhouse
On Thu, 2008-04-17 at 16:17 +0100, Matt Sealey wrote: > David Woodhouse wrote: > > On Thu, 2008-04-17 at 13:28 +0100, Matt Sealey wrote: > >> I thought we were using efika.forth for this in Fedora. > > > > We were, until you pointed out that the kernel actually works just fine > > these days witho

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Scott Wood
On Thu, Apr 17, 2008 at 04:39:04AM +1000, Anton Vorontsov wrote: > +#define GTMDR_FFR(1 << 3) This should be GTMDR_FRR according to the chip docs. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listin

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Scott Wood
Anton Vorontsov wrote: This isn't a timer with usec precision! This is a timer that silently crops precision as it wants to. Ahh, I see you dropped "u" prefix. It is a timer with usec precision, unless you ask for a timeout of more than 65535 usec -- at which point the hardware can't provide u

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 04:23:56PM +0200, Laurent Pinchart wrote: > > + /* > > +* We have two 8 bit prescalers -- primary and secondary (psr, sps), > > +* plus "slow go" mode (clk / 16). So, total prescale value is > > +* 16 * (psr + 1) * (sps + 1). > > +*/ > > + if (prescaler >

Re: Warp patches for 2.6.26

2008-04-17 Thread Dale Farnsworth
On Thu, Apr 17, 2008 at 11:50:45AM -0400, Sean MacLennan wrote: > On Sat, 12 Apr 2008 20:13:16 -0700 > "Dale Farnsworth" <[EMAIL PROTECTED]> wrote: > > > Each patch needs to be standalone. you need to add a header > > describing what the patch is intended to accomplish. Being more > > descriptiv

RE: Xilinx network trouble

2008-04-17 Thread Rick Moleres
Which version of xps_ll_temac are you using, and which version of EDK? Also, do both designs meet timing? -Rick -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Guillaume Dargaud Sent: Thursday, April 17, 2008 4:04 AM To: linuxppc-dev@ozlabs.org Subject:

Re: [PATCH] x86: fix find_next_bit breakage on ppc and powerpc

2008-04-17 Thread Alexander van Heukelum
On Thu, 17 Apr 2008 08:55:12 +1000, "Paul Mackerras" <[EMAIL PROTECTED]> said: > Ingo Molnar writes: > > > > * Alexander van Heukelum <[EMAIL PROTECTED]> wrote: > > > > > Powerpc (and ppc) have their have some code in their bitops.h which > > > used to be exacly the same as asm-generic/bitops/fi

Re: Warp patches for 2.6.26

2008-04-17 Thread Sean MacLennan
On Sat, 12 Apr 2008 20:13:16 -0700 "Dale Farnsworth" <[EMAIL PROTECTED]> wrote: > Each patch needs to be standalone. you need to add a header > describing what the patch is intended to accomplish. Being more > descriptive is better than less. Also, as Stephen said, make sure > that the subject

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Sergei Shtylyov
Matt Sealey wrote: +/* the fifo starts right after psc ends */ +priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1];/* FIXME */ Wouldn't priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(struct mpc52xx_psc)); Be a little less obtuse use of C? "priv->psc" is

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: On Thursday 17 April 2008 17:10, Matt Sealey wrote: Juergen Beisert wrote: Hi, + /* the fifo starts right after psc ends */ + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ Wouldn't priv->fifo = (struct mpc52xx_psc_fifo*) (priv->ps

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
On Thursday 17 April 2008 17:05, Matt Sealey wrote: > > + help > > + Say Y or M if you want to support any AC97 codec attached to > > + the Freescqle MPC52xx AC97 interface. > > Also this; Freescale :) yes. ;-) -- Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de  Pengutronix - Li

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
On Thursday 17 April 2008 17:10, Matt Sealey wrote: > Juergen Beisert wrote: > > Hi, > > + /* the fifo starts right after psc ends */ > > + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ > > Wouldn't > > priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(stru

Re: [EFIKA] Really, don't pretend to be CHRP

2008-04-17 Thread Matt Sealey
David Woodhouse wrote: On Thu, 2008-04-17 at 13:28 +0100, Matt Sealey wrote: I thought we were using efika.forth for this in Fedora. We were, until you pointed out that the kernel actually works just fine these days without it. I said the kernel has had braindead patches shoved into it that

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 04:23:56PM +0200, Laurent Pinchart wrote: [...] > > + /* > > +* We have two 8 bit prescalers -- primary and secondary (psr, sps), > > +* plus "slow go" mode (clk / 16). So, total prescale value is > > +* 16 * (psr + 1) * (sps + 1). > > +*/ > > + if (presc

Re: [EFIKA] Really, don't pretend to be CHRP

2008-04-17 Thread David Woodhouse
On Thu, 2008-04-17 at 13:28 +0100, Matt Sealey wrote: > I thought we were using efika.forth for this in Fedora. We were, until you pointed out that the kernel actually works just fine these days without it. Now, the _only_ thing that goes wrong without it is that 'CHRP' in the machine: line -- wh

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: Hi, + /* the fifo starts right after psc ends */ + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ Wouldn't priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(struct mpc52xx_psc)); Be a little less obtuse use of C? I jus

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 09:19:03AM -0500, Scott Wood wrote: > On Thu, Apr 17, 2008 at 04:52:35PM +0400, Anton Vorontsov wrote: > > Heh. Scott, think about it. You have single 16bit timer with variable > > frequency. To use it, you'd better know what exactly precision you need. > > Why? I know the

Re: [PATCH] rtc-pcf8563: Add device ids table

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 10:02 AM, Laurent Pinchart wrote: Hi, here's a patch against 2.6.25-rc8-mm2 that adds support for device tree names to the rtc-pcf8563 driver. Is the new-style driver conversion patch in 2.6.25-rc8-mm2 scheduled for 2.6.26 ? Should probably include the rtc & i2c mai

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
+ help + Say Y or M if you want to support any AC97 codec attached to + the Freescqle MPC52xx AC97 interface. Also this; Freescale :) -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations ___ Linuxppc-dev mailin

Re: [PATCH] [POWERPC] fsl: Convert dts to v1 syntax

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 10:03 AM, Scott Wood wrote: On Thu, Apr 17, 2008 at 09:47:24AM -0500, Kumar Gala wrote: ranges = < - 0 0 fc00 0400 - 3 0 fa00 0100 + 0x0 0x0 0xfc00 0x400 +

Re: [PATCH] [POWERPC] fsl: Convert dts to v1 syntax

2008-04-17 Thread Scott Wood
On Thu, Apr 17, 2008 at 09:47:24AM -0500, Kumar Gala wrote: > ranges = < > - 0 0 fc00 0400 > - 3 0 fa00 0100 > + 0x0 0x0 0xfc00 0x400 > + 0x3 0x0 0xfa00 0x100 Chip selects

[PATCH] rtc-pcf8563: Add device ids table

2008-04-17 Thread Laurent Pinchart
Hi, here's a patch against 2.6.25-rc8-mm2 that adds support for device tree names to the rtc-pcf8563 driver. Is the new-style driver conversion patch in 2.6.25-rc8-mm2 scheduled for 2.6.26 ? -- This patch adds support for device tree names via the i2c mod alias mechanism to the rtc-pcf8563 driv

Re: [PATCH 2/2] mpc86xx_hpcn: Temporarily accept old dts node identifier.

2008-04-17 Thread Kumar Gala
On Apr 16, 2008, at 12:53 PM, Paul Gortmaker wrote: As suggested by Timur Tabi, we match on the old compat node ID for one version and warn accordingly. If we don't do this, we plunge people who try to use an old DTB into silent boot death with no clear indication of what the problem is.

Re: [PATCH for 2.6.26] Fix the size of qe muram for MPC8568E

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 7:56 AM, Haiying Wang wrote: MPC8568E has 64K byte MURAM, so the size should be 0x1, not 0xc000 in dts. Signed-off-by: Haiying Wang <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8568mds.dts |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) applied. - k

Re: [PATCH 1/2] 86xx: mark functions static, other minor cleanups

2008-04-17 Thread Kumar Gala
On Apr 16, 2008, at 12:53 PM, Paul Gortmaker wrote: Cleanups as suggested by Stephen Rothwell and Dale Farnsworth, which incudes marking a bunch of functions static and add a vendor prefix to the compat node check for uniqueness. Signed-off-by: Paul Gortmaker <[EMAIL PROTECTED]> --- arch/powerp

Re: [PATCH] Make rheap safe for spinlocks

2008-04-17 Thread Kumar Gala
On Apr 14, 2008, at 10:43 AM, Timur Tabi wrote: The rheap allocation function, rh_alloc, could call kmalloc with GFP_KERNEL. This can sleep, which means you couldn't hold a spinlock while called rh_alloc. Change all kmalloc calls to use GFP_ATOMIC so that it won't sleep. This is safe beca

Re: [PATCH] [POWERPC] mpc8315: fix USB UTMI Host setup

2008-04-17 Thread Kumar Gala
On Apr 9, 2008, at 8:59 AM, Anton Vorontsov wrote: Currently USB Host isn't functional on the MPC8315E boards, for two reasons as described below. MPC8315 Reference Manual says: "The USB DR unit must have the same clock ratio as the encryption core unit, unless one of them has its clock disable

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: On Thursday 17 April 2008 16:23, Matt Sealey wrote: Hooray! :) Does it work, though, with your board? - u16 ccr;/* PSC + 0x20 */ - u8 reserved7[14]; + u32 ccr;/* PSC + 0x20 */ + u32

[PATCH] [POWERPC] fsl: Convert dts to v1 syntax

2008-04-17 Thread Kumar Gala
Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- In my powerpc-next tree. posting for review. arch/powerpc/boot/dts/ep88xc.dts | 73 +- arch/powerpc/boot/dts/kuroboxHD.dts | 83 +++-- arch/powerpc/boot/dts/kuroboxHG.dts | 83 +++--

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
On Thursday 17 April 2008 16:23, Matt Sealey wrote: > Hooray! :) > > Does it work, though, with your board? > > > - u16 ccr;/* PSC + 0x20 */ > > - u8 reserved7[14]; > > + u32 ccr;/* PSC + 0x20 */ > > + u32 ac97_slots;

Re: [PATCH v2][POWERPC] qe_lib and ucc_geth: switch to the cpm_muram implementation

2008-04-17 Thread Timur Tabi
Scott Wood wrote: > And then change it again when marketing decides that CPM4 will be called > something other than QE2? :-P I agree with Scott. The QE is really just CPM3. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing li

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Laurent Pinchart
On Wednesday 16 April 2008 20:39, Anton Vorontsov wrote: > On Tue, Mar 18, 2008 at 03:48:12PM -0500, Scott Wood wrote: > [...] > > How about: > > > > struct gtm_timer *gtm_get_specific_timer(struct gtm *gtm, int timer, > > int width); > > > > ...with np->dat

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: Hi, Hooray! :) Does it work, though, with your board? - u16 ccr;/* PSC + 0x20 */ - u8 reserved7[14]; + u32 ccr;/* PSC + 0x20 */ + u32 ac97_slots; /* PSC + 0x24 */ I

RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
Hi, if someone is interested: Here the full patch to get sound support for MPC5200b and a current 2.6.25 kernel. Index: sound/ppc/Kconfig === --- sound/ppc/Kconfig.orig 2008-04-17 15:33:27.0 +0200 +++ sound/ppc/Kconfig

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Scott Wood
On Thu, Apr 17, 2008 at 04:52:35PM +0400, Anton Vorontsov wrote: > Heh. Scott, think about it. You have single 16bit timer with variable > frequency. To use it, you'd better know what exactly precision you need. Why? I know the timeout I need. > Then you limited to u16 for the interval for this

Re: [PATCH v2][POWERPC] qe_lib and ucc_geth: switch to the cpm_muram implementation

2008-04-17 Thread Scott Wood
On Wed, Apr 16, 2008 at 08:38:19PM -0700, Li Yang wrote: > It is a good thing to unify the CPM dpram operation and QE muram > operation. But I'm having concerns about the naming as CPM is an > obsolete block. Can we change to use the new name QE instead? And then change it again when marketing d

Re: [kvm-devel] [PATCH 4 of 4] [KVM POWERPC] PowerPC 440 KVM implementation

2008-04-17 Thread Christian Ehrhardt
Avi Kivity wrote: Avi Kivity wrote: Hollis Blanchard wrote: +config KVM + tristate "Kernel-based Virtual Machine (KVM) support" + depends on EXPERIMENTAL + select PREEMPT_NOTIFIERS + select ANON_INODES + ---help--- + Support hosting virtualized guest machines. You will also + need to select one

[PATCH v6] [POWERPC] 85xx: Add support for relocatble kernel (and booting at non-zero)

2008-04-17 Thread Kumar Gala
Added support to allow an 85xx kernel to be run from a non-zero physical address (useful for cooperative asymmetric multiprocessing situations) and kdump. The support can either be at compile time or runtime (CONFIG_RELOCATABLE). If CONFIG_RELOCATABLE is set, than CONFIG_PHYSICAL_START has no mea

Re: [PATCH v2][POWERPC] qe_lib and ucc_geth: switch to the cpm_muram implementation

2008-04-17 Thread Kumar Gala
On Apr 16, 2008, at 10:38 PM, Li Yang wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Anton Vorontsov Sent: Thursday, April 17, 2008 2:22 AM To: Kumar Gala Cc: Wood Scott; linuxppc-dev@ozlabs.org; Jeff Garzik; Tabi Timur; [EMAIL PROTECTED] Subject

Re: USB on MPC8641D

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 3:36 AM, John Marc wrote: Hi I Have the kernel patches , but no one for the USB. The changes for the USB are integrated in the Kernel. I am currently looking into the linux BSP for usb changes , but unfortunately don't find any major chages. MPC8641 board have one EHCI contr

[PATCH for 2.6.26] Fix the size of qe muram for MPC8568E

2008-04-17 Thread Haiying Wang
MPC8568E has 64K byte MURAM, so the size should be 0x1, not 0xc000 in dts. Signed-off-by: Haiying Wang <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8568mds.dts |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/

Re: [PATCH 6/8] [POWERPC] sysdev,qe_lib: implement FSL GTM support

2008-04-17 Thread Anton Vorontsov
On Wed, Apr 16, 2008 at 04:58:21PM -0500, Scott Wood wrote: > On Thu, Apr 17, 2008 at 01:00:42AM +0400, Anton Vorontsov wrote: > > On Wed, Apr 16, 2008 at 01:44:42PM -0500, Scott Wood wrote: > > > A maximal timeout of ~65 ms is a little low... For use as a wakeup from > > > sleep mode, I'd like to

Re: [PATCH] powerpc: Implement GPIO LIB API on CPM2 Freescale SoC.

2008-04-17 Thread Jochen Friedrich
Hi Laurent, > Any preference for common function names ? cpm2_gpio32* might be too > CPM2-specific for cpm_common.c. cpm_gpio32* is a bit too generic as it > doesn't support port E on the CPM1. I would keep the cpm2 name. I'll just add a comment to cpm1.c that fsl,cpm1-pario-bank32e uses cpm2 l

Re: [PATCH] powerpc: Implement GPIO LIB API on CPM2 Freescale SoC.

2008-04-17 Thread Jochen Friedrich
Hi Laurent, > BTW, what's the purpose of the shadow data register in the CPM GPIO chip > structure ? As the set operation is protected by a spinlock, the only use I > can think of is to prevent changing bits in the PDAT register for pins > configured as inputs. Is that correct ? If so this shou

  1   2   >