Timur Tabi wrote:
> Anton Vorontsov wrote:
>
> > +int qe_usb_clock_set(enum qe_clock clk, int rate)
> > +{
> > + struct qe_mux __iomem *mux = &qe_immr->qmx;
> > + unsigned long flags;
> > + const bool is_brg = clk < QE_CLK1;
>
> You don't really need "is_brg", since it's only used once.
I find "is_brg" much more meaningful than "clk < QE_CLK1".
Maybe the computer doesn't need it, but it's helpful to a
reader of the code.
-Dale
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
