Anton Vorontsov wrote:

> static inline bool qe_clock_is_brg(enum qe_clock clk)
> {
>       return clk < QE_CLK1;
> }

I have no problem with this function (the UART driver could use it), except that
your implementation is wrong.  You would need to do this:

static inline bool qe_clock_is_brg(enum qe_clock clk)
{
        return (clk >= QE_BRG1) && (clk <= QE_BRG16);
}

-- 
Timur Tabi
Linux kernel developer at Freescale
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to