Re: Code review/discussion time again.

2009-11-22 Thread David Kastrup
Han-Wen Nienhuys writes: > On Sun, Nov 22, 2009 at 4:49 AM, David Kastrup wrote: >>> It's no problem at all, if you do it that way. >> >> Hello merge conflict, my old friend, I've come to talk with you again... >> >> If you have ever worked in a project with a central ChangeLog file, you >> know

Re: [PATCH] functional-or returned #f for (functional-or #f #t #f). Fixed.

2009-11-22 Thread David Kastrup
Patrick McCarty writes: > On Tue, Nov 17, 2009 at 11:24 PM, David Kastrup wrote: >> Patrick McCarty writes: >> >>> On 2009-11-16, David Kastrup wrote: It still suffers from not doing short-circuit evaluation.  For readability and efficiency, I'd really prefer replacing '(app

Re: Code review/discussion time again.

2009-11-22 Thread David Kastrup
Han-Wen Nienhuys writes: > On Sat, Nov 21, 2009 at 8:42 PM, David Kastrup wrote: >>> I'll make one last suggestion, which you are free to ignore. >>> >>> I'd suggest a message to -devel and to Han-Wen and Jan, with a simple >>> subject requesting push access, and no extra baggage. > >> I have no

Re: Code review/discussion time again.

2009-11-22 Thread David Kastrup
Han-Wen Nienhuys writes: > On Thu, Nov 19, 2009 at 10:20 PM, David Kastrup wrote: >> >> I have no idea what I am doing here. In particular not with the >> \override, and the set-object-property!. Can somebody explain to me >> just what data structures I happen to manipulate, and how a user is

Re: Issue #768 - chord repetition shortcut: patch for review

2009-11-22 Thread Han-Wen Nienhuys
On Fri, Nov 13, 2009 at 10:25 AM, David Kastrup wrote: > Kieren MacMillan writes: > >> Hi, >> >>> Could it be an option to make 4*8 do the obvious thing? >>> Or even { 4 }*8 ? >>> That would be so much more natural.  The first already does something, >>> but not something which I would call usefu

Re: Ok, need a few hints.

2009-11-22 Thread Han-Wen Nienhuys
On Fri, Nov 20, 2009 at 3:44 PM, David Kastrup wrote: > Hi, I am currently turning to the problem of typesetting chords for > accordion.  Basically I want to detect the chord/bass input like > ChordNames does, and then do my own translation into bass notes and > chords.  Chord and bass note names

Re: Code review/discussion time again.

2009-11-22 Thread Han-Wen Nienhuys
On Sat, Nov 21, 2009 at 8:42 PM, David Kastrup wrote: >> I'll make one last suggestion, which you are free to ignore. >> >> I'd suggest a message to -devel and to Han-Wen and Jan, with a simple >> subject requesting push access, and no extra baggage. > I have no idea whether they'll grant it, but

Re: Code review/discussion time again.

2009-11-22 Thread Han-Wen Nienhuys
On Sat, Nov 21, 2009 at 10:17 PM, David Kastrup wrote: >>> Modifying Lilypond, then recompiling and reinstalling.  That's not the >>> most hack-friendly way.  I am still finding my way around. >> >> You're only modifying .scm files, so there shouldn't be any >> recompiling/reinstalling involved. >

Re: Code review/discussion time again.

2009-11-22 Thread Han-Wen Nienhuys
On Sun, Nov 22, 2009 at 4:49 AM, David Kastrup wrote: >> It's no problem at all, if you do it that way. > > Hello merge conflict, my old friend, I've come to talk with you again... > > If you have ever worked in a project with a central ChangeLog file, you > know the permanent hassle with switchin

Re: Code review/discussion time again.

2009-11-22 Thread Han-Wen Nienhuys
Hi, On Thu, Nov 19, 2009 at 10:20 PM, David Kastrup wrote: > > I have no idea what I am doing here. In particular not with the > \override, and the set-object-property!. Can somebody explain to me > just what data structures I happen to manipulate, and how a user is > actually _supposed_ to be

Re: Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread Carl Sorensen
On 11/22/09 10:50 AM, "Nicolas Sceaux" wrote: > Le 22 nov. 2009 à 17:10, Graham Percival a écrit : > >> On Sun, Nov 22, 2009 at 3:37 PM, wrote: >>> As I'm not (obviously) a native English speaker, comments on style are >>> most welcome. >> >> Whenever I try to publish my comments, I get a

Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups

2009-11-22 Thread Han-Wen Nienhuys
LGTM On Sun, Nov 22, 2009 at 10:03 PM, David Kastrup wrote: > --- >  scm/define-markup-commands.scm |    3 +-- >  1 files changed, 1 insertions(+), 2 deletions(-) > > This patch series makes the syntax of builtin markup > commands upwards compatible with the user level ones. > > diff --git a/scm/

Re: keeping files (previously) in input/

2009-11-22 Thread Valentin Villenave
On Sun, Nov 22, 2009 at 3:04 PM, Graham Percival wrote: > Valentin: could you check if LSR has an example like this, and if > not, add wilhelmus to LSR? Done: http://lsr.dsi.unimi.it/LSR/Item?id=648 Cheers, Valentin ___ lilypond-devel mailing list li

Re: [PATCH] functional-or returned #f for (functional-or #f #t #f). Fixed.

2009-11-22 Thread Patrick McCarty
On Tue, Nov 17, 2009 at 11:24 PM, David Kastrup wrote: > Patrick McCarty writes: > >> On 2009-11-16, David Kastrup wrote: >>> >>> It still suffers from not doing short-circuit evaluation.  For >>> readability and efficiency, I'd really prefer replacing >>> '(apply functional-or' with '(any' >> >>

Re: help wanted page

2009-11-22 Thread Valentin Villenave
On Sun, Nov 22, 2009 at 7:05 PM, David Pounder wrote: > Very small point, but the phrase "Frogs are simple LilyPond users" would be > better expressed as "Frogs are simply LilyPond users" as the former has an > undesired implication, at least in UK English. Hehe. It never occurred to me, but no

[PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords

2009-11-22 Thread David Kastrup
The specification of category and properties makes the *-builtin-* variants diverge syntactically from the user specified markup. Moving those specifications into keyword arguments makes the builtin defining macros upwards compatible with the user specified ones. --- scm/define-markup-commands.sc

[PATCH 4/4] Use new definitions of define-builtin-markup{, -list}-command

2009-11-22 Thread David Kastrup
All markup commands defined with these macros must be adapted to the new syntax. --- scm/define-markup-commands.scm | 449 scm/fret-diagrams.scm | 18 +- scm/harp-pedals.scm|8 +- scm/tablature.scm |3 +- 4 files

[PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups

2009-11-22 Thread David Kastrup
--- scm/define-markup-commands.scm |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) This patch series makes the syntax of builtin markup commands upwards compatible with the user level ones. diff --git a/scm/define-markup-commands.scm b/scm/define-markup-commands.scm index 449f3c7..0

[PATCH 2/4] scm/harp-pedals.scm: Fold make-harp-pedal into \harp-pedal markup.

2009-11-22 Thread David Kastrup
The already outcommented problematic \harp-pedal-verbose markup is removed completely. Inlining make-harp-pedal makes it possible to use the property binding mechanism of define-builtin-markup-command in order to minimize inconsistencies between documentation and behavior. --- scm/harp-pedals.scm

Re: 2.13.8 now?

2009-11-22 Thread Patrick McCarty
On Sun, Nov 22, 2009 at 11:02 AM, Graham Percival wrote: > I'm vaguely aware of some discussion about a memory leak.  Would > anybody mind if we release 2.13.8 now? > > A few tests are in the usual place: >  http://lilypond.org/~graham/ The darwin-x86 build checks out fine on Leopard (can't test

Re: 2.13.8 now?

2009-11-22 Thread Neil Puttock
2009/11/22 Graham Percival : > I'm vaguely aware of some discussion about a memory leak.  Would > anybody mind if we release 2.13.8 now? > > A few tests are in the usual place: >  http://lilypond.org/~graham/ The mingw binary works fine under Wine. > > The regtests look good, other than chords-fu

Re: development on windows

2009-11-22 Thread Trevor Daniels
Anthony W. Youngman wrote Sunday, November 22, 2009 8:06 PM In message , Frédéric Bron writes create a mount point: $ mkdir /mnt/Share then add the following line to /etc/fstab: Share /mnt/Share vboxsf defaults 0 0 Hmm. Is there any way to have this pre-configured? i.e. tell uses to creat

Re: LilyPond web service

2009-11-22 Thread Bertalan Fodor (LilyPondTool)
Just a heads up for those who are thinking about hosting part of the distributed LilyPond server vision. I created a Java servlet based service for LilyPond for the purposes of Google Wave. It runs on a virtual private server with 256MB RAM (running Ubuntu Linux, Tomcat, a database and nothing m

Re: development on windows

2009-11-22 Thread Anthony W. Youngman
In message , Frédéric Bron writes create a mount point: $ mkdir /mnt/Share then add the following line to /etc/fstab: Share           /mnt/Share      vboxsf  defaults 0 0 Hmm.  Is there any way to have this pre-configured?  i.e. tell uses to create  C:\lilybuntu-share\ in windows (or create i

Re: help wanted page

2009-11-22 Thread Graham Percival
On Sun, Nov 22, 2009 at 03:19:00PM +, Ian Hulin wrote: > Graham Percival wrote: >> I've made a first draft of the "help us" page: >> http://kainhofer.com/~lilypond/Documentation/web/help-us.html > > "To get the source code, see Starting with git." > I've got problems with this here and in the C

Re: development on windows

2009-11-22 Thread Frédéric Bron
>> create a mount point: >> $ mkdir /mnt/Share >> then add the following line to /etc/fstab: >> Share           /mnt/Share      vboxsf  defaults 0 0 > > Hmm.  Is there any way to have this pre-configured?  i.e. tell > uses to create >  C:\lilybuntu-share\ > in windows (or create it for them), and h

2.13.8 now?

2009-11-22 Thread Graham Percival
I'm vaguely aware of some discussion about a memory leak. Would anybody mind if we release 2.13.8 now? A few tests are in the usual place: http://lilypond.org/~graham/ The regtests look good, other than chords-funky-ignatzek showing something complicated instead of C^10, but I assume that's de

Re: help wanted page

2009-11-22 Thread David Pounder
> --- Original Message --- > From: David Kastrup > To: lilypond-devel@gnu.org > Sent: 22.11.09, 18:27:02 > Subject: Re: help wanted page > > Graham Percival writes: > > > On Sun, Nov 22, 2009 at 06:05:45PM -, David Pounder wrote: > >> > >> Very small point, but the phrase "Frogs

Re: help wanted page

2009-11-22 Thread David Kastrup
Graham Percival writes: > On Sun, Nov 22, 2009 at 06:05:45PM -, David Pounder wrote: >> >> Very small point, but the phrase "Frogs are simple LilyPond >> users" would be better expressed as "Frogs are simply LilyPond >> users" as the former has an undesired implication, at least in >> UK Eng

Re: development on windows

2009-11-22 Thread Graham Percival
On Sun, Nov 22, 2009 at 06:44:38PM +0100, Frédéric Bron wrote: > > The only two problems I've yet to resolve are how to share files > > with my Windows host > > Create a directory in windows for that, let's say d:\Share > Then you go in VirtualBox, click on the virtual machine name and in > the me

Re: help wanted page

2009-11-22 Thread Graham Percival
On Sun, Nov 22, 2009 at 06:05:45PM -, David Pounder wrote: > > Very small point, but the phrase "Frogs are simple LilyPond > users" would be better expressed as "Frogs are simply LilyPond > users" as the former has an undesired implication, at least in > UK English. LOL! I took that paragrap

Re: help wanted page

2009-11-22 Thread David Pounder
> --- Original Message --- > From: Graham Percival > To: lilypond-devel@gnu.org > Sent: 22.11.09, 14:07:12 > Subject: help wanted page > > I've made a first draft of the "help us" page: > http://kainhofer.com/~lilypond/Documentation/web/help-us.html > > I'm not very happy with the resu

Re: development on windows

2009-11-22 Thread Francisco Vila
2009/11/22 Trevor Daniels : > The only two problems I've yet to resolve are how to share files > with my Windows host I usually open the Places menu and choose 'connect to a host', this opens a file browser on the host if you know its IP and select a proper protocol. Sorry for not giving more det

Re: Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread Nicolas Sceaux
Le 22 nov. 2009 à 17:10, Graham Percival a écrit : > On Sun, Nov 22, 2009 at 3:37 PM, wrote: >> As I'm not (obviously) a native English speaker, comments on style are >> most welcome. > > Whenever I try to publish my comments, I get a 500 server error. :( > I'll summarize them below: > - use @

Re: development on windows

2009-11-22 Thread Frédéric Bron
> The only two problems I've yet to resolve are how to share files > with my Windows host Create a directory in windows for that, let's say d:\Share Then you go in VirtualBox, click on the virtual machine name and in the menu "Machine/Preferences". Here you find shared directories where you can ad

Re: Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread Ian Hulin
Nicolas, I'm now having similar problems on Rietveld as Graham. First five lines of your docstring in scm/markup.scm in the property-bind macro should say: "Search properties in `props', and bind each property symbol to a corresponding value, or to a default if a value is not found. props: a

Re: Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread nicolas . sceaux
Thank you Ian for the careful review. Nicolas http://codereview.appspot.com/157133/diff/1/2 File Documentation/extending/programming-interface.itely (right): http://codereview.appspot.com/157133/diff/1/2#newcode1045 Documentation/extending/programming-interface.itely:1045: The @code{layout} a

Re: development on windows

2009-11-22 Thread Trevor Daniels
Jonathan Kulp wrote Friday, June 12, 2009 8:59 PM The .iso is finished uploading and is ready for testing by whoever wants to try it. Download here: http://prodet.hu/bert/lilydev/lilybuntu.iso It's 716 MB, so it won't fit on a CD. If you're using a virtual machine you don't have to worry ab

Re: Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread ian
Nicolas, These are mainly stylistic changes. Please double-check to ensure I haven't changed the meaning of what you intended. Cheers, Ian http://codereview.appspot.com/157133/diff/1/2 File Documentation/extending/programming-interface.itely (right): http://codereview.appspot.com/157133/diff/

Re: Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread Graham Percival
On Sun, Nov 22, 2009 at 3:37 PM, wrote: > As I'm not (obviously) a native English speaker, comments on style are > most welcome. Whenever I try to publish my comments, I get a 500 server error. :( I'll summarize them below: - use @var{foo} for variable names. This applies to both the .itely fi

Doc: improve doc on markup command writing (issue157133)

2009-11-22 Thread nicolas . sceaux
Reviewers: , Message: Hi, This patch improves (as I hope) the documentation on markup command definition, by using more complete examples. It also tries to address an issue that was raised on -devel, concerning the different syntax between built-in and user-defined markup command definition. A

Re: help wanted page

2009-11-22 Thread Ian Hulin
Graham Percival wrote: I've made a first draft of the "help us" page: http://kainhofer.com/~lilypond/Documentation/web/help-us.html I'm not very happy with the result, but I can't put my finger on precisely why. Maybe it's that I've forgotten some ways that people can help, without source code,

Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary lookups

2009-11-22 Thread Carl Sorensen
On 11/22/09 2:47 AM, "Nicolas Sceaux" wrote: > >> It is not a "little inconvenience" if internals are defined in a >> different, undocumented way that apparently only a single developer >> understands and realizes. > > This comment would have been valid a few hours before, but it's not > any

Re: Code review/discussion time again.

2009-11-22 Thread Carl Sorensen
On 11/21/09 7:41 PM, "Carl Sorensen" wrote: > > > > > On 11/21/09 4:48 PM, "David Kastrup" wrote: > >> Graham Percival writes: >> >>> You're welcome to write up documentation about the current >>> architecture; you're probably one of the top 10 people in the >>> world when it comes to

Re: Code review/discussion time again.

2009-11-22 Thread Carl Sorensen
On 11/21/09 11:49 PM, "David Kastrup" wrote: > Carl Sorensen writes: > >> And if you have the source tree in a git repository, then it's trivial to >> make branches, and checkout the appropriate branch. That way you don't have >> to worry about overwrites (and if you do have overwrite probl

Re: help wanted page

2009-11-22 Thread Graham Percival
On Sun, Nov 22, 2009 at 03:27:52PM +0100, David Kastrup wrote: > "Mailist support: we have many users asking for him" is utterly > incomprehensible. Probably you mean something like Oops, s/him/help/ Cheers, - Graham ___ lilypond-devel mailing list l

Re: help wanted page

2009-11-22 Thread Ian Hulin
Graham Percival wrote: I've made a first draft of the "help us" page: http://kainhofer.com/~lilypond/Documentation/web/help-us.html I'm not very happy with the result, but I can't put my finger on precisely why. Maybe it's that I've forgotten some ways that people can help, without source code,

Re: help wanted page

2009-11-22 Thread David Kastrup
Graham Percival writes: > I've made a first draft of the "help us" page: > http://kainhofer.com/~lilypond/Documentation/web/help-us.html > > I'm not very happy with the result, but I can't put my finger on > precisely why. Maybe it's that I've forgotten some ways that > people can help, without

help wanted page

2009-11-22 Thread Graham Percival
I've made a first draft of the "help us" page: http://kainhofer.com/~lilypond/Documentation/web/help-us.html I'm not very happy with the result, but I can't put my finger on precisely why. Maybe it's that I've forgotten some ways that people can help, without source code, or without compiling stu

Re: keeping files (previously) in input/

2009-11-22 Thread Graham Percival
On Sun, Nov 22, 2009 at 12:41:08PM +0100, Jan Nieuwenhuizen wrote: > What if someone wants to set a hymn (wilhelmus) We have SATB templates, we have a gregorian template, etc. The only odd thing about wilhelmus is the huge horizontal space to the left and right of the notes. Valentin: could you

Re: keeping files (previously) in input/

2009-11-22 Thread Jan Nieuwenhuizen
Op zaterdag 21-11-2009 om 17:46 uur [tijdzone +], schreef Graham Percival: > Remember, this discussion is about whether or not these files > should be restored as part of the developer-only regtests. We've > already decided that they're not worth being added to the Examples > or Snippets. Is

Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary lookups

2009-11-22 Thread David Kastrup
Nicolas Sceaux writes: > Le 22 nov. 2009 à 00:00, David Kastrup a écrit : >> >>> I'd be insterested to see an implementation of a single >>> `define-markup-command' for builtin and user defined markups, where >>> user defined commands do not pollute the (lily) module, and still are >>> available

Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary lookups

2009-11-22 Thread Nicolas Sceaux
Le 22 nov. 2009 à 00:00, David Kastrup a écrit : > >> I'd be insterested to see an implementation of a single >> `define-markup-command' for builtin and user defined markups, where >> user defined commands do not pollute the (lily) module, and still are >> available across file includes. > > Ther