Re: [LEDE-DEV] [PATCH odhcpd] dhcpv6-ia: add option for dhcpv6 privacy address

2017-03-10 Thread Eric Luehrsen
On 03/10/2017 09:09 AM, Bjørn Mork wrote: > Eric Luehrsen writes: >> It appears many other severs and clients dont implement IA_TA. Its a lost >> option. > Sure. Very few want this feature. We must however assume that those > who do want it will implement it. We must howev

Re: [LEDE-DEV] [PATCH odhcpd] dhcpv6-ia: add option for dhcpv6 privacy address

2017-03-12 Thread Eric Luehrsen
This discussion has really put some requirements and restrictions on what I am trying to implement. I like that. Excuse my stream of consciousness writing style, if you question "what? .. crazy?" then its likely my fault for not editing well. On 03/11/2017 11:39 AM, Paul Oranje wrote: >> RFC 33

Re: [LEDE-DEV] [PATCH odhcpd] dhcpv6-ia: add option for dhcpv6 privacy address

2017-03-12 Thread Eric Luehrsen
Patchwork: Reject Patch. It needs improvement. The time base for the address needs more stable regulation just for one. - Eric ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] Release 17.01.0 binary packages have changed and SDK inconsistency

2017-03-28 Thread Eric Luehrsen
On 03/28/2017 06:19 PM, Gui Iribarren via Lede-dev wrote: >> Packages from the feeds and even base-packages (think: openssl) can >> change after a release, just like for other distributions. > i agree packages can and should be maintained, but in progressivereleases. >i.e. if i install ubuntu 12.04

Re: [LEDE-DEV] [PATCH 2/3][RFC] base-files: add option to rc.common to disable default reload behavior

2017-03-29 Thread Eric Luehrsen
On 03/29/2017 03:17 AM, Alexandru Ardelean wrote: > On Tue, Mar 28, 2017 at 11:36 PM, Hans Dedecker wrote: >> On Mon, Mar 20, 2017 at 3:08 PM, Alexandru Ardelean >> wrote: >>> From: Alexandru Ardelean >>> >>> Traditionally if a reload script fails, it will fallback to restart. >>> >>> That seems

Re: [LEDE-DEV] dnsmasq sometimes fails to start on 17.01.0

2017-03-29 Thread Eric Luehrsen
On 03/29/2017 11:57 AM, Yousong Zhou wrote: > On 24 March 2017 at 03:17, Gui Iribarren via Lede-dev >> I continued yeterday further debugging this, i played with this >> particular number in /e/i/dnsmasq >> (line 815 in http://pastebin.com/FV09f2jG) >> >> procd_add_raw_trigger "interface.*" 200

Re: [LEDE-DEV] Planning v17.01.1

2017-04-09 Thread Eric Luehrsen
On 04/09/2017 10:14 AM, Jo-Philipp Wich wrote: > Hi, > I'd like to start preparing the v17.01.1 release during the upcoming > week with the goal to release final binaries during the easter holidays > (~14.04. - 17.04.). > You can find the current list of changes since v17.01.0 at > https://lede-pro

Re: [LEDE-DEV] [PATCH odpcpd] dhcpv6: allow creating new bindings on REBIND

2017-04-10 Thread Eric Luehrsen
On 04/10/2017 05:08 AM, Lubomir Rintel wrote: > There might be unassigned IAs among the options the client sends when it > issues a REBIND. In fact, that's how the ISC dhclient reqests new IA_PDs > to be assigned. However, odhcpd would just return the IA_PDs back > without assigning a prefix: The

[LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

2017-04-17 Thread Eric Luehrsen
On Thu, Mar 9, 2017 at 10:20 PM, Matthias Schiffer wrote: > On 03/09/2017 05:32 PM, Hans Dedecker wrote: >> Trigger interface update event when IPv6 address lifetime changes by setting >> the address indicator flag to inform external subsystems about IPv6 address >> lifetime change. >> >>

[LEDE-DEV] [PATCH netifd] Revert: set prefix indicator flag when IPv6 prefix lifetime, changes

2017-04-23 Thread Eric Luehrsen
This reverts commit a03216660797173fbe67866f75564e3fec9c1e8d. The previous change causes IFUP events to occur from 30 seconds to 30 minutes depending on various conditions at the WAN6 (typ.) interface. If a DHCPv6 lease is 24 hours and the connection is stable, then in other linux distro we would e

Re: [LEDE-DEV] [PATCH netifd] Revert: set prefix indicator flag when IPv6 prefix lifetime, changes

2017-04-23 Thread Eric Luehrsen
On 04/23/2017 10:23 PM, Eric Luehrsen wrote: > This reverts commit a03216660797173fbe67866f75564e3fec9c1e8d. The previous > change causes IFUP events to occur from 30 seconds to 30 minutes depending > on various conditions at the WAN6 (typ.) interface. If a DHCPv6 lease is > 24 h

Re: [LEDE-DEV] [PATCH netifd] Revert: set prefix indicator flag when IPv6 prefix lifetime, changes

2017-04-24 Thread Eric Luehrsen
Hi Hans I guess I should have double checked FS#713. I thought it was set to notify, and just wasn't touched. Sorry about that. wrt: > As explained in FS#713 reverting this patch will lead to complaints > from people homenet is broken > (https://github.com/openwrt/openwrt/issues/346[1]); a mo

Re: [LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-05-02 Thread Eric Luehrsen
On 05/02/2017 05:36 PM, Paul Oranje wrote: > Assignment within a condition is easily read by (dyslectic) humans as a test > for equality (==) and is for that reason als better avoided. > Paul > >> Op 2 mei 2017, om 18:43 heeft Philip Prindeville >> het volgende geschreven: >> >> >>> On May 2,

Re: [LEDE-DEV] dnsmasq-full should deselect dnsmasq

2017-05-02 Thread Eric Luehrsen
On 05/02/2017 02:22 PM, Andrew McConachie wrote: > > > On 5/2/17 10:13, Jo-Philipp Wich wrote: >> Hi Andrew, >> >>> When selecting package dnsmasq-full from make menuconfig I believe it >>> should deselect package dnsmasq. >> this is not easily solvable within the current Kconfig framework and >>

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-08 Thread Eric Luehrsen
Glad to hear the merge is coming and that enough issues were resolved to make this go forward. So ... I'll just throw my thoughts into the hopper. > On 05/08/2017 09:19 AM, John Crispin wrote: > > *) branding > From a raw objective stand, OpenWrt has better market value as a brand. Its longer

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-11 Thread Eric Luehrsen
I read this on going thread and ... (sigh). "Good fences make good neighbors." Robert Frost People don't like rules and that could be even more true with open source work groups. However, a good set of _limited_ rules can make life easier. You may focus on important work or joyful recreation wh

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-11 Thread Eric Luehrsen
documented. > > 12. Be nice to each other. > > what is it on this list that people are objecting to? > > what is it that people say needs to be added to the list? > > are the people objecting amoung those who would have to comply with > these rules? or are they outsiders

Re: [LEDE-DEV] convention on uid/gid for packages

2017-05-13 Thread Eric Luehrsen
On 05/13/2017 06:23 PM, Val Kulkov wrote: > Is there any convention on the use of uid and gid when creating new > users or groups? Can someone point me to it, if it exists? > > I noticed that two packages, icecast and postfix, compete for the same uid=87: > > icecast's Makefile: > USERID:=iceca

Re: [LEDE-DEV] convention on uid/gid for packages

2017-05-15 Thread Eric Luehrsen
On 15.05.2017 18:02, Val Kulkov wrote: > On 15 May 2017 at 11:46, Yousong Zhou wrote: >> On 15 May 2017 at 23:29, Val Kulkov wrote: >>> Yousong, perhaps I was not clear. What I am suggesting is to change >>> the auto-allocation to start from 1000 rather than from 100 (1000 is >>> just a sugg

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-15 Thread Eric Luehrsen
On 05/15/2017 09:11 PM, Philip Prindeville wrote: >> On May 11, 2017, at 10:09 PM, Eric Luehrsen wrote: >> >> People don't like rules and that could be even more true with open >> source work groups. However, a good set of _limited_ rules can make life >> easi

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-15 Thread Eric Luehrsen
On 05/15/2017 10:16 PM, Philip Prindeville wrote: >> On May 12, 2017, at 6:02 AM, Edwin van Drunen wrote: >> >> I understand that the vote is done amongst the developers, the people >> actually running the project, this makes sense. >> But if the goal of the project is not only to keep yourself b

Re: [LEDE-DEV] [OpenWrt-Devel] Remerge logo ideas

2017-05-29 Thread Eric Luehrsen
On 05/29/2017 07:45 AM, Imre Kaloz wrote: > On 2017-05-29 13:10, Jamie Stuart wrote: >> See another iteration, with: >> >> - correct capitalisation >> - antenna to the side (will not work with lowercase ’n’) >> - open sans typeface (open source) >> - mockups of website header >> - accent colours >>

Re: [LEDE-DEV] openwrt and lede - remerge proposal V3

2017-05-29 Thread Eric Luehrsen
On 05/29/2017 03:03 AM, John Crispin wrote: > (resend, this time as plain text) > > Hi, > > here is a V3 of the remerge proposal, I tried to fold all the comments > people made into it, if anything is missing let me know. Please remeber > that post remerge anything can be voted on, so clutterin

Re: [LEDE-DEV] solar wifi AP designs

2017-06-04 Thread Eric Luehrsen
On 06/04/2017 08:46 PM, Dave Taht wrote: > I keep finding nicely integrated solar/battery/camera designs like these > > https://www.amazon.com/s/ref=nb_sb_noss_2?url=search-alias%3Delectronics&field-keywords=solar+wifi&rh=n%3A172282%2Ck%3Asolar+wifi > > But what I'd like is just something with sola

Re: [LEDE-DEV] [PATCH] dnsmasq: write resolv.conf also when noresolv = 1

2017-06-04 Thread Eric Luehrsen
Hi Paul - The solution I put into Unbound scripts was due to this trickiness. dnsmasq and its little extra functions have become entrenched and necessary in base OpenWrt/LEDE. This includes the oddities in architecture for UCI and LuCI. Normally, it is much easier to bind to the wild card addr

Re: [LEDE-DEV] ddns problem

2017-06-05 Thread Eric Luehrsen
On 06/05/2017 11:39 AM, Toke Høiland-Jørgensen wrote: > "Giuseppe Lippolis" writes: >> Dear All, >> I have a problem with the pkg ddns-scripts_2.7.6-14_all. >> I'm using the option service_name 'dyndns.org'. >> >> After running the script I get in logread: >> >> Mon Jun 5 15:27:27 2017 user.err

Re: [LEDE-DEV] [PATCH] dnsmasq: write resolv.conf also when noresolv = 1

2017-06-05 Thread Eric Luehrsen
On 06/05/2017 06:48 AM, Paul Oranje wrote >The current guard (resolvsym) is now determined with: > if [ ! -x /usr/sbin/dnsmasq -o ! -x /etc/init.d/dnsmasq ] ; then > resolvsym=1 > else > /etc/init.d/dnsmasq enabled || resolvsym=1 > fi > > This assumes that dnsmas

Re: [LEDE-DEV] dns setup problem

2017-06-21 Thread Eric Luehrsen
On 06/21/2017 03:42 PM, e9hack wrote: > Hi, > > the dns setup for dnsmasq does have a bug. If option resolvfile is used and > its value isn't '/tmp/resolv.conf.auto', > name resolution doesn't work. The given file is empty. A file > '/tmp/resolv.conf.auto' is generated and contains the > correct

Re: [LEDE-DEV] LEDE call for vote on remerge proposal V3

2017-06-27 Thread Eric Luehrsen
On 06/27/2017 04:55 PM, Hauke Mehrtens wrote: > On 06/26/2017 11:59 PM, Hauke Mehrtens wrote: >> On 06/10/2017 03:13 PM, Hauke Mehrtens wrote: >>> Hi, >>> >>> As many already acknowledged this proposal I would like to call for an >>> official vote among the LEDE committers till 14.6.2017 on this pr

Re: [LEDE-DEV] Stock config files as templates

2017-08-01 Thread Eric Luehrsen
I would recommend two options and break this into two steps or concepts. (1) A new option removes default servers. This option is independent of option 2. For implementation, an inline awk script might have more robust syntax then sed. (2) Current list server option adds servers to the list. E

Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp lan

2017-09-01 Thread Eric Luehrsen
On Thu, Aug 31, 2017 at 11:35 PM, Karl Palsson wrote: > > > > Daniel Golle wrote: > >> Hi Karl, > >> > >> On Thu, Aug 31, 2017 at 05:17:38PM +, Karl Palsson wrote: > >> > Instead of blindly enabling the odhcpd v6 server and RA server on the > >> > lan port, only do that if the lan port isn't

Re: [LEDE-DEV] [RFC] A new developper documentation for OpenWrt/LEDE

2017-10-25 Thread Eric Luehrsen
On 10/25/2017 12:19 PM, John Norton wrote: On 25/10/2017 17:22, Baptiste Jonglez wrote: Hi, As an occasional contributor to OpenWrt/LEDE, I am often frustrated by the lack of good technical documentation.  By "technical documentation", I mean a detailed, reasonably complete and up-to-date d

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-12 Thread Eric Luehrsen
On 11/12/2017 09:49 PM, ros...@gmail.com wrote: On Wed, 2017-11-08 at 21:17 +0100, Arjen de Korte wrote: Citeren Rosen Penev : Less verbose. And uses a GCC extension which makes it less portable. ISO C forbids empty initializer braces [1]. See for yourself by adding the -pedantic flag to your

Re: [LEDE-DEV] [PATCH] procd: Remove unnecessary memset calls.

2017-11-12 Thread Eric Luehrsen
On 11/12/2017 10:53 PM, ros...@gmail.com wrote: Tested compile size difference. Saves 32 bytes. ¯\_(ツ)_/¯ On Tue, 2017-11-07 at 12:05 -0800, Rosen Penev wrote: Changes allocation to calloc and {} as needed. Signed-off-by: Rosen Penev --- inittab.c | 6 ++ plug/hotplug.c | 7 ++

[LEDE-DEV] odhcpd: possible regression in make DHCPv4 support compiletime configurable

2017-11-22 Thread Eric Luehrsen
FS#1188 has been raised due to problems for optional build recipes in "dhcpv4: make DHCPv4 support compiletime configurable" (d80621fea5cafcdca3f7fe762fede374a66e4b2) because no odhcpd-full package is build bot available. However, it also appears that conditionally compiling DHCPv4 back in does

Re: [LEDE-DEV] Using older kernel in 17.01.4

2017-11-24 Thread Eric Luehrsen
Hi Nishant - As a possible alternate solution... If you don't need the curvature feature of HFSC, then HTB will work just as well. It handles the hierarchy and bandwidth sharing. Some may express concern HTB is slower at high bandwidths. This isn't entirely true. The HTB parameters "burst" an

Re: [LEDE-DEV] odhcpd: possible regression in make DHCPv4 support compiletime configurable

2017-11-24 Thread Eric Luehrsen
On 11/23/2017 03:54 AM, Hans Dedecker wrote: Hi, On Thu, Nov 23, 2017 at 6:38 AM, Eric Luehrsen wrote: FS#1188 has been raised due to problems for optional build recipes in "dhcpv4: make DHCPv4 support compiletime configurable" (d80621fea5cafcdca3f7fe762fede374a66e4b2) because no o

Re: [LEDE-DEV] DNS split horizon *without* dnsmasq

2018-03-31 Thread Eric Luehrsen
On 03/25/2018 03:27 AM, Philip Prindeville wrote: Thinking Bind, probably. On Mar 23, 2018, at 5:38 PM, Eric Luehrsen wrote: What do you want to serve your dns then? Unbound or Bind? - Eric On Fri, Mar 23, 2018, 1:31 PM Philip Prindeville wrote: Hi all, As the ISC-DHCP maintainer, I

Re: [LEDE-DEV] DNS split horizon *without* dnsmasq

2018-03-31 Thread Eric Luehrsen
It seems I have static-stub wrong for its purpose. dhcpd and bind do work together. To accomplish this, the bind instance needs to be master for the domain zone and ptr zone where DHCP records will be entered. This master zone needs to permit remote updates, preferably with a secure key. dhcpd

Re: [LEDE-DEV] DNS split horizon *without* dnsmasq

2018-04-01 Thread Eric Luehrsen
On 03/31/2018 06:03 PM, Philip Prindeville wrote: On Mar 31, 2018, at 12:57 PM, Eric Luehrsen wrote: It seems I have static-stub wrong for its purpose. dhcpd and bind do work together. To accomplish this, the bind instance needs to be master for the domain zone and ptr zone where DHCP

Re: [LEDE-DEV] s/dnsmasq/unbound+odhcpd/

2017-01-20 Thread Eric Luehrsen
>>>Sound interesting. Can it do multiple instances? (1) The UCI scripts are not configured for instances, but ... (2) It wouldn't be a good idea. Recursive servers keep a lot of infrastructure cache with the zone data. This grows with DNSSEC. Lame paths (broken DSKEY chains) and slow respondin

[LEDE-DEV] netifd: "bridge: disable IGMP snooping by default"

2017-01-20 Thread Eric Luehrsen
Dave, May I quote you for pull requests to achieve "dnsmasq: make DHCPv6 work in standalone dnsmasq installation": https://github.com/lede-project/source/pull/704 https://github.com/lede-project/source/pull/674 >>> "It's just odhcpd that sucks rocks through a straw." Eric _

Re: [LEDE-DEV] s/dnsmasq/unbound+odhcpd/

2017-01-21 Thread Eric Luehrsen
Its more of having time to gather common wants and establish sane limits on the scope. Stuff like this can get out of control in feature creep. Good structure is necessary for future maintenance and LuCI. Also its a new feature in 1.6.0 and I want to test it manually first and have yay/nay repor

[LEDE-DEV] initialisation/startup of dnsmasq for multiple instances is broken

2017-02-02 Thread Eric Luehrsen
That should all be happening "within" the instance and all options written to the current instance conf file. Each 'config dhcp name' section is unique to itself yet another layer within this. Precisely, what are you expecting and what isnt happening? Could you cut n paste snippets from uci and

[LEDE-DEV] initialisation/startup of dnsmasq for multiple instances is broken

2017-02-02 Thread Eric Luehrsen
That should all be happening "within" the instance and all options written to the current instance conf file. Each 'config dhcp name' section is unique to itself yet another layer within this. Precisely, what are you expecting and what isnt happening? Could you cut n paste snippets from uci and

Re: [LEDE-DEV] Is there a location for utility scripts?

2017-02-02 Thread Eric Luehrsen
I would strongly recommend two things: (1) a core "packages/.../helpdesk" kit always built into LEDE for this purpose. Maybe some LuCI to run its best parts. (2) Substantial planning and forethought before lobbing a bunch of script code into another package. - Eric __

[LEDE-DEV] dnsmasq make DHCPv6 viable for standalone dnsmasq install

2017-02-03 Thread Eric Luehrsen
message From: Daniel Petre Date: 2/3/17 05:26 (GMT-05:00) To: Eric Luehrsen , Jo-Philipp Wich Subject: Re: dnsmasq: make DHCPv6 viable for standalone dnsmasq install On 02/02/2017 07:52 PM, Eric Luehrsen wrote: > What I submitted I had tested on TL WDR3600 and TL Archer C7 ... work

Re: [LEDE-DEV] dnsmasq make DHCPv6 viable for standalone dnsmasq install

2017-02-03 Thread Eric Luehrsen
> WiFi -> (Client) WDR -> Wire -> Laptop If you build LEDE nearly default and later disable odhcpd, then don't forget to stop odhcpd or reboot the router. odhcpd will hold the port (547/548) and dnsmasq will not be able to obtain it. On 02/03/2017 04:46 PM, Eric Luehrsen wrote: &

Re: [LEDE-DEV] dnsmasq make DHCPv6 viable for standalone dnsmasq install

2017-02-03 Thread Eric Luehrsen
DHCPv6 options) list dhcp_option 'option6:ntp-server,[fd00::]' list dhcp_option 'option6:dns-server,[fd00::]' On 02/03/2017 10:30 PM, Eric Luehrsen wrote: > Cabel -> Modem -> Archer (AP) -> WiFi -> (Client) WDR -> Wire -> Lapt

[LEDE-DEV] initialisation/startup of dnsmasq for multiple instances is broken

2017-02-03 Thread Eric Luehrsen
Small mistake that is easily fixed. See pull request: https://github.com/lede-project/source/pull/780 On 02/03/2017 10:21 AM, e9hack wrote: > my dhcp config file looks like this: ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infrade

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Eric Luehrsen
As much a good "debate" over password strength may be healthy, it is not for LEDE. Password enforcement is a policy decission, and not an engineering decission. LEDE should provide tools to help enforce a diversity of policies. LEDE should not create or enforce any policy. - Eric Orig

Re: [LEDE-DEV] LEDE re-saving entropy in /etc/urandom.seed only seconds after each boot?

2017-02-19 Thread Eric Luehrsen
A random seed doesn't need to be stored all that often. Statistical randomness or entropy is a physics concept more so than security (quantum physics, Heisenberg). As long as the random seed is generated with respect to the devices unique perspective within the universe including time reference

Re: [LEDE-DEV] Cake SQM killing my DIR-860L - was: [17.01] Kernel: bump to 4.4.51

2017-02-27 Thread Eric Luehrsen
On 02/27/2017 03:17 PM, Stijn Segers wrote: > Okay, so I tracked it down to cake being the culprit. When I disable the > Cake SQM instance, no more of those traces, and no more sudden reboots. > > If I can help debug this, let me know - I enabled a Cake SQM instance on > an APU2 and so far that s

Re: [LEDE-DEV] [Cake] Cake SQM killing my DIR-860L - was: [17.01] Kernel: bump to 4.4.51

2017-03-02 Thread Eric Luehrsen
On 03/02/2017 07:02 PM, Jonathan Morton wrote: >> On 3 Mar, 2017, at 01:55, John Yates wrote: >> >> The virtue of a prime number of buckets is that when you mod >> your 32-bit hash value to get a bucket index you harvest _all_ >> of the entropy in the hash, not just the entropy in the bits you >>

Re: [LEDE-DEV] [Cake] Cake SQM killing my DIR-860L - was: [17.01] Kernel: bump to 4.4.51

2017-03-02 Thread Eric Luehrsen
On 03/02/2017 11:35 PM, Jonathan Morton wrote: >> On 3 Mar, 2017, at 06:31, Eric Luehrsen wrote: >> >> Also with SQM you may not what idealized entropy in your queue >> distribution. It is desired by some to have host-connection fairness, >> and not so much intere

[LEDE-DEV] [PATCH odhcpd] dhcpv6-ia: add option for dhcpv6 privacy address

2017-03-09 Thread Eric Luehrsen
added per interface to switch from reasonablely consistent 16 bit HOSTID to a random rolling 32 bit HOSTID. See FS#403. Signed-off-by: Eric Luehrsen --- README | 2 ++ src/config.c| 7 +++ src/dhcpv6-ia.c | 27 --- src/odhcpd.h| 1 + 4 files c

Re: [LEDE-DEV] 18.06 Status?

2018-05-01 Thread Eric Luehrsen
On 05/01/2018 10:47 AM, Hannu Nyman wrote: I think that the main source tree is in pretty good shape, so branching off the 18.0X rather soon might make sense I would also think its time to branch 18.[something-soon], and rather than focus on work that needs yet to be completed, look to cut

Re: [LEDE-DEV] [PATCH] Add procd triggers only for interfaces that dnsmasq is interested in.

2018-05-07 Thread Eric Luehrsen
On 05/07/2018 06:37 PM, hux wrote: Signed-off-by: hux --- Right now interface.update events are sent out by netifd upon interface state, route, address (lifetime), prefix lifetime changes. Dnsmasq is only interested in interface state changes and currently adds an interface trigger for all the