[PR] KAFKA-19042: [4/N] Move PlaintextConsumerCallbackTest to client-integration-tests module [kafka]

2025-03-26 Thread via GitHub
m1a2st opened a new pull request, #19298: URL: https://github.com/apache/kafka/pull/19298 Use Java to rewrite `PlaintextConsumerCallbackTest` by new test infra and move it to client-integration-tests module. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-26 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938478#comment-17938478 ] Lorcan commented on KAFKA-19022: Hi [~rsamudrala], I've checked the KafkaRaftClient clas

[jira] [Resolved] (KAFKA-18300) Improve coordinator records

2025-03-26 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18300. - Fix Version/s: 4.1.0 Resolution: Fixed > Improve coordinator records > --

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013806185 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

[jira] [Resolved] (KAFKA-18612) Update ApiMessageFormatter

2025-03-26 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18612. - Fix Version/s: 4.1.0 Resolution: Fixed Addressed by https://github.com/apache/kafka/comm

Re: [PR] (WIP) KAFKA-18409: ShareGroupStateMessageFormatter should use ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
brandboat commented on PR #18510: URL: https://github.com/apache/kafka/pull/18510#issuecomment-2753884551 > @brandboat We have merged https://github.com/apache/kafka/pull/18695. We can proceed with your PR. Please ping me when the PR is ready for review. Thanks for the heads-up, I'll

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-26 Thread via GitHub
mimaison commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2013891681 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,793 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-03-26 Thread via GitHub
m1a2st commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2014432276 ## clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java: ## @@ -289,6 +295,13 @@ protected Map postProcessParsedConfig(final Map CommonC

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

2025-03-26 Thread via GitHub
mimaison commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2755034626 I kind of agree with @gharris1727. Kafka is not using this code and this is not a public API, so this is effectively adding code to the Kafka code base just for your use case. Sure the c

[jira] [Updated] (KAFKA-16894) Define switches to enable share groups for preview

2025-03-26 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16894: - Fix Version/s: 4.1.0 > Define switches to enable share groups for preview >

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-26 Thread via GitHub
ShivsundarR closed pull request #19294: MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. URL: https://github.com/apache/kafka/pull/19294 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-26 Thread via GitHub
ShivsundarR opened a new pull request, #19295: URL: https://github.com/apache/kafka/pull/19295 *What* Currently if we received just a control record in the `ShareFetchResponse`, then the currentFetch in `ShareConsumerImpl` would not be updated as the record is ignored. But in the process

[jira] [Updated] (KAFKA-16894) Define switches to enable share groups for preview

2025-03-26 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16894: - Summary: Define switches to enable share groups for preview (was: Define group.version=

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
mimaison commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014493205 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

[PR] KAFKA-19042: [2/N] Move TransactionsWithMaxInFlightOneTest to client-integration-tests module [kafka]

2025-03-26 Thread via GitHub
FrankYang0529 opened a new pull request, #19289: URL: https://github.com/apache/kafka/pull/19289 Use Java to rewrite `TransactionsWithMaxInFlightOneTest` by new test infra and move it to client-integration-tests module. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-12744: dependency upgrade: `argparse4j` 0.7.0 -->> 0.9.0 [kafka]

2025-03-26 Thread via GitHub
dejan2609 commented on PR #19265: URL: https://github.com/apache/kafka/pull/19265#issuecomment-2755336115 Pardon me for not testing with checkstyle in a first place @mimaison. Anyway, I fixed imports but Gradle build fails again: `warning: [deprecation] newArgumentParser(String) in

[jira] [Updated] (KAFKA-16394) ForeignKey LEFT join propagates null value on foreignKey change

2025-03-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16394: Fix Version/s: 3.9.1 > ForeignKey LEFT join propagates null value on foreignKey change > -

[jira] [Updated] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-03-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18713: Due Date: (was: 3/Feb/25) > Kafka Streams Left-Join not always emitting the last value

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2014733112 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] KAFKA-12744: dependency upgrade: `argparse4j` 0.7.0 -->> 0.9.0 [kafka]

2025-03-26 Thread via GitHub
dejan2609 commented on PR #19265: URL: https://github.com/apache/kafka/pull/19265#issuecomment-2755363293 So, herewith alternatives: 1. relax Checkstyle rules via exception (i.e. don't fail the build for `ArgumentParsers.newArgumentParser` method deprecation warning mentioned above) **_

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-26 Thread via GitHub
AndrewJSchofield merged PR #19192: URL: https://github.com/apache/kafka/pull/19192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
dajac merged PR #18695: URL: https://github.com/apache/kafka/pull/18695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-6333 java.awt.headless should not be on commandline [kafka]

2025-03-26 Thread via GitHub
mimaison commented on code in PR #19237: URL: https://github.com/apache/kafka/pull/19237#discussion_r2013902994 ## core/src/main/scala/kafka/Kafka.scala: ## @@ -73,7 +73,7 @@ object Kafka extends Logging { try { val serverProps = getPropsFromArgs(args) val ser

Re: [PR] MINOR: Write log differently according to the size of missingListenerPartitions [kafka]

2025-03-26 Thread via GitHub
HyunSangHan commented on PR #11418: URL: https://github.com/apache/kafka/pull/11418#issuecomment-2754340862 I am still here! ✋ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-16894: Define features to enable share groups [kafka]

2025-03-26 Thread via GitHub
dajac commented on PR #19293: URL: https://github.com/apache/kafka/pull/19293#issuecomment-2755031196 @AndrewJSchofield I would like to better understand how `group.version=2` will be used. Could you elaborate a bit more on what we will gate with it? -- This is an automated message from

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014001146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

[PR] KAFKA-16894: Define features to enable share groups [kafka]

2025-03-26 Thread via GitHub
AndrewJSchofield opened a new pull request, #19293: URL: https://github.com/apache/kafka/pull/19293 This PR proposes two switches to enable share groups for 4.1 (preview) and 4.2 (GA). * `group.version=2` to indicate that the group coordinator is able to understand share group record

[PR] MINOR: Mark streams RPCs as unstable [kafka]

2025-03-26 Thread via GitHub
lucasbru opened a new pull request, #19292: URL: https://github.com/apache/kafka/pull/19292 Streams groups RPCs are not enabled by default, but they should also be marked as unstable. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Updated] (KAFKA-16894) Define switches to enable share groups for preview

2025-03-26 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16894: - Description: Create group.version=2 and share.version=1 as the switches to enable share

[PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-26 Thread via GitHub
ShivsundarR opened a new pull request, #19294: URL: https://github.com/apache/kafka/pull/19294 *What* Currently if we received just a control record in the `ShareFetchResponse`, then the currentFetch in `ShareConsumerImpl` would not be updated as the record is ignored. But in the process

[jira] [Updated] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

2025-03-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16407: Fix Version/s: 3.9.1 > ForeignKey INNER join ignores FK change when its previous value is

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-03-26 Thread via GitHub
junrao commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2015116293 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -89,7 +89,7 @@ public FetchResponseData data() { */ public FetchResponse(F

Re: [PR] MINOR: add log4j2.yaml to clients-integration-tests module [kafka]

2025-03-26 Thread via GitHub
m1a2st commented on code in PR #19252: URL: https://github.com/apache/kafka/pull/19252#discussion_r2007875519 ## clients/clients-integration-tests/src/test/resources/log4j2.yaml: ## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contrib

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-03-26 Thread via GitHub
ableegoldman commented on code in PR #19269: URL: https://github.com/apache/kafka/pull/19269#discussion_r2015005410 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -70,6 +70,7 @@ public class StreamsProducer { private Produc

[jira] [Commented] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938778#comment-17938778 ] Lan Ding commented on KAFKA-19024: -- Hi [~schofielaj], If this ticket is still open, ma

[PR] Allow re-registration for fenced / cleanly shutdown brokers [kafka]

2025-03-26 Thread via GitHub
ahuang98 opened a new pull request, #19296: URL: https://github.com/apache/kafka/pull/19296 Will create a jira and add the id in a bit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Allow re-registration for fenced / cleanly shutdown brokers [kafka]

2025-03-26 Thread via GitHub
ahuang98 commented on code in PR #19296: URL: https://github.com/apache/kafka/pull/19296#discussion_r2015416417 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -353,7 +353,7 @@ public ControllerResult registerBroker( if (existing

[jira] [Commented] (KAFKA-17541) Improve handling of delivery count

2025-03-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938772#comment-17938772 ] Lan Ding commented on KAFKA-17541: -- Hi [~schofielaj] , If this ticket is still open, m

[jira] [Created] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.group`s

2025-03-26 Thread Sanskar Jhajharia (Jira)
Sanskar Jhajharia created KAFKA-19024: - Summary: Enhance the client behaviour when it tries to exceed the `group.share.max.group`s Key: KAFKA-19024 URL: https://issues.apache.org/jira/browse/KAFKA-19024

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-26 Thread via GitHub
lianetm commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2014959782 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

Re: [PR] Allow re-registration for fenced / cleanly shutdown brokers [kafka]

2025-03-26 Thread via GitHub
splett2 commented on code in PR #19296: URL: https://github.com/apache/kafka/pull/19296#discussion_r2015175160 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -353,7 +353,7 @@ public ControllerResult registerBroker( if (existing

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-26 Thread via GitHub
mjsax commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2015238843 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -496,16 +483,20 @@ private void addGlobal

Re: [PR] [WIP] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-03-26 Thread via GitHub
kirktrue commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2755596812 cc @k-raina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Commented] (KAFKA-3370) Add options to auto.offset.reset to reset offsets upon initialization only

2025-03-26 Thread Akshesh Doshi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938708#comment-17938708 ] Akshesh Doshi commented on KAFKA-3370: -- Hi We had an issue with our Kafka consumers

Re: [PR] [WIP] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-03-26 Thread via GitHub
kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2014904591 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -667,14 +667,23 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-03-26 Thread via GitHub
AndrewJSchofield merged PR #19026: URL: https://github.com/apache/kafka/pull/19026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-26 Thread via GitHub
jsancio merged PR #19163: URL: https://github.com/apache/kafka/pull/19163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-26 Thread via GitHub
mjsax commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2015232961 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -496,16 +483,20 @@ private void addGlobal

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-26 Thread via GitHub
mjsax commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2015235819 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -496,16 +483,20 @@ private void addGlobal

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-26 Thread via GitHub
mjsax commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2015231173 ## streams/src/main/java/org/apache/kafka/streams/internals/metrics/StreamsThreadMetricsDelegatingReporter.java: ## @@ -60,7 +60,8 @@ public void metricChange(final Kafka

[jira] [Updated] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-03-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18713: Fix Version/s: 3.9.1 > Kafka Streams Left-Join not always emitting the last value > --

[jira] [Commented] (KAFKA-19012) Messages ending up on the wrong topic

2025-03-26 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938749#comment-17938749 ] Artem Livshits commented on KAFKA-19012: [~dnadolny] a few questions: * what ar

[jira] [Commented] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-26 Thread Ranganath Samudrala (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938715#comment-17938715 ] Ranganath Samudrala commented on KAFKA-19022: - Agree that [FetchResponse.js

[jira] [Created] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-26 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-19047: Summary: Broker registrations are slow if previously fenced or shutdown Key: KAFKA-19047 URL: https://issues.apache.org/jira/browse/KAFKA-19047 Project: Kafka

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-03-26 Thread via GitHub
frankvicky commented on code in PR #19269: URL: https://github.com/apache/kafka/pull/19269#discussion_r2015413116 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -324,6 +329,22 @@ void close() { transactionInitialized =

Re: [PR] MINOR update the README docker image version [kafka]

2025-03-26 Thread via GitHub
m1a2st commented on PR #19278: URL: https://github.com/apache/kafka/pull/19278#issuecomment-2753763363 Hello @frankvicky, I consider the README similar to Kafka's "Quick Start" section, so I think we should focus on helping users start quickly. Using `latest` should be good enough. -- Th

Re: [PR] KAFKA-17645: KIP-1052: Enable warmup in producer performance test [kafka]

2025-03-26 Thread via GitHub
matt-welch commented on code in PR #17340: URL: https://github.com/apache/kafka/pull/17340#discussion_r2010980706 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -94,7 +101,19 @@ void start(String[] args) throws IOException { record

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-26 Thread via GitHub
dajac commented on PR #19290: URL: https://github.com/apache/kafka/pull/19290#issuecomment-2754294910 I still need to add a unit tests for the new method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-26 Thread via GitHub
dajac opened a new pull request, #19290: URL: https://github.com/apache/kafka/pull/19290 This patch addresses a weirdness on the GroupCoordinator write path. The `CoordinatorPartitionWriter` uses the `ReplicaManager#appendRecords` method with `acks=1` and it expects it to completes immediat

[jira] [Created] (KAFKA-19046) Change delete cleanup policy to compact cleanup policy

2025-03-26 Thread George Yang (Jira)
George Yang created KAFKA-19046: --- Summary: Change delete cleanup policy to compact cleanup policy Key: KAFKA-19046 URL: https://issues.apache.org/jira/browse/KAFKA-19046 Project: Kafka Issue Ty

[jira] [Resolved] (KAFKA-18899) Limit retry time for ShareConsumer.commitAsync

2025-03-26 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18899. -- Resolution: Fixed > Limit retry time for ShareConsumer.commitAsync > -

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013699771 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013704465 ## server-common/src/main/java/org/apache/kafka/server/storage/log/FetchIsolation.java: ## @@ -25,11 +25,11 @@ public enum FetchIsolation { TXN_COMMITTED;

[jira] [Commented] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-26 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938509#comment-17938509 ] Lorcan commented on KAFKA-19022: Upon further investigation and reading the file FetchRe

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013699195 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013997096 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014001146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014001146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

[jira] [Commented] (KAFKA-7699) Improve wall-clock time punctuations

2025-03-26 Thread Herman Kolstad Jakobsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938578#comment-17938578 ] Herman Kolstad Jakobsen commented on KAFKA-7699: The KIP can be found at

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014001146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-03-26 Thread via GitHub
AndrewJSchofield commented on PR #19026: URL: https://github.com/apache/kafka/pull/19026#issuecomment-2754166976 @smjn Please can you merge the latest changes from trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014001146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2014001146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013847250 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] (WIP) KAFKA-18409: ShareGroupStateMessageFormatter should use ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
dajac commented on PR #18510: URL: https://github.com/apache/kafka/pull/18510#issuecomment-2753880538 @brandboat We have merged https://github.com/apache/kafka/pull/18695. We can proceed with your PR. Please ping me when the PR is ready for review. -- This is an automated message from the

[jira] [Comment Edited] (KAFKA-18792) Enforce uniform PR structure for merge queue

2025-03-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936903#comment-17936903 ] David Arthur edited comment on KAFKA-18792 at 3/19/25 6:35 PM: ---

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2013533692 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-18893: KIP-877 Add support for ReplicaSelector [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19064: URL: https://github.com/apache/kafka/pull/19064#discussion_r2004221275 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1723,7 +1723,7 @@ class ReplicaManager(val config: KafkaConfig, metadata => findPreferredRea

Re: [PR] KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
dajac commented on code in PR #18695: URL: https://github.com/apache/kafka/pull/18695#discussion_r2013562510 ## tools/src/test/java/org/apache/kafka/tools/consumer/CoordinatorRecordMessageFormatterTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
dajac commented on PR #18695: URL: https://github.com/apache/kafka/pull/18695#issuecomment-2753506292 @chia7712 Thanks for your comments. I just addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-26 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2007165486 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Resolved] (KAFKA-18893) Add support for ReplicaSelector

2025-03-26 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18893. Fix Version/s: 4.1.0 Resolution: Fixed > Add support for ReplicaSelector >

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013529068 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -847,6 +859,7 @@ public ShareAcquiredRecords acquire( } Review Comment: we

[jira] [Updated] (KAFKA-19046) Change delete cleanup policy to compact cleanup policy

2025-03-26 Thread George Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Yang updated KAFKA-19046: Description: The internal topics of MirrorMaker 2 (MM2) sometimes report the following error: {c

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013589373 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013577087 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java: ## @@ -83,6 +92,8 @@ public final class GroupConfig extends AbstractConf

[jira] [Comment Edited] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-26 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938478#comment-17938478 ] Lorcan edited comment on KAFKA-19022 at 3/26/25 8:20 AM: - Hi [~r

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-26 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013529068 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -847,6 +859,7 @@ public ShareAcquiredRecords acquire( } Review Comment: we

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-26 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2013548508 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
dajac commented on code in PR #18695: URL: https://github.com/apache/kafka/pull/18695#discussion_r2013553668 ## tools/src/main/java/org/apache/kafka/tools/consumer/CoordinatorRecordMessageFormatter.java: ## @@ -31,44 +34,50 @@ import static java.nio.charset.StandardCharsets.U

Re: [PR] KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-26 Thread via GitHub
dajac commented on code in PR #18695: URL: https://github.com/apache/kafka/pull/18695#discussion_r2013554650 ## tools/src/test/java/org/apache/kafka/tools/consumer/CoordinatorRecordMessageFormatterTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-26 Thread via GitHub
mjsax commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2015214289 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -419,8 +485,36 @@ private Topology comple

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-26 Thread via GitHub
chia7712 commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2756906467 @wernerdv thanks for taking on this major migration. Really well done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-19042: [1/N] Move ConsumerTopicCreationTest to client-integration-tests module [kafka]

2025-03-26 Thread via GitHub
m1a2st commented on code in PR #19283: URL: https://github.com/apache/kafka/pull/19283#discussion_r2015550703 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerTopicCreationTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2756468366 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18607: Update jfreechart dependency [kafka]

2025-03-26 Thread via GitHub
mingdaoy commented on PR #19074: URL: https://github.com/apache/kafka/pull/19074#issuecomment-2756489837 @mimaison I'll test that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-18607: Update jfreechart dependency [kafka]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #19074: URL: https://github.com/apache/kafka/pull/19074#issuecomment-2756469253 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Created] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-26 Thread Jialun Peng (Jira)
Jialun Peng created KAFKA-19048: --- Summary: Minimal Movement Replica Balancing algorithm Key: KAFKA-19048 URL: https://issues.apache.org/jira/browse/KAFKA-19048 Project: Kafka Issue Type: Improv

Re: [PR] MINOR: Add doc for configuration parameters to keep the format consistent [kafka]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #19244: URL: https://github.com/apache/kafka/pull/19244#issuecomment-2756467904 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19008 Remove scala version from artifacts [kafka]

2025-03-26 Thread via GitHub
github-actions[bot] commented on PR #19241: URL: https://github.com/apache/kafka/pull/19241#issuecomment-2756468164 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

  1   2   >