mjsax commented on code in PR #18953:
URL: https://github.com/apache/kafka/pull/18953#discussion_r2015231173
##########
streams/src/main/java/org/apache/kafka/streams/internals/metrics/StreamsThreadMetricsDelegatingReporter.java:
##########
@@ -60,7 +60,8 @@ public void metricChange(final KafkaMetric metric) {
private boolean tagMatchStreamOrStateUpdaterThreadId(final KafkaMetric
metric) {
final Map<String, String> tags = metric.metricName().tags();
- final boolean shouldInclude = tags.containsKey(THREAD_ID_TAG) &&
(tags.get(THREAD_ID_TAG).equals(threadId) ||
tags.get(THREAD_ID_TAG).equals(stateUpdaterThreadId));
+ final boolean shouldInclude = tags.containsKey(THREAD_ID_TAG) &&
(tags.get(THREAD_ID_TAG).equals(threadId) ||
+
Optional.of(tags.get(THREAD_ID_TAG)).equals(stateUpdaterThreadId));
Review Comment:
Should this be `Optional.ofNullable(tags.get(THREAD_ID_TAG))` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
