ableegoldman commented on code in PR #19269:
URL: https://github.com/apache/kafka/pull/19269#discussion_r2015005410
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:
##########
@@ -70,6 +70,7 @@ public class StreamsProducer {
private Producer<byte[], byte[]> producer;
private boolean transactionInFlight = false;
private boolean transactionInitialized = false;
+ private boolean allowReset = true;
Review Comment:
it's a bit confusing that we flip-flop back and forth between "disableReset"
and "allowReset", I'd recommend picking one (probably `disableReset`) for all
the method and variable names
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:
##########
@@ -324,6 +329,22 @@ void close() {
transactionInitialized = false;
}
+ /**
+ * Disables producer reset to prevent producer recreation during shutdown.
+ * <p>
+ * When disabled, subsequent calls to reInitializeProducer() will not
recreate
+ * the producer instance, avoiding resource leak.
+ * <p>
+ * <strong>
+ * This method should only be invoked when the {@link
org.apache.kafka.streams.processor.internals.ActiveTaskCreator}
Review Comment:
nit: I'd say when the "StreamThread" is shutting down, rather than the
ActiveTaskCreator
Effectively it's the same thing at the moment but you never know what
refactoring may bring, and the important thing here is that the StreamThread
itself is shutting down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
