splett2 commented on code in PR #19296:
URL: https://github.com/apache/kafka/pull/19296#discussion_r2015175160
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -353,7 +353,7 @@ public ControllerResult<BrokerRegistrationReply>
registerBroker(
if (existing != null) {
prevIncarnationId = existing.incarnationId();
storedBrokerEpoch = existing.epoch();
- if (heartbeatManager.hasValidSession(brokerId, existing.epoch())) {
+ if (heartbeatManager.hasValidSession(brokerId, existing.epoch())
&& heartbeatManager.isBrokerActive(brokerId)) {
Review Comment:
could we just check if whether `existing` is fenced or in controlled
shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
