adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2013704465
##########
server-common/src/main/java/org/apache/kafka/server/storage/log/FetchIsolation.java:
##########
@@ -25,11 +25,11 @@ public enum FetchIsolation {
TXN_COMMITTED;
public static FetchIsolation of(FetchRequest request) {
- return of(request.replicaId(), request.isolationLevel());
+ return of(request.replicaId(), request.isolationLevel(), false);
}
- public static FetchIsolation of(int replicaId, IsolationLevel
isolationLevel) {
- if (!FetchRequest.isConsumer(replicaId)) {
+ public static FetchIsolation of(int replicaId, IsolationLevel
isolationLevel, boolean isShareFetchRequest) {
+ if (!FetchRequest.isConsumer(replicaId) && !isShareFetchRequest) {
Review Comment:
I think if I just use `replicaId` as -1, that also works. But I wasn't too
sure if that's the right approach. Hence, opted for adding a new variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
