m1a2st commented on code in PR #19283: URL: https://github.com/apache/kafka/pull/19283#discussion_r2015550703
########## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerTopicCreationTest.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer; + +import org.apache.kafka.common.serialization.ByteArrayDeserializer; +import org.apache.kafka.common.test.ClusterInstance; +import org.apache.kafka.common.test.api.ClusterConfig; +import org.apache.kafka.common.test.api.ClusterTemplate; + +import java.time.Duration; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Set; + +import static org.apache.kafka.clients.consumer.ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG; +import static org.apache.kafka.clients.consumer.ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG; +import static org.apache.kafka.clients.consumer.ConsumerConfig.CLIENT_ID_CONFIG; +import static org.apache.kafka.clients.consumer.ConsumerConfig.GROUP_ID_CONFIG; +import static org.apache.kafka.clients.consumer.ConsumerConfig.GROUP_PROTOCOL_CONFIG; +import static org.apache.kafka.common.test.api.Type.KRAFT; +import static org.apache.kafka.server.config.ServerLogConfigs.AUTO_CREATE_TOPICS_ENABLE_CONFIG; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class ConsumerTopicCreationTest { + private static final String TOPIC = "topic"; + private static final long POLL_TIMEOUT = 1000; + + @ClusterTemplate("autoCreateTopicsConfigs") + void testAsyncConsumerTopicCreationIfConsumerAllowToCreateTopic(ClusterInstance cluster) { + try (Consumer<byte[], byte[]> consumer = createConsumer(GroupProtocol.CONSUMER, true, cluster.bootstrapServers())) { + consumer.subscribe(List.of(TOPIC)); + consumer.poll(Duration.ofMillis(POLL_TIMEOUT)); + if (allowAutoCreateTopics(cluster)) + assertTrue(getAllTopics(cluster).contains(TOPIC)); + else + assertFalse(getAllTopics(cluster).contains(TOPIC), + "Both " + AUTO_CREATE_TOPICS_ENABLE_CONFIG + " and " + ALLOW_AUTO_CREATE_TOPICS_CONFIG + " need to be true to create topic automatically"); + } + } + + @ClusterTemplate("autoCreateTopicsConfigs") + void testAsyncConsumerTopicCreationIfConsumerDisallowToCreateTopic(ClusterInstance cluster) { + try (Consumer<byte[], byte[]> consumer = createConsumer(GroupProtocol.CONSUMER, false, cluster.bootstrapServers())) { + consumer.subscribe(List.of(TOPIC)); + consumer.poll(Duration.ofMillis(POLL_TIMEOUT)); + assertFalse(getAllTopics(cluster).contains(TOPIC), + "Both " + AUTO_CREATE_TOPICS_ENABLE_CONFIG + " and " + ALLOW_AUTO_CREATE_TOPICS_CONFIG + " need to be true to create topic automatically"); + } + } + + @ClusterTemplate("autoCreateTopicsConfigs") + void testClassicConsumerTopicCreationIfConsumerAllowToCreateTopic(ClusterInstance cluster) { + try (Consumer<byte[], byte[]> consumer = createConsumer(GroupProtocol.CLASSIC, true, cluster.bootstrapServers())) { + consumer.subscribe(List.of(TOPIC)); + consumer.poll(Duration.ofMillis(POLL_TIMEOUT)); + if (allowAutoCreateTopics(cluster)) + assertTrue(getAllTopics(cluster).contains(TOPIC)); + else + assertFalse(getAllTopics(cluster).contains(TOPIC), + "Both " + AUTO_CREATE_TOPICS_ENABLE_CONFIG + " and " + ALLOW_AUTO_CREATE_TOPICS_CONFIG + " need to be true to create topic automatically"); + } + } + + @ClusterTemplate("autoCreateTopicsConfigs") + void testClassicConsumerTopicCreationIfConsumerDisallowToCreateTopic(ClusterInstance cluster) { + try (Consumer<byte[], byte[]> consumer = createConsumer(GroupProtocol.CLASSIC, false, cluster.bootstrapServers())) { + consumer.subscribe(List.of(TOPIC)); + consumer.poll(Duration.ofMillis(POLL_TIMEOUT)); + assertFalse(getAllTopics(cluster).contains(TOPIC), + "Both " + AUTO_CREATE_TOPICS_ENABLE_CONFIG + " and " + ALLOW_AUTO_CREATE_TOPICS_CONFIG + " need to be true to create topic automatically"); + } + } + + private boolean allowAutoCreateTopics(ClusterInstance cluster) { + return cluster.config().serverProperties().get(AUTO_CREATE_TOPICS_ENABLE_CONFIG).equals("true"); + } + + private Set<String> getAllTopics(ClusterInstance cluster) { + return cluster.brokers().values().iterator().next().metadataCache().getAllTopics(); + } + + private static List<ClusterConfig> autoCreateTopicsConfigs() { + return List.of( + ClusterConfig.defaultBuilder() + .setTypes(Set.of(KRAFT)) + .setServerProperties(Map.of(AUTO_CREATE_TOPICS_ENABLE_CONFIG, "true")) + .build(), + ClusterConfig.defaultBuilder() + .setTypes(Set.of(KRAFT)) + .setServerProperties(Map.of(AUTO_CREATE_TOPICS_ENABLE_CONFIG, "false")) + .build() + ); + } + + private Consumer<byte[], byte[]> createConsumer(GroupProtocol protocol, boolean allowConsumerAutoCreateTopics, String bootstrapServer) { + Map<String, Object> consumerConfig = Map.of( + CLIENT_ID_CONFIG, "ConsumerTestConsumer", + GROUP_ID_CONFIG, "TestGroup", + ALLOW_AUTO_CREATE_TOPICS_CONFIG, allowConsumerAutoCreateTopics, + GROUP_PROTOCOL_CONFIG, protocol.name().toLowerCase(Locale.ROOT), + BOOTSTRAP_SERVERS_CONFIG, bootstrapServer + ); + return new KafkaConsumer<>(consumerConfig, new ByteArrayDeserializer(), new ByteArrayDeserializer()); Review Comment: Should use `cluster.consumer()` to create consumer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
