smjn commented on PR #18848:
URL: https://github.com/apache/kafka/pull/18848#issuecomment-2671651121
@dajac Thanks for the review
incorporated comments. Replied to Qs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928817#comment-17928817
]
Shivsundar R commented on KAFKA-18665:
--
One more test "{*}testSubscriptionAndPollFo
frankvicky commented on PR #18844:
URL: https://github.com/apache/kafka/pull/18844#issuecomment-2671699642
I have tested a jvm container with this patch through docker compse by
following the instructions for Multiple Nodes on the official docker hub page.
![Screenshot from 2025-02-20
22
[
https://issues.apache.org/jira/browse/KAFKA-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928817#comment-17928817
]
Shivsundar R edited comment on KAFKA-18665 at 2/20/25 2:34 PM:
---
lucasbru opened a new pull request, #18981:
URL: https://github.com/apache/kafka/pull/18981
Implements auto-topic creation when handling the streams group heartbeat.
Inside KafkaApis, the handler for streamsGroupHeartbeat uses the result of
the streams group heartbeat inside the group
lucasbru commented on code in PR #18911:
URL: https://github.com/apache/kafka/pull/18911#discussion_r1963773520
##
tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandTest.java:
##
@@ -0,0 +1,447 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
lucasbru commented on code in PR #18911:
URL: https://github.com/apache/kafka/pull/18911#discussion_r1963792617
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -307,6 +336,43 @@ Map
getOffsets(Collection m
return lag;
lucasbru commented on code in PR #18911:
URL: https://github.com/apache/kafka/pull/18911#discussion_r1963795902
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -270,7 +285,7 @@ private void printOffsets(StreamsGroupDescription
description,
lucasbru commented on code in PR #18911:
URL: https://github.com/apache/kafka/pull/18911#discussion_r1963792617
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -307,6 +336,43 @@ Map
getOffsets(Collection m
return lag;
chia7712 commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1963720494
##
docker/jvm/Dockerfile:
##
@@ -62,14 +66,19 @@ LABEL org.label-schema.name="kafka" \
RUN set -eux ; \
apk update ; \
apk upgrade ; \
-apk add --no-cac
lucasbru commented on code in PR #18911:
URL: https://github.com/apache/kafka/pull/18911#discussion_r1963804385
##
tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandTest.java:
##
@@ -0,0 +1,447 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
frankvicky commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1963813966
##
docker/jvm/Dockerfile:
##
@@ -62,14 +66,19 @@ LABEL org.label-schema.name="kafka" \
RUN set -eux ; \
apk update ; \
apk upgrade ; \
-apk add --no-c
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1963943011
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1159,6 +1180,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validBytesCount, lastOffsetOfFi
Mickael Maison created KAFKA-18837:
--
Summary: Validate controller.quorum.fetch.timeout.ms is a positive
value
Key: KAFKA-18837
URL: https://issues.apache.org/jira/browse/KAFKA-18837
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TaiJuWu reassigned KAFKA-18837:
---
Assignee: TaiJuWu
> Validate controller.quorum.fetch.timeout.ms is a positive value
> -
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1963952342
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1086,63 +1088,82 @@ class UnifiedLog(@volatile var logStartOffset: Long,
var shallowOffsetOfMaxTimestamp
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1963956118
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1159,6 +1180,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validBytesCount, lastOffsetOfFi
dejan2609 commented on PR #18018:
URL: https://github.com/apache/kafka/pull/18018#issuecomment-2672100187
@poom-kitti interesting takes, I believe @Goooler is a person that can look
into GradleUp/shadow subject.
@apoorvmittal10 just a reminder for you to review this PR.
--
This is
brandboat opened a new pull request, #18983:
URL: https://github.com/apache/kafka/pull/18983
KAFKA-14121
Add new option `allowReplicationFactorChange` to
alterPartitionReassignments. Set this option to false prevents partition
replication factor being changed during partition reassig
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964017067
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1817,14 +1839,15 @@ private void appendAsFollower(
partitionState.updateState();
junrao commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1964026528
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -123,8 +123,7 @@ public class ConsumerMembershipManager extend
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964030635
##
clients/src/test/java/org/apache/kafka/common/record/InvalidMemoryRecordsProvider.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lianetm merged PR #18737:
URL: https://github.com/apache/kafka/pull/18737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964002760
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1802,10 +1804,30 @@ private boolean handleFetchResponse(
}
}
-private void
Parkerhiphop opened a new pull request, #18984:
URL: https://github.com/apache/kafka/pull/18984
Fix GPG signature verification in native Docker build.
[KAFKA-18823](https://issues.apache.org/jira/browse/KAFKA-18823)
### Committer Checklist (excluded from commit message)
- [ ]
José Armando García Sancio created KAFKA-18838:
--
Summary: Fix ArbitraryMemoryRecords so that they are always invalid
Key: KAFKA-18838
URL: https://issues.apache.org/jira/browse/KAFKA-18838
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964063484
##
core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala:
##
@@ -108,12 +118,93 @@ final class KafkaMetadataLogTest {
classOf[RuntimeException],
() =>
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-18836:
---
Assignee: Paweł Szymczyk
> Make ConsumerGroupMetadata an interface
> --
[
https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928872#comment-17928872
]
Matthias J. Sax commented on KAFKA-18836:
-
Thanks for for agree on who works on
CalvinConfluent commented on PR #18880:
URL: https://github.com/apache/kafka/pull/18880#issuecomment-2672249587
@chia7712 Can you help merge the change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
[
https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-14911:
---
Assignee: (was: Victoria Xia)
> Add system tests for rolling upgrade path of KI
[
https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14911:
Priority: Minor (was: Major)
> Add system tests for rolling upgrade path of KIP-904
> ---
mjsax commented on code in PR #18977:
URL: https://github.com/apache/kafka/pull/18977#discussion_r1964074951
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerGroupMetadata.java:
##
@@ -16,77 +16,23 @@
*/
package org.apache.kafka.clients.consumer;
-import o
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964102208
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -480,22 +481,36 @@ class PartitionTest extends AbstractPartitionTest {
}
partition.crea
mjsax commented on PR #18975:
URL: https://github.com/apache/kafka/pull/18975#issuecomment-2672262254
Java 23 passed.
Java 17:
```
Found 1 test failures:
FAILED ❌ AbstractCoordinatorTest >
testWakeupAfterSyncGroupReceivedExternalCompletion()
Found 2 flaky test failures:
junrao commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1964112656
##
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##
@@ -187,4 +186,67 @@ static Partition partition(ReplicaManager replicaManager,
TopicPartition tp) {
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964115601
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -5177,9 +5177,12 @@ class ReplicaManagerTest {
replicaManager.getPartition(topicPartit
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964116969
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -1383,10 +1432,32 @@ class UnifiedLogTest {
// this is a bit contrived. to trigger the duplicate
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964121960
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -1904,9 +1988,94 @@ class UnifiedLogTest {
val log = createLog(logDir, LogTestUtils.createLogCo
mumrah opened a new pull request, #18985:
URL: https://github.com/apache/kafka/pull/18985
Add a Python script to retrieve a PR using the GitHub CLI and validate its
structure. For now this just includes the title and body, but could perform
other non-code related checks in the future.
junrao commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964132993
##
core/src/test/scala/unit/kafka/server/MockFetcherThread.scala:
##
@@ -115,6 +125,11 @@ class MockFetcherThread(val mockLeader: MockLeaderEndPoint,
batches.head
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964158698
##
core/src/test/scala/unit/kafka/server/MockFetcherThread.scala:
##
@@ -115,6 +125,11 @@ class MockFetcherThread(val mockLeader: MockLeaderEndPoint,
batches.hea
CalvinConfluent commented on PR #18952:
URL: https://github.com/apache/kafka/pull/18952#issuecomment-2672189787
testBalancePartitionLeaders can pass in local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964002760
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1802,10 +1804,30 @@ private boolean handleFetchResponse(
}
}
-private void
jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964165736
##
clients/src/test/java/org/apache/kafka/common/record/InvalidMemoryRecordsProvider.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lianetm commented on PR #18980:
URL: https://github.com/apache/kafka/pull/18980#issuecomment-2672390050
Thanks for the review @ShivsundarR !
We just found a simpler alternative on the coordinator side for this issue,
and that one won't require this client change. So I will just close
lianetm closed pull request #18980: KAFKA-18813: [2/N] Client consistent ack
for assignment received
URL: https://github.com/apache/kafka/pull/18980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mumrah closed pull request #18875: DRAFT Standardize PR format
URL: https://github.com/apache/kafka/pull/18875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
mumrah commented on PR #18875:
URL: https://github.com/apache/kafka/pull/18875#issuecomment-2672397665
Closed in favor of #18985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
mumrah commented on PR #18937:
URL: https://github.com/apache/kafka/pull/18937#issuecomment-2672446385
Oh, also please refrain from force pushing now that the review has started
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
mumrah commented on code in PR #6731:
URL: https://github.com/apache/kafka/pull/6731#discussion_r1964210916
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1136,24 +1163,42 @@ private PartitionRecords
parseCompletedFetch(CompletedFetch
VedarthConfluent commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1964232749
##
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##
@@ -110,7 +110,9 @@ object KafkaDockerWrapper extends Logging {
case Some(str) => str
VedarthConfluent commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1964237255
##
docker/jvm/Dockerfile:
##
@@ -22,20 +22,24 @@ USER root
# Get kafka from https://archive.apache.org/dist/kafka and pass the url
through build arguments
frankvicky commented on PR #18844:
URL: https://github.com/apache/kafka/pull/18844#issuecomment-2671778651
I have also tested a native container with this patch through docker compse
by following the instructions for Multiple Nodes on the official docker hub
page.
![Screenshot from 2025-
mumrah commented on PR #18905:
URL: https://github.com/apache/kafka/pull/18905#issuecomment-2672495914
@Yunyung please check if this PR is still needed now that
https://github.com/apache/kafka/pull/18845 is merged
--
This is an automated message from the Apache Git Service.
To respond to
Yunyung commented on PR #18905:
URL: https://github.com/apache/kafka/pull/18905#issuecomment-2672533468
Close the PR as duplicate #18845.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
Yunyung closed pull request #18905: KAFKA-18740: Remove BootstrapDirectory#ibp
URL: https://github.com/apache/kafka/pull/18905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
[
https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928899#comment-17928899
]
Jun Rao commented on KAFKA-18477:
-
[~m1a2st] : Sorry for the late reply. We can change
lianetm opened a new pull request, #18986:
URL: https://github.com/apache/kafka/pull/18986
Support TopicAuthorizationException received in HB response (after a
consumer subscribed to topics without the required ACLs)
Propagate the error to the consumer poll. Note that even though Topi
kevin-wu24 opened a new pull request, #18987:
URL: https://github.com/apache/kafka/pull/18987
### What
- Remove global concept of `voters` from `Cluster`, instead it is now an
accurate view of the initial voters.
- Enable KIP-853 by writing a bootstrap snapshot to each of the initi
dajac merged PR #18923:
URL: https://github.com/apache/kafka/pull/18923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cmccabe commented on PR #18954:
URL: https://github.com/apache/kafka/pull/18954#issuecomment-2672719747
@CalvinConfluent please add a test case to FormatterTest of someone turning
on ELR for formatting when MV = 4.0-IV1. Also add a test case that fails with
ELR = 1 and MV = 3.9-IV0 (or othe
junrao commented on PR #18852:
URL: https://github.com/apache/kafka/pull/18852#issuecomment-2672782738
@jsancio : The following failed tests seem related to this PR?
```
FAILED ❌ AbstractFetcherThreadTest >
testRetryAfterUnknownLeaderEpochInLatestOffsetFetch()
FAILED ❌ AbstractF
AndrewJSchofield commented on code in PR #18974:
URL: https://github.com/apache/kafka/pull/18974#discussion_r1963523214
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2536,6 +2536,15 @@ class KafkaApis(val requestChannel: RequestChannel,
if (exception != nu
dajac commented on code in PR #18848:
URL: https://github.com/apache/kafka/pull/18848#discussion_r1963519484
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -6855,6 +6861,45 @@ public void createGroupTombstoneRecords(
chia7712 commented on code in PR #18969:
URL: https://github.com/apache/kafka/pull/18969#discussion_r1963548344
##
core/src/main/scala/kafka/utils/LoggingController.scala:
##
@@ -112,24 +112,30 @@ private class Log4jCoreController extends
LoggingControllerDelegate {
val le
chia7712 commented on code in PR #18969:
URL: https://github.com/apache/kafka/pull/18969#discussion_r1963550245
##
core/src/main/scala/kafka/utils/LoggingController.scala:
##
@@ -112,24 +112,30 @@ private class Log4jCoreController extends
LoggingControllerDelegate {
val le
[
https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit updated KAFKA-18796:
--
Attachment: Screenshot 2025-02-13 at 20.52.15.png
> Fix flaky test testAcquisitionLockOnOffset
lianetm opened a new pull request, #18980:
URL: https://github.com/apache/kafka/pull/18980
Change to ensure the client always sends an ACK when it receives an
assignment from the coordinator (even if it does not need to reconcile it
because it already has).
--
This is an automated messag
[
https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16319:
Component/s: admin
clients
(was: streams)
> Wrong br
bbejeck commented on code in PR #18975:
URL: https://github.com/apache/kafka/pull/18975#discussion_r1964440517
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/WrappingNullableUtils.java:
##
@@ -91,17 +91,15 @@ public static Serde prepareValueSerde(final Serd
101 - 171 of 171 matches
Mail list logo
