jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964121960
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -1904,9 +1988,94 @@ class UnifiedLogTest {
val log = createLog(logDir, LogTestUtils.createLogConfig(maxMessageBytes =
second.sizeInBytes - 1))
- log.appendAsFollower(first)
+ log.appendAsFollower(first, Int.MaxValue)
// the second record is larger then limit but appendAsFollower does not
validate the size.
- log.appendAsFollower(second)
+ log.appendAsFollower(second, Int.MaxValue)
+ }
+
+ @ParameterizedTest
+ @ArgumentsSource(classOf[InvalidMemoryRecordsProvider])
+ def testInvalidMemoryRecords(records: MemoryRecords, expectedException:
Optional[Class[Exception]]): Unit = {
+ val logConfig = LogTestUtils.createLogConfig()
+ val log = createLog(logDir, logConfig)
+ val previousEndOffset = log.logEndOffsetMetadata.messageOffset
+
+ if (expectedException.isPresent()) {
+ assertThrows(
+ expectedException.get(),
+ () => log.appendAsFollower(records, Int.MaxValue)
+ );
+ } else {
+ log.appendAsFollower(records, Int.MaxValue)
+ }
+
+ assertEquals(previousEndOffset, log.logEndOffsetMetadata.messageOffset)
+ }
+
+ @Property(tries = 100, afterFailure = AfterFailureMode.SAMPLE_ONLY)
+ def testRandomRecords(
+ @ForAll(supplier = classOf[ArbitraryMemoryRecords]) records: MemoryRecords
+ ): Unit = {
+ val tempDir = TestUtils.tempDir()
+ val logDir = TestUtils.randomPartitionLogDir(tempDir)
+ try {
+ val logConfig = LogTestUtils.createLogConfig()
+ val log = createLog(logDir, logConfig)
+ val previousEndOffset = log.logEndOffsetMetadata.messageOffset
+
+ // Depedning on the random corruption, unified log sometimes throws and
sometimes returns an
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
