AndrewJSchofield commented on code in PR #18974:
URL: https://github.com/apache/kafka/pull/18974#discussion_r1963523214


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2536,6 +2536,15 @@ class KafkaApis(val requestChannel: RequestChannel,
         if (exception != null) {
           requestHelper.sendMaybeThrottle(request, 
consumerGroupHeartbeatRequest.getErrorResponse(exception))
         } else {
+          if (response.assignment != null) {
+            // Remove the unauthorized topics from the assignment.

Review Comment:
   This case worries me a bit. It means a consumer group member was authorized 
sufficiently to subscribe and be assigned a partition, but the broker is being 
a bit shy and doesn't want to admit the existence of the topic to the member. 
As a result, the topic-partition is assigned to a consumer which is not told 
about it and as a result will not consume from the topic, and neither will any 
other member. Do I have this straight?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to