VedarthConfluent commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964237255
########## docker/jvm/Dockerfile: ########## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG kafka_url +ARG skip_signing=false Review Comment: nit: skip_signing_verification is more apt. Can consider something similar to convey the fact we are skipping the verification as skip_signing can be confusing. This is useful though, thanks for adding it. Although our docker official images script will also need to be updated to support this new arg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
