jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964102208
##########
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##########
@@ -480,22 +481,36 @@ class PartitionTest extends AbstractPartitionTest {
}
partition.createLogIfNotExists(isNew = true, isFutureReplica = false,
offsetCheckpoints, None)
+ var partitionState = new LeaderAndIsrRequest.PartitionState()
+ .setControllerEpoch(0)
+ .setLeader(2)
+ .setLeaderEpoch(prevLeaderEpoch)
+ .setIsr(List[Integer](0, 1, 2, brokerId).asJava)
+ .setPartitionEpoch(1)
+ .setReplicas(List[Integer](0, 1, 2, brokerId).asJava)
+ .setIsNew(false)
+ assertTrue(partition.makeFollower(partitionState, offsetCheckpoints, None))
val appendThread = new Thread {
override def run(): Unit = {
- val records = createRecords(List(new SimpleRecord("k1".getBytes,
"v1".getBytes),
- new SimpleRecord("k2".getBytes, "v2".getBytes)),
- baseOffset = 0)
- partition.appendRecordsToFollowerOrFutureReplica(records, isFuture =
false)
+ val records = createRecords(
+ List(
+ new SimpleRecord("k1".getBytes, "v1".getBytes),
+ new SimpleRecord("k2".getBytes, "v2".getBytes)
+ ),
+ baseOffset = 0,
+ partitionLeaderEpoch = prevLeaderEpoch
+ )
+ partition.appendRecordsToFollowerOrFutureReplica(records, isFuture =
false, prevLeaderEpoch)
}
}
appendThread.start()
TestUtils.waitUntilTrue(() => appendSemaphore.hasQueuedThreads, "follower
log append is not called.")
- val partitionState = new LeaderAndIsrRequest.PartitionState()
+ partitionState = new LeaderAndIsrRequest.PartitionState()
.setControllerEpoch(0)
.setLeader(2)
- .setLeaderEpoch(1)
+ .setLeaderEpoch(prevLeaderEpoch + 1)
Review Comment:
Yes, good catch. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
