Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-10 Thread via GitHub
johnny94 commented on code in PR #19306: URL: https://github.com/apache/kafka/pull/19306#discussion_r2038879355 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -284,7 +294,7 @@ public String hmac() { public void checkArgs() {

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-10 Thread via GitHub
johnny94 commented on code in PR #19306: URL: https://github.com/apache/kafka/pull/19306#discussion_r2038879355 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -284,7 +294,7 @@ public String hmac() { public void checkArgs() {

Re: [PR] KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null [kafka]

2025-04-10 Thread via GitHub
showuon commented on PR #17930: URL: https://github.com/apache/kafka/pull/17930#issuecomment-2795898660 @ahuang98 @jsancio , any other comment for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] KAFKA-19103: Remove OffsetConfig [kafka]

2025-04-10 Thread via GitHub
yunchipang opened a new pull request, #19441: URL: https://github.com/apache/kafka/pull/19441 Remove `OffsetConfig` which was used by old coordinator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Remove unused `ApiVersions` variable from Sender and RecordAccumulator [kafka]

2025-04-10 Thread via GitHub
chia7712 merged PR #19399: URL: https://github.com/apache/kafka/pull/19399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19042: [3/N] Move TransactionsWithMaxInFlightOneTest to client-integration-tests module [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on PR #19289: URL: https://github.com/apache/kafka/pull/19289#issuecomment-2795779889 loop the tests 100 times. all pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-19042: [3/N] Move TransactionsWithMaxInFlightOneTest to client-integration-tests module [kafka]

2025-04-10 Thread via GitHub
chia7712 merged PR #19289: URL: https://github.com/apache/kafka/pull/19289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17444: fix high memory allocation rate for FetchSession.update [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #17052: URL: https://github.com/apache/kafka/pull/17052#issuecomment-2795759425 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] Minor : Increase Config change throwable log info to error [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #14380: URL: https://github.com/apache/kafka/pull/14380#issuecomment-279573 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19101 Remove ControllerMutationQuotaManager#throttleTimeMs unused parameter [kafka]

2025-04-10 Thread via GitHub
chia7712 merged PR #19410: URL: https://github.com/apache/kafka/pull/19410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Modify KafkaEventQueue VoidEvent to as singleton and use more proper function interface [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on code in PR #19356: URL: https://github.com/apache/kafka/pull/19356#discussion_r2038745559 ## server-common/src/main/java/org/apache/kafka/queue/EventQueue.java: ## @@ -107,7 +111,7 @@ public OptionalLong apply(OptionalLong prevDeadlineNs) { }

[jira] [Resolved] (KAFKA-19101) Remove ControllerMutationQuotaManager#throttleTimeMs unused parameter

2025-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19101. Fix Version/s: 4.1.0 Resolution: Fixed > Remove ControllerMutationQuotaManager#thro

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2795738642 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] JWT bearer grant type support [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #18912: URL: https://github.com/apache/kafka/pull/18912#issuecomment-2795738755 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2795738603 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Resolved] (KAFKA-18782) Extend ApplicationRecoverableException related exceptions

2025-04-10 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-18782. Resolution: Fixed > Extend ApplicationRecoverableException related exceptions > --

Re: [PR] KAFKA-18782: Extend ApplicationRecoverableException related exceptions [kafka]

2025-04-10 Thread via GitHub
jolshan merged PR #19354: URL: https://github.com/apache/kafka/pull/19354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2038538874 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1361,10 +1366,10 @@ class ReplicaManager(val config: KafkaConfig, */ private def appendToLocalLo

Re: [PR] KAFKA-19015: Remove share session from cache on share consumer connection drop [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19329: URL: https://github.com/apache/kafka/pull/19329#discussion_r2038534993 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -169,21 +176,69 @@ public synchronized boolean tryEvict(long now) {

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2038535130 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -33,8 +33,8 @@ import scala.jdk.CollectionConverters._ class ProducerSendWhil

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2038530717 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel, } else { // Ot

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-04-10 Thread via GitHub
mimaison commented on PR #18930: URL: https://github.com/apache/kafka/pull/18930#issuecomment-2785850006 The fact that @mjsax was not familiar with this feature kind of proves my point that it's missing documentation. I also get this impression working with users that either don't know abou

[jira] [Resolved] (KAFKA-19084) Port KAFKA-16224 for acknowledgements in ShareConsumers.

2025-04-10 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R resolved KAFKA-19084. -- Resolution: Fixed > Port KAFKA-16224 for acknowledgements in ShareConsumers. > ---

[jira] [Updated] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19096: Component/s: streams > Skipped Records in FK join should not be marked as dropped > --

[jira] [Created] (KAFKA-19102) Enhance the docs of group.coordinator.append.linger.ms

2025-04-10 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19102: -- Summary: Enhance the docs of group.coordinator.append.linger.ms Key: KAFKA-19102 URL: https://issues.apache.org/jira/browse/KAFKA-19102 Project: Kafka Is

[jira] [Resolved] (KAFKA-19093) Change the "Handler on Broker" to "Handler on Controller" for controller server

2025-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19093. Fix Version/s: 4.1.0 Resolution: Fixed > Change the "Handler on Broker" to "Handler

Re: [PR] KAFKA-15853: Move ShareCoordinatorConfig and GroupCoordinatorConfig out of KafkaConfig [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on code in PR #19409: URL: https://github.com/apache/kafka/pull/19409#discussion_r2033591815 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -194,16 +193,9 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private val _qu

[jira] [Commented] (KAFKA-17996) kafka-metadata-quorum.sh add-controller cause the new added controller to crash with java.lang.IllegalArgumentException

2025-04-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942111#comment-17942111 ] Luke Chen commented on KAFKA-17996: --- Removing fix version until it has progress. > ka

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2038525685 ## clients/src/test/java/org/apache/kafka/common/message/MessageTest.java: ## @@ -886,7 +888,6 @@ public void testProduceResponseVersions() throws Exception {

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2038525169 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -473,22 +473,7 @@ class BrokerServer( config.numIoThreads, s"${DataPlaneAcceptor.MetricPrefix}Re

Re: [PR] KAFKA-15371: MetadataShell is stuck when bootstrapping [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 commented on code in PR #19419: URL: https://github.com/apache/kafka/pull/19419#discussion_r2034729391 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -96,12 +96,16 @@ private void handleNextBatch() { return;

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2032806352 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new Simpl

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
TaiJuWu commented on PR #19286: URL: https://github.com/apache/kafka/pull/19286#issuecomment-2795354178 > Thanks for the PR! Can we also add an integration test? For example something like I'm doing in https://github.com/apache/kafka/pull/19050/files#diff-6ecc777f37395e25591a118f0eef88d602c

[jira] [Commented] (KAFKA-18216) High water mark or last stable offset aren't always updated after a fetch request is completed

2025-04-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941716#comment-17941716 ] Lianet Magrans commented on KAFKA-18216: Also, from a quick look this seems rela

[jira] [Commented] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2025-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941927#comment-17941927 ] Chia-Ping Tsai commented on KAFKA-15371: [~gongxuanzhang] will file a patch for

[jira] [Created] (KAFKA-19124) Calling unsubscribe() on the consumer leads always to a timeout

2025-04-10 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-19124: - Summary: Calling unsubscribe() on the consumer leads always to a timeout Key: KAFKA-19124 URL: https://issues.apache.org/jira/browse/KAFKA-19124 Project: Kafka

[jira] [Assigned] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2025-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-15371: -- Assignee: xuanzhang gong > MetadataShell is stuck when bootstrapping > --

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-10 Thread via GitHub
Rancho-7 commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2033113096 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -38,12 +34,6 @@ import java.util.function.Consumer; import jav

[jira] [Commented] (KAFKA-19103) Remove OffsetConfig

2025-04-10 Thread Bolin Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941676#comment-17941676 ] Bolin Lin commented on KAFKA-19103: --- + > Remove OffsetConfig > --- >

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-10 Thread via GitHub
mjsax commented on PR #19359: URL: https://github.com/apache/kafka/pull/19359#issuecomment-2784963186 > Also, according to KIP-1071, the request shutdown of the whole application should be available only if the member epoch is equal to leave epoch. Hence, should we check the flag in the str

Re: [PR] MINOR: Minor tidying in GroupMetadataManager [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield merged PR #19411: URL: https://github.com/apache/kafka/pull/19411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2038441012 ## server-common/src/main/java/org/apache/kafka/server/common/ShareVersion.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2038411412 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -85,6 +85,9 @@ abstract class AbstractApiVersionsRequestTest(cluster: ClusterInstan

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #19355: URL: https://github.com/apache/kafka/pull/19355#issuecomment-2791447052 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: remove transform and through from repartition description [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 commented on code in PR #19291: URL: https://github.com/apache/kafka/pull/19291#discussion_r2032431357 ## docs/streams/developer-guide/dsl-api.html: ## @@ -764,10 +764,10 @@ Manually trigger repartitioning of the stream with desired number of partitions. (details)

Re: [PR] Fix Patch: CVE-2023-25194 for Kafka 2.8.2 [kafka]

2025-04-10 Thread via GitHub
mimaison commented on PR #19412: URL: https://github.com/apache/kafka/pull/19412#issuecomment-2785801511 Thanks for the PR. We don't maintain the 2.8 branch anymore so we can't accept this change. If you are still using 2.8, you should really consider upgrading to a more recent and m

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2025-04-10 Thread via GitHub
TaiJuWu closed pull request #18358: MINOR: KAFKA-18280 follow up URL: https://github.com/apache/kafka/pull/18358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-10 Thread via GitHub
kirktrue commented on PR #19440: URL: https://github.com/apache/kafka/pull/19440#issuecomment-2795209075 @jolshan—would you be willing to add the CI label so I can run the full test suite? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Updated] (KAFKA-19125) Implement Large message reference-based Serializer

2025-04-10 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-19125: -- Issue Type: Improvement (was: Bug) > Implement Large message reference-based Serializer > ---

Re: [PR] [WIP] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2036681668 ## tools/src/test/java/org/apache/kafka/tools/ResetIntegrationTest.java: ## @@ -256,9 +255,8 @@ public void testResetWhenLongSessionTimeoutConfiguredWithForceOption

Re: [PR] KAFKA-1194: changes needed to run on Windows [kafka]

2025-04-10 Thread via GitHub
Andre-Silveira commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-2784098253 Any update on this in version 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032597713 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1947,13 +1947,27 @@ default ListShareGroupOffsetsResult listShareGroupOffsets(Map groupIds) {

Re: [PR] KAFKA-19098: Remove `lastOffset` from PartitionResponse [kafka]

2025-04-10 Thread via GitHub
chia7712 merged PR #19398: URL: https://github.com/apache/kafka/pull/19398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r2032610104 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteShareGroupOffsetsHandler.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Commented] (KAFKA-18287) Add support for kafka-streams-groups.sh --list

2025-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942411#comment-17942411 ] Alieh Saeedi commented on KAFKA-18287: -- https://github.com/apache/kafka/pull/19422

Re: [PR] KAFKA-18336: Improve jmh tests on ACL in AuthorizerBenchmark and StandardAuthorizerUpdateBenchmark [kafka]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #18293: URL: https://github.com/apache/kafka/pull/18293#issuecomment-2788181156 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [draft] KAFKA-19047: Allow quickly re-registering brokers that were shutdown [kafka]

2025-04-10 Thread via GitHub
ahuang98 commented on code in PR #19428: URL: https://github.com/apache/kafka/pull/19428#discussion_r2038346252 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1625,6 +1627,9 @@ ControllerResult processBrokerHeartbeat(

Re: [PR] [draft] KAFKA-19047: Allow quickly re-registering brokers that were shutdown [kafka]

2025-04-10 Thread via GitHub
ahuang98 commented on code in PR #19428: URL: https://github.com/apache/kafka/pull/19428#discussion_r2038346795 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -1074,35 +1074,37 @@ public void testDuplicateBrokerRegistrationWithInacti

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2038343739 ## storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java: ## @@ -0,0 +1,762 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2038343035 ## storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java: ## @@ -0,0 +1,770 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2038097007 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2339,80 +2357,90 @@ public void testBumpEpochWhenOutOfOrderSequenceReceived

Re: [PR] Fix Patch: CVE-2023-25194 for Kafka 2.8.2 [kafka]

2025-04-10 Thread via GitHub
mimaison closed pull request #19412: Fix Patch: CVE-2023-25194 for Kafka 2.8.2 URL: https://github.com/apache/kafka/pull/19412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-10 Thread via GitHub
Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2031577526 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new S

Re: [PR] KAFKA-18796-3: Increased the default acquisition lock timeout in SharePartition from 100ms to 2 seconds [kafka]

2025-04-10 Thread via GitHub
adixitconfluent commented on PR #19405: URL: https://github.com/apache/kafka/pull/19405#issuecomment-2783703417 @chirag-wadhwa5, I think it would be a good exercise to know the time it is taking for the rest of the code to execute. I don't think the rest of the code + time to expire the log

[jira] [Created] (KAFKA-19113) Migrate DelegationTokenManager to server module

2025-04-10 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-19113: - Summary: Migrate DelegationTokenManager to server module Key: KAFKA-19113 URL: https://issues.apache.org/jira/browse/KAFKA-19113 Project: Kafka Issue Type: Sub-tas

Re: [PR] KAFKA-15371: MetadataShell is stuck when bootstrapping [kafka]

2025-04-10 Thread via GitHub
gongxuanzhang commented on code in PR #19419: URL: https://github.com/apache/kafka/pull/19419#discussion_r2034737159 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -96,12 +96,16 @@ private void handleNextBatch() { return;

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-10 Thread via GitHub
lucasbru commented on PR #19359: URL: https://github.com/apache/kafka/pull/19359#issuecomment-2782759530 > @lucasbru Out of curiosity, it seems the soft-state flag is used to add more logs on both client-side and server-side. Is that expected? Yes. There was logging associated with th

Re: [PR] MINOR: use enum map for error counts map [kafka]

2025-04-10 Thread via GitHub
chia7712 merged PR #19314: URL: https://github.com/apache/kafka/pull/19314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-04-10 Thread via GitHub
showuon commented on PR #19213: URL: https://github.com/apache/kafka/pull/19213#issuecomment-2788583098 @AndrewJSchofield @apoorvmittal10 , do you think we should backport this patch to 3.9.1 release? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-18723) KRaft must handle corrupted records in the fetch response

2025-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18723: --- Fix Version/s: 4.1.0 > KRaft must handle corrupted records in the fetch response > -

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-10 Thread via GitHub
johnny94 commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2034591540 ## docker/README.md: ## @@ -31,7 +31,7 @@ Building image and running tests using github actions - image-type - This is the type of image that we intend to build. Th

[jira] [Created] (KAFKA-19118) Enable KIP-1071 in existing streams integration tests

2025-04-10 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19118: -- Summary: Enable KIP-1071 in existing streams integration tests Key: KAFKA-19118 URL: https://issues.apache.org/jira/browse/KAFKA-19118 Project: Kafka Iss

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-04-10 Thread via GitHub
mjsax commented on PR #18930: URL: https://github.com/apache/kafka/pull/18930#issuecomment-2784988335 Thanks for the background info. > Now looking at this again, I wonder if documenting it this way helps or hurts. Yes the configuration is always present, but No the configuration may

[jira] [Commented] (KAFKA-19116) Deletion of share group offsets does not reset the position as expected

2025-04-10 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942160#comment-17942160 ] Andrew Schofield commented on KAFKA-19116: -- The same problem occurs with deleti

Re: [PR] KAFKA-19118: Enable KIP-1071 in StandbyTaskCreationIntegrationTest [kafka]

2025-04-10 Thread via GitHub
bbejeck commented on code in PR #19438: URL: https://github.com/apache/kafka/pull/19438#discussion_r2038214625 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/ChangelogTopicsTest.java: ## @@ -149,14 +149,14 @@ public void shouldContainNonSour

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
bbejeck commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2038207878 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -180,6 +186,25 @@ public class AsyncKafkaConsumer implements Consum

[jira] [Commented] (KAFKA-19097) Fix order of arguments to assertEquals

2025-04-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941661#comment-17941661 ] Matthias J. Sax commented on KAFKA-19097: - There is actually many tests with thi

[jira] [Created] (KAFKA-19107) MirrorMaker2 repeatedly tries to sync group offsets for partitions that no longer exist

2025-04-10 Thread Alex Rovner (Jira)
Alex Rovner created KAFKA-19107: --- Summary: MirrorMaker2 repeatedly tries to sync group offsets for partitions that no longer exist Key: KAFKA-19107 URL: https://issues.apache.org/jira/browse/KAFKA-19107

Re: [PR] KAFKA-18629: Utilize share group partition metadata for delete group. [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield merged PR #19363: URL: https://github.com/apache/kafka/pull/19363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Commented] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942229#comment-17942229 ] PoAn Yang commented on KAFKA-19110: --- [~cadonna] Thank you. If this's not urgent, I can

Re: [PR] KAFKA-15143: Adding in MockFixedKeyProcessorContext and Test [kafka]

2025-04-10 Thread via GitHub
mjsax commented on PR #14605: URL: https://github.com/apache/kafka/pull/14605#issuecomment-2785011990 @javad87 -- We got a KIP proposed for this change, but the KIP was not accepted yet, and there was not progress for many months. If you have interest to contribute, it would be great

[jira] [Resolved] (KAFKA-18892) Add support for ClientQuotaCallback

2025-04-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18892. Fix Version/s: 4.1.0 Resolution: Fixed > Add support for ClientQuotaCallback >

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-10 Thread via GitHub
stanislavkozlovski commented on PR #19336: URL: https://github.com/apache/kafka/pull/19336#issuecomment-2782427104 @kamalcph @satishd @showuon can i mereg this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2038119258 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -85,6 +85,9 @@ abstract class AbstractApiVersionsRequestTest(cluster: Clu

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna merged PR #19421: URL: https://github.com/apache/kafka/pull/19421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-19126) Duplicate offsets written to log for different messages

2025-04-10 Thread Adrian C. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian C. updated KAFKA-19126: -- Description: We have observed during normal operations that messages/batches can be written to disk w

[PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-10 Thread via GitHub
kirktrue opened a new pull request, #19440: URL: https://github.com/apache/kafka/pull/19440 Introduces a concrete subclass of `KafkaThread` named `SenderThread`. The poisoning of the TransactionManager on invalid state changes is determined by looking at the type of the current thread.

[jira] [Updated] (KAFKA-15767) Refactor TransactionManager to avoid use of ThreadLocal

2025-04-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15767: -- Summary: Refactor TransactionManager to avoid use of ThreadLocal (was: Redesign TransactionManager to

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2037984758 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -85,6 +85,9 @@ abstract class AbstractApiVersionsRequestTest(cluster: ClusterInstan

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2032560885 ## storage/src/main/java/org/apache/kafka/storage/internals/log/CleanedTransactionMetadata.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-10 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2031382775 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2032049630 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -108,7 +108,7 @@ class KafkaApis(val requestChannel: RequestChannel, val groupConfigManager:

Re: [PR] [WIP]KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-10 Thread via GitHub
junrao commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2787910437 @m1a2st : Perhaps we could somehow allow the tests to set a small `segment.bytes`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2034777548 ## storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java: ## @@ -0,0 +1,762 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Created] (KAFKA-19111) Remove ModernGroup#computeSubscriptionMetadata unused parameter

2025-04-10 Thread Jira
黃竣陽 created KAFKA-19111: --- Summary: Remove ModernGroup#computeSubscriptionMetadata unused parameter Key: KAFKA-19111 URL: https://issues.apache.org/jira/browse/KAFKA-19111 Project: Kafka Issue Type: Im

[jira] [Created] (KAFKA-19117) Client Throttling Log messages should be of log level - WARN

2025-04-10 Thread Ravi Kalasapur (Jira)
Ravi Kalasapur created KAFKA-19117: -- Summary: Client Throttling Log messages should be of log level - WARN Key: KAFKA-19117 URL: https://issues.apache.org/jira/browse/KAFKA-19117 Project: Kafka

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037973763 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2032855809 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity o

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2035281152 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -390,57 +390,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-10 Thread via GitHub
m1a2st commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2033053426 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java: ## @@ -269,18 +270,19 @@ List configProviders() { Map transform(Map props) {

  1   2   >