apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037973763
########## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ########## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknowledgeResponse", - "validVersions": "0", + // Version 0 was used for early access of KIP-932 in Apache Kafka 4.0 but removed in Apacke Kafka 4.1. + // + // Version 1 is the initial stable version (KIP-932). + "validVersions": "1", "flexibleVersions": "0+", Review Comment: The code I pointed actually checks if field within the request has flexibleVersions then it should be within validVersions. Though it seems stange that why the same check do not exists for toplevel flexibleVersions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
