smjn commented on code in PR #18976:
URL: https://github.com/apache/kafka/pull/18976#discussion_r2032597713
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1947,13 +1947,27 @@ default ListShareGroupOffsetsResult
listShareGroupOffsets(Map<String, ListShareG
}
/**
- * Delete share groups from the cluster with the default options.
+ * Delete offsets for a set of partitions in a share group.
*
- * @param groupIds Collection of share group ids which are to be deleted.
- * @return The DeleteShareGroupsResult.
+ * @param groupId The group for which to delete offsets.
+ * @param partitions The topic-partitions.
+ * @param options The options to use when deleting offsets in a share
group.
+ * @return The DeleteShareGroupOffsetsResult.
*/
- default DeleteShareGroupsResult deleteShareGroups(Collection<String>
groupIds) {
- return deleteShareGroups(groupIds, new DeleteShareGroupsOptions());
+ DeleteShareGroupOffsetsResult deleteShareGroupOffsets(String groupId,
Set<TopicPartition> partitions, DeleteShareGroupOffsetsOptions options);
+
+ /**
+ * Delete offsets for a set of partitions in a share group with the
default options.
+ *
+ * <p>This is a convenience method for {@link
#deleteShareGroupOffsets(String, Set, DeleteShareGroupOffsetsOptions)} with
default options.
Review Comment:
nit: `<p>` is usually on a new line
```
lorem ...
<p>
lorem
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
