FrankYang0529 commented on code in PR #19419:
URL: https://github.com/apache/kafka/pull/19419#discussion_r2034729391
##########
metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java:
##########
@@ -96,12 +96,16 @@ private void handleNextBatch() {
return;
}
FileChannelRecordBatch batch = batchIterator.next();
+ lastOffset = batch.lastOffset();
+ if (!batchIterator.hasNext()) {
+ // Expose the high watermark only once we've shut down.
Review Comment:
This comment may not be correct since it's not in ShutdownEvent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
