mjsax commented on PR #18930: URL: https://github.com/apache/kafka/pull/18930#issuecomment-2784988335
Thanks for the background info. > Now looking at this again, I wonder if documenting it this way helps or hurts. Yes the configuration is always present, but No the configuration may not always be relevant to each of these components and documenting it may be noisy. Not sure if I can follow? Yes, the ticket is about documenting that this config exists, and adding it to the corresponding config classes will achieve this. But I don't see why it could hurt? > but No the configuration may not always be relevant to each of these components and documenting it may be noisy. Why do you mean by "may not always be relevant"? However, even if it does not hurt, I am wondering if it's important enough to add? It seems there is a few `CommonConfigs` that are not in all "config classes" (ie, `ConsumerConfigs`, etc) -- So I would rather question if the Jira ticket to document this better is actually required to begin with? @mimaison What was the motivation for the ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
