jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2038530717
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Otherwise, the regular appendRecords path is used for all the
non __consumer_offsets
// partitions or for all partitions when the new group coordinator
is disabled.
- controlRecords += partition ->
MemoryRecords.withEndTransactionMarker(
+ controlRecords += replicaManager.topicIdPartition(partition) ->
MemoryRecords.withEndTransactionMarker(
Review Comment:
For internal appends, we should always be able to use topic ID though right?
It's ok to fall back to topic name behavior, but just wanted to point this out.
(In theory I guess the WriteTxnMarkers api could pass topic IDs, but then we
would have to store topic IDs in the txn manager 😁 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
