TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2038525169
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -473,22 +473,7 @@ class BrokerServer(
config.numIoThreads,
s"${DataPlaneAcceptor.MetricPrefix}RequestHandlerAvgIdlePercent",
DataPlaneAcceptor.ThreadPrefix)
- // Start RemoteLogManager before initializing broker metadata publishers.
- remoteLogManagerOpt.foreach { rlm =>
- val listenerName =
config.remoteLogManagerConfig.remoteLogMetadataManagerListenerName()
- if (listenerName != null) {
- val endpoint = listenerInfo.listeners().values().stream
- .filter(e =>
- e.listenerName().isPresent &&
-
ListenerName.normalised(e.listenerName().get()).equals(ListenerName.normalised(listenerName))
- )
- .findFirst()
- .orElseThrow(() => new
ConfigException(RemoteLogManagerConfig.REMOTE_LOG_METADATA_MANAGER_LISTENER_NAME_PROP,
- listenerName, "Should be set as a listener name within valid
broker listener name list: " + listenerInfo.listeners().values()))
- rlm.onEndPointCreated(endpoint)
- }
- rlm.startup()
- }
+
Review Comment:
Fixed, thanks.
##########
server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java:
##########
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server;
+
+import org.apache.kafka.common.MetricName;
+import org.apache.kafka.common.metrics.Measurable;
+import org.apache.kafka.common.metrics.Metrics;
+import org.apache.kafka.common.metrics.Monitorable;
+import org.apache.kafka.common.metrics.PluginMetrics;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.server.log.remote.storage.NoOpRemoteLogMetadataManager;
+import org.apache.kafka.server.log.remote.storage.NoOpRemoteStorageManager;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import static
org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_LOG_METADATA_MANAGER_CLASS_NAME_PROP;
+import static
org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP;
+import static
org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CLASS_NAME_PROP;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class MonitorablePluginsIntegrationTest {
+
+ private static int controllerId(Type type) {
+ return type == Type.KRAFT ? 3000 : 0;
+ }
+
+ private static Map<String, String> expectedTags(String config, String
clazz) {
+ return expectedTags(config, clazz, Map.of());
+ }
+
+ private static Map<String, String> expectedTags(String config, String
clazz, Map<String, String> extraTags) {
+ Map<String, String> tags = new LinkedHashMap<>();
+ tags.put("config", config);
+ tags.put("class", clazz);
+ tags.putAll(extraTags);
+ return tags;
+ }
+
+ @ClusterTest(
+ types = {Type.KRAFT, Type.CO_KRAFT},
Review Comment:
Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
