ijuma commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976211371
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions
[
https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931623#comment-17931623
]
Chia-Ping Tsai commented on KAFKA-18477:
{quote}
since we only have V2 message
TaiJuWu closed pull request #19064: KAFKA-18893: KIP-877 Add support for
ReplicaSelector
URL: https://github.com/apache/kafka/pull/19064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
TaiJuWu opened a new pull request, #19064:
URL: https://github.com/apache/kafka/pull/19064
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some comm
chia7712 commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1976317444
##
.github/workflows/build.yml:
##
@@ -127,6 +127,8 @@ jobs:
gradle-cache-read-only: ${{ !inputs.is-trunk }}
gradle-cache-write-only: ${{ inputs.
chia7712 commented on code in PR #18926:
URL: https://github.com/apache/kafka/pull/18926#discussion_r1976306426
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -4641,15 +4533,15 @@ public void
testHandleLeaderChangeFiresAfterResignRegistration(boolea
chia7712 commented on code in PR #19063:
URL: https://github.com/apache/kafka/pull/19063#discussion_r1976277903
##
core/src/test/java/kafka/server/BootstrapControllersIntegrationTest.java:
##
@@ -228,6 +228,17 @@ public void testIncrementalAlterConfigs(ClusterInstance
clusterIn
frankvicky opened a new pull request, #19063:
URL: https://github.com/apache/kafka/pull/19063
JIRA: KAFKA-17039
This patch makes the controller able to handle `UnregisterBrokerRequest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1976004288
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -945,9 +987,13 @@ boolean allReachedHighWatermark(long offset) {
.allM
chia7712 commented on code in PR #18662:
URL: https://github.com/apache/kafka/pull/18662#discussion_r1976248738
##
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
mingyen066 opened a new pull request, #19062:
URL: https://github.com/apache/kafka/pull/19062
Migrate the following data carrier class to records to eliminate
constructors, equals, hashCode, and toString.
* `final class Entry` in `LogHistory.java`
* `public final class SnapshotPath`
frankvicky commented on code in PR #18402:
URL: https://github.com/apache/kafka/pull/18402#discussion_r1976255333
##
streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java:
##
@@ -221,7 +221,7 @@ public long size() {
* @return this updated builder
*
github-actions[bot] commented on PR #18489:
URL: https://github.com/apache/kafka/pull/18489#issuecomment-2691891338
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
chia7712 commented on code in PR #18662:
URL: https://github.com/apache/kafka/pull/18662#discussion_r1976249061
##
test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/README.md:
##
@@ -104,7 +104,7 @@ For each generated invocation:
* Non-static `
github-actions[bot] commented on PR #18994:
URL: https://github.com/apache/kafka/pull/18994#issuecomment-2691891254
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
chia7712 merged PR #19025:
URL: https://github.com/apache/kafka/pull/19025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
github-actions[bot] commented on PR #18993:
URL: https://github.com/apache/kafka/pull/18993#issuecomment-2691891270
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
chia7712 commented on code in PR #18770:
URL: https://github.com/apache/kafka/pull/18770#discussion_r1976251415
##
README.md:
##
@@ -42,7 +42,6 @@ Follow instructions in https://kafka.apache.org/quickstart
./gradlew test # runs both unit and integration tests
./gradle
junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976015748
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "version
FrankYang0529 commented on PR #18945:
URL: https://github.com/apache/kafka/pull/18945#issuecomment-2691860399
Sorry for that. I only checked test can pass yesterday. Fixed style error.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
ijuma commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976211222
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions
[
https://issues.apache.org/jira/browse/KAFKA-18904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931601#comment-17931601
]
PoAn Yang commented on KAFKA-18904:
---
Hi [~schofielaj], if you're not working on this,
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1976010924
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -117,40 +125,101 @@ public class RaftEventSimulationTest {
void canElectInitialL
kirktrue commented on code in PR #19056:
URL: https://github.com/apache/kafka/pull/19056#discussion_r1975850054
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java:
##
@@ -27,6 +27,8 @@
* A key/value pair to be received from Kafka. This also consists
[
https://issues.apache.org/jira/browse/KAFKA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung reassigned KAFKA-18903:
--
Assignee: Ming-Yen Chung
> Use curl + jq in update-cache.sh
> ---
junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976209643
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "version
ijuma commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976186661
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1976012893
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -580,6 +576,30 @@ void canRecoverFromSingleNodeCommittedDataLoss(
scheduler.
[
https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anil Dasari resolved KAFKA-18669.
-
Resolution: Done
> Connector is restarted before it is started
> ---
junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976167164
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "version
chia7712 commented on code in PR #19056:
URL: https://github.com/apache/kafka/pull/19056#discussion_r1976092524
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java:
##
@@ -27,6 +27,8 @@
* A key/value pair to be received from Kafka. This also consists
mumrah commented on code in PR #18662:
URL: https://github.com/apache/kafka/pull/18662#discussion_r1975497268
##
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache So
chia7712 commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976088168
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versi
[
https://issues.apache.org/jira/browse/KAFKA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931584#comment-17931584
]
Chia-Ping Tsai commented on KAFKA-18876:
Sure, we can fix it in the next few day
junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976078647
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "version
junrao merged PR #19036:
URL: https://github.com/apache/kafka/pull/19036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-18864.
-
Fix Version/s: 4.1.0
Resolution: Fixed
> remove the Evolving tag from stable public interfaces
>
junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976015748
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "version
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1976011663
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -117,40 +125,101 @@ public class RaftEventSimulationTest {
void canElectInitialL
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1976005044
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -580,6 +576,30 @@ void canRecoverFromSingleNodeCommittedDataLoss(
scheduler.ru
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1975971708
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -117,40 +125,101 @@ public class RaftEventSimulationTest {
void canElectInitialLea
[
https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18905:
--
Component/s: clients
> Avoid out of order sequence errors from multiple in-flight batches
> --
[
https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Quah updated KAFKA-18905:
--
Description:
Consider a similar setup to KAFKA-9199:
The broker attempts to cache the state of the la
[
https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Quah updated KAFKA-18905:
--
Description:
Consider a similar setup to KAFKA-9199:
The broker attempts to cache the state of the la
Sean Quah created KAFKA-18905:
-
Summary: Avoid out of order sequence errors from multiple
in-flight batches
Key: KAFKA-18905
URL: https://issues.apache.org/jira/browse/KAFKA-18905
Project: Kafka
LoganZhuZzz opened a new pull request, #19056:
URL: https://github.com/apache/kafka/pull/19056
Due to concurrent issues encountered with ConsumerRecord's headers, it is
necessary to add documentation to remind users.
--
This is an automated message from the Apache Git Service.
To resp
AndrewJSchofield commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2691225538
> @AndrewJSchofield: DeleteGroupsResult wasn't included as part of the
public interface in the original KIP. Do you think that it makes sense to
include it in the public interfac
lianetm commented on PR #18945:
URL: https://github.com/apache/kafka/pull/18945#issuecomment-2691120474
Thanks for the updates @FrankYang0529 ! Could you check the style failures
pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
AndrewJSchofield commented on code in PR #19055:
URL: https://github.com/apache/kafka/pull/19055#discussion_r1975724557
##
clients/src/main/java/org/apache/kafka/common/requests/ShareGroupHeartbeatResponse.java:
##
@@ -35,6 +35,7 @@
* - {@link Errors#INVALID_REQUEST}
* - {@l
Andrew Schofield created KAFKA-18904:
Summary: Listing of configs for dynamically created resources is
mysterious
Key: KAFKA-18904
URL: https://issues.apache.org/jira/browse/KAFKA-18904
Project: K
AndrewJSchofield commented on code in PR #17264:
URL: https://github.com/apache/kafka/pull/17264#discussion_r1975678964
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdmi
AndrewJSchofield commented on code in PR #17264:
URL: https://github.com/apache/kafka/pull/17264#discussion_r1975679794
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdmi
David Arthur created KAFKA-18903:
Summary: Use curl + jq in update-cache.sh
Key: KAFKA-18903
URL: https://issues.apache.org/jira/browse/KAFKA-18903
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-18734.
---
Resolution: Fixed
> Implement share partition metrics for share fetch
>
frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1975624999
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java:
##
@@ -198,7 +199,7 @@ public void requestRejoin() {
}
AndrewJSchofield opened a new pull request, #19060:
URL: https://github.com/apache/kafka/pull/19060
Previously, the ShareConsumer.commitAsync method retried sending
ShareAcknowledge requests
indefinitely. There was no good reason for this. This change adopts the
usual Kafka practice of u
[
https://issues.apache.org/jira/browse/KAFKA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-18903:
-
Component/s: build
> Use curl + jq in update-cache.sh
>
>
>
mumrah commented on code in PR #18449:
URL: https://github.com/apache/kafka/pull/18449#discussion_r1975617598
##
.github/workflows/README.md:
##
@@ -133,4 +133,47 @@ Composite actions are a convenient way to reuse build
logic, but they have
some limitations.
- Cannot run m
[
https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-18734:
--
Affects Version/s: 4.1.0
(was: 4.1)
> Implement share partition met
m1a2st commented on code in PR #19046:
URL: https://github.com/apache/kafka/pull/19046#discussion_r1975600010
##
core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
apoorvmittal10 opened a new pull request, #19059:
URL: https://github.com/apache/kafka/pull/19059
The PR implements the ShareSessionCache and DelayedShareFetchMetrics as
defined in KIP-1103.
https://github.com/user-attachments/assets/81578d64-51b6-4228-972a-ce76a43a97d6";
/>
https
EsMoX commented on PR #19041:
URL: https://github.com/apache/kafka/pull/19041#issuecomment-2690914753
> Thanks for the PR. Seems there is some confusion about this test...
>
> First, the test was added like this 2 year ago and never modified. So it
was missed on the original PR review
[
https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-18734:
--
Affects Version/s: 4.1
> Implement share partition metrics for share fetch
> -
[
https://issues.apache.org/jira/browse/KAFKA-17894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-17894:
--
Affects Version/s: 4.1.0
> Additional metrics for cooperative consumption
> --
[
https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931481#comment-17931481
]
David Arthur commented on KAFKA-18898:
--
I was looking at [https://kafka.apache.org/
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung updated KAFKA-18700:
---
Summary: Migrate suitable classes to records in raft (was: Migrate
suitable classes to reco
frankvicky commented on code in PR #19054:
URL: https://github.com/apache/kafka/pull/19054#discussion_r1975528720
##
core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala:
##
@@ -96,12 +97,9 @@ object TransactionLog {
val version = buffer.getShort
if (
clarkwtc commented on code in PR #19046:
URL: https://github.com/apache/kafka/pull/19046#discussion_r1975509750
##
core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mumrah commented on code in PR #18662:
URL: https://github.com/apache/kafka/pull/18662#discussion_r1975512220
##
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache So
[
https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931486#comment-17931486
]
Ismael Juma commented on KAFKA-18898:
-
No.
> 4.0 Upgrade docs rendering below other
clarkwtc commented on code in PR #19046:
URL: https://github.com/apache/kafka/pull/19046#discussion_r1975509750
##
core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
clarkwtc commented on code in PR #19046:
URL: https://github.com/apache/kafka/pull/19046#discussion_r1975509750
##
core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
AndrewJSchofield merged PR #19045:
URL: https://github.com/apache/kafka/pull/19045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung updated KAFKA-18700:
---
Description:
raft:
Entry
SnapshotPath
was:
raft:
Entry
SnapshotPath
> Migrate suitab
FrankYang0529 opened a new pull request, #19058:
URL: https://github.com/apache/kafka/pull/19058
In https://github.com/apache/kafka/pull/16848, we added `kraft.version` to
finalized features and got finalized features outside controller event handling
thread. This may make finalized feature
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung updated KAFKA-18700:
---
Description:
raft:
Entry
SnapshotPath
was:
raft:
Entry
SnapshotPath
connector-common:
Andrew Schofield created KAFKA-18902:
Summary: Experiment with ShareConsumer option to throw on poll if
there are unacked records
Key: KAFKA-18902
URL: https://issues.apache.org/jira/browse/KAFKA-18902
Andrew Schofield created KAFKA-18901:
Summary: Improve redistribution of share group SimpleAssignor
Key: KAFKA-18901
URL: https://issues.apache.org/jira/browse/KAFKA-18901
Project: Kafka
FrankYang0529 commented on PR #18997:
URL: https://github.com/apache/kafka/pull/18997#issuecomment-2690675552
3.9 PR: https://github.com/apache/kafka/pull/19058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Andrew Schofield created KAFKA-18900:
Summary: Create a consumer config to select between implicit and
explicit acknowledgement
Key: KAFKA-18900
URL: https://issues.apache.org/jira/browse/KAFKA-18900
Andrew Schofield created KAFKA-18899:
Summary: Limit retry time for ShareConsumer.commitAsync
Key: KAFKA-18899
URL: https://issues.apache.org/jira/browse/KAFKA-18899
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-18522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-18522.
---
Fix Version/s: 4.1.0
Resolution: Fixed
The first PR is merged and for MemoryRecords w
FrankYang0529 commented on code in PR #18945:
URL: https://github.com/apache/kafka/pull/18945#discussion_r1975413906
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/BaseHeartbeatThread.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundat
frankvicky commented on code in PR #19056:
URL: https://github.com/apache/kafka/pull/19056#discussion_r1975394152
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java:
##
@@ -27,6 +27,8 @@
* A key/value pair to be received from Kafka. This also consis
ijuma commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2690601588
I don't think we should do this change for the reason @AndrewJSchofield
mentioned. Parent classes of public classes need themselves to be public.
--
This is an automated message from the
apoorvmittal10 commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975371781
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -313,6 +320,21 @@ public static RecordState forId(byte id) {
*/
private ShareParti
apoorvmittal10 commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975371781
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -313,6 +320,21 @@ public static RecordState forId(byte id) {
*/
private ShareParti
AndrewJSchofield commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2690555953
@junrao Is this better? It seems to me that we now have two public classes
inheriting from a class in the internals package. Would you prefer that we
remove the inheritance and j
AndrewJSchofield commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975345141
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -313,6 +320,21 @@ public static RecordState forId(byte id) {
*/
private SharePar
apoorvmittal10 commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975320265
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1326,6 +1355,56 @@ int leaderEpoch() {
return leaderEpoch;
}
+/**
+
Rancho-7 commented on code in PR #18966:
URL: https://github.com/apache/kafka/pull/18966#discussion_r1974984330
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegra
ShivsundarR commented on code in PR #19055:
URL: https://github.com/apache/kafka/pull/19055#discussion_r1975285732
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManagerTest.java:
##
@@ -402,6 +402,12 @@ public void testHeartbeatRespons
smjn commented on code in PR #18928:
URL: https://github.com/apache/kafka/pull/18928#discussion_r1975196948
##
clients/src/main/java/org/apache/kafka/clients/admin/DeleteGroupsResult.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931432#comment-17931432
]
Sushant Mahajan commented on KAFKA-16719:
-
https://github.com/apache/kafka/pull/
dengziming commented on code in PR #9766:
URL: https://github.com/apache/kafka/pull/9766#discussion_r1975048781
##
clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java:
##
@@ -95,32 +71,28 @@ public int hashCode() {
private static void ensureTran
AndrewJSchofield commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975119796
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1326,6 +1355,56 @@ int leaderEpoch() {
return leaderEpoch;
}
+/**
+
loicgreffier commented on PR #18739:
URL: https://github.com/apache/kafka/pull/18739#issuecomment-2690152803
@cadonna Agree to introduce a new parameter.
I'm wondering if the concern is the same for store caches. Should the
parameter applies to store caches as well (`CachingKeyValueS
AndrewJSchofield merged PR #19053:
URL: https://github.com/apache/kafka/pull/19053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
Rancho-7 commented on code in PR #18966:
URL: https://github.com/apache/kafka/pull/18966#discussion_r1974984330
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegra
[
https://issues.apache.org/jira/browse/KAFKA-18657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-18657.
--
Fix Version/s: 4.1.0
Resolution: Fixed
> Flaky SharePartitionManagerTest
>
1 - 100 of 104 matches
Mail list logo
