ijuma commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976211222
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions": "11+",
"default": "-1", "ignorable": false, "entityType": "brokerId",
"about": "The preferred read replica for the consumer to use on its
next fetch request."},
- { "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data."}
Review Comment:
Hmm, we did not set that precedent here though, I did update KIP-896 and
noted it in the discussion thread:
> Finally, we will fix a protocol specification inconsistency: FetchResponse
has a records field that is tagged as nullable even though it is always
non-null and all librdkafka-based clients (which cover a large percentage of
clients in the wild) break if this field is set to null . We adjust the spec to
match reality - this way implementors do not have to find out about this
requirement during testing with real clients. This small change is not strictly
related to this KIP, but it was found during the testing phase of this KIP and
hence we included it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
