frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1975624999
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java:
##########
@@ -198,7 +199,7 @@ public void requestRejoin() {
}
public void maybeLeaveGroup(String leaveReason) {
- coordinator.maybeLeaveGroup(leaveReason);
+
coordinator.maybeLeaveGroup(CloseOptions.GroupMembershipOperation.DEFAULT,
leaveReason);
Review Comment:
IMHO, we could use `DEFAULT` or `LEAVE_GROUP` here.
IIUC, connect doesn't have the static membership consumer. At least I don't
find the code snippet about it.
Considering the comments and code readability, using `LEAVE_GROUP` would
indeed be more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
