ShivsundarR commented on code in PR #19055:
URL: https://github.com/apache/kafka/pull/19055#discussion_r1975285732
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManagerTest.java:
##########
@@ -402,6 +402,12 @@ public void testHeartbeatResponseOnErrorHandling(final
Errors error, final boole
assertNextHeartbeatTiming(0);
break;
+ case TOPIC_AUTHORIZATION_FAILED:
+ verify(backgroundEventHandler).add(any(ErrorEvent.class));
+ assertNextHeartbeatTiming(DEFAULT_RETRY_BACKOFF_MS);
+ verify(membershipManager, never()).transitionToFatal();
+ break;
Review Comment:
This change was introduced in `AbstractHeartbeatRequestManager` and had a
similar test in `ConsumerHeartbeatRequestManagerTest`. There is a
JIRA(https://issues.apache.org/jira/browse/KAFKA-18862) to decide if we should
duplicate the changes to this test as well.
Maybe we can avoid the change here as the test is probably going to be
removed, but I do not mind it being there as well before that JIRA is addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
