frankvicky commented on code in PR #18402:
URL: https://github.com/apache/kafka/pull/18402#discussion_r1976255333
##########
streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java:
##########
@@ -221,7 +221,7 @@ public long size() {
* @return this updated builder
* @throws IllegalArgumentException if the {@code afterWindowEnd} is
negative or can't be represented as {@code long milliseconds}
* @throws IllegalStateException if {@link #grace(Duration)} is called
after {@link #ofTimeDifferenceAndGrace(Duration, Duration)} or {@link
#ofTimeDifferenceWithNoGrace(Duration)}
- * @deprecated since 3.0. Use {@link #ofTimeDifferenceAndGrace(Duration,
Duration)} instead
+ * @deprecated Since 3.0. Use {@link #ofTimeDifferenceAndGrace(Duration,
Duration)} instead.
Review Comment:
Hi @mjsax
I notice that this has been deprecated since 3.0 which is passed one year
since it was deprecated.
Do we need to delete this one in 4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
