apoorvmittal10 commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975371781
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -313,6 +320,21 @@ public static RecordState forId(byte id) {
*/
private SharePartitionState partitionState;
+ /**
+ * The fetch lock acquired time is used to track the time when the lock
for share partition is acquired.
+ */
+ private long fetchLockAcquiredTimeMs;
Review Comment:
I am trying to follow how other time and metrics are defined, and can see
they have `Ms` in end to specify it's milliseconds, for example:
https://github.com/apache/kafka/blob/8b605bd3620268214a85c8a520cad22dec815358/clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/KafkaConsumerMetrics.java#L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
