AndrewJSchofield commented on PR #19057: URL: https://github.com/apache/kafka/pull/19057#issuecomment-2691225538
> @AndrewJSchofield: DeleteGroupsResult wasn't included as part of the public interface in the original KIP. Do you think that it makes sense to include it in the public interface? To be honest, I think this area is ripe for a bit of rationalisation, not just in terms of these classes. We probably ought to have `Admin.deleteGroups(DeleteGroupsOptions)` to go alongside `Admin.listGroups(ListGroupsOptions)`, rather than a proliferation of `Admin.deleteXXXGroups` methods. Then you could specify a group type optionally with the deletion operation, and `Admin.deleteShareGroups()` would be removed and `Admin.deleteConsumerGroups()` would be deprecated. I wish I'd realised when I did KIP-1043. I will discuss with @dajac because I'd like to get him on board before proposing a change like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
