[GitHub] [solr] tboeghk commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-06-02 Thread GitBox
tboeghk commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-853617796 I came across an edge case that I want to consider: In the distributed environment we should only ignore the `appends` section if we do not change the handler during the distributed

[GitHub] [solr] tboeghk commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-06-02 Thread GitBox
tboeghk commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-853605016 Whoopsie, my bad, ran the `gradlew check` with `-Pvalidation.git.failOnModified=false`. Added license header in the last commit -- This is an automated message from the Apache Git

[jira] [Created] (SOLR-15452) TracingUpdateProcessor for distributed tracing

2021-06-02 Thread David Smiley (Jira)
David Smiley created SOLR-15452: --- Summary: TracingUpdateProcessor for distributed tracing Key: SOLR-15452 URL: https://issues.apache.org/jira/browse/SOLR-15452 Project: Solr Issue Type: Improve

[GitHub] [solr] noblepaul opened a new pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-06-02 Thread GitBox
noblepaul opened a new pull request #160: URL: https://github.com/apache/solr/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[jira] [Commented] (SOLR-15337) Avoid XPath in solrconfig.xml parsing

2021-06-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356135#comment-17356135 ] Noble Paul commented on SOLR-15337: --- It is in 8.9 and the lucene-solr repo has it. The

[GitHub] [solr] MarcusSorealheis commented on a change in pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-06-02 Thread GitBox
MarcusSorealheis commented on a change in pull request #42: URL: https://github.com/apache/solr/pull/42#discussion_r644427250 ## File path: solr/webapp/web/js/angular/app.js ## @@ -430,7 +436,11 @@ solrAdminApp.config([ $location.path('/login'); } } else {

[GitHub] [solr] MarcusSorealheis edited a comment on pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-06-02 Thread GitBox
MarcusSorealheis edited a comment on pull request #42: URL: https://github.com/apache/solr/pull/42#issuecomment-853527455 there's also a few security exceptions that if thrown in the wrong corporate org could start problematic conversations running SOLR. Everything is under scrutiny right

[GitHub] [solr] MarcusSorealheis commented on pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-06-02 Thread GitBox
MarcusSorealheis commented on pull request #42: URL: https://github.com/apache/solr/pull/42#issuecomment-853527455 there's also a few security exceptions that if thrown in the wrong corporate org could start problematic conversations running SOLR. Everything is under scrutiny right now giv

[GitHub] [solr] MarcusSorealheis commented on pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-06-02 Thread GitBox
MarcusSorealheis commented on pull request #42: URL: https://github.com/apache/solr/pull/42#issuecomment-853507516 Schema Designer should not simply throw generic errors that do no help the user. For instance, when a user tries to create a field that already exists, there is just an error

[GitHub] [solr] magibney commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
magibney commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644435044 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -415,19 +415,7 @@ public void testFocusQueryParser() { asser

[jira] [Commented] (SOLR-11646) Ref Guide: Update API examples to include v2 style examples

2021-06-02 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356066#comment-17356066 ] David Eric Pugh commented on SOLR-11646: okay, schema-api.adoc is done!  > Ref G

[GitHub] [solr] epugh commented on pull request #91: SOLR-11646: v2 api documentation round three

2021-06-02 Thread GitBox
epugh commented on pull request #91: URL: https://github.com/apache/solr/pull/91#issuecomment-853490514 Okay, I think I'm done with the schema-api.adoc page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [solr] wrunderwood commented on a change in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
wrunderwood commented on a change in pull request #96: URL: https://github.com/apache/solr/pull/96#discussion_r644391283 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ## @@ -40,12 +41,15 @@ * solution. There will be a follow

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853452250 I apologize for the personal comment. The documentation and name describe a CPU utilization circuit breaker. The implementation is a load average metric. Load average is not

[GitHub] [solr] janhoy commented on a change in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
janhoy commented on a change in pull request #96: URL: https://github.com/apache/solr/pull/96#discussion_r644375943 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java ## @@ -66,14 +66,19 @@ protected boolean isEnabled() { private fina

[GitHub] [solr] janhoy commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
janhoy commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853442218 > Whoever implemented this did not understand how the load average metric works. Please keep the discussion factual and about the code, not the people. I think the chosen p

[jira] [Commented] (SOLR-15385) Address rawtypes warnings

2021-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355997#comment-17355997 ] ASF subversion and git services commented on SOLR-15385: Commit c

[GitHub] [solr] madrob merged pull request #107: Address many Rawtypes warnings

2021-06-02 Thread GitBox
madrob merged pull request #107: URL: https://github.com/apache/solr/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853410595 Anyone running this on a multi-CPU machine should disable it immediately. The documentation says it will reject traffic when total CPU usage reaches a limit, but it will real

[jira] [Updated] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-06-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14672: -- Fix Version/s: 8.9 > Make timeouts configurable for the Streaming Expression SolrClientCache >

[jira] [Commented] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-06-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355983#comment-17355983 ] Joel Bernstein commented on SOLR-14672: --- This looks it's in 8.9. > Make timeouts c

[GitHub] [solr] magibney commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
magibney commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644340081 ## File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java ## @@ -1159,8 +1160,11 @@ protected Query getFieldQuery(String field, List q

[jira] [Commented] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-06-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355970#comment-17355970 ] Joel Bernstein commented on SOLR-14672: --- Yes this is finished. Let's see what relea

[GitHub] [solr] magibney commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
magibney commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644332142 ## File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java ## @@ -1149,7 +1150,7 @@ protected Query getFieldQuery(String field, List qu

[GitHub] [solr] dsmiley commented on a change in pull request #147: SOLR-15433: Replace transient core cache LRU by Caffeine cache.

2021-06-02 Thread GitBox
dsmiley commented on a change in pull request #147: URL: https://github.com/apache/solr/pull/147#discussion_r644329238 ## File path: solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java ## @@ -124,38 +142,29 @@ public SolrCore addCore(String name, SolrCor

[jira] [Commented] (SOLR-11646) Ref Guide: Update API examples to include v2 style examples

2021-06-02 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355961#comment-17355961 ] David Eric Pugh commented on SOLR-11646: Actually, I think schema-api.adoc is hal

[jira] [Commented] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-06-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355960#comment-17355960 ] Cassandra Targett commented on SOLR-14672: -- [~jbernste], this is finished, right

[jira] [Commented] (SOLR-11646) Ref Guide: Update API examples to include v2 style examples

2021-06-02 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355953#comment-17355953 ] David Eric Pugh commented on SOLR-11646: I've picked this work back up.   I've go

[GitHub] [solr] magibney commented on pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-06-02 Thread GitBox
magibney commented on pull request #129: URL: https://github.com/apache/solr/pull/129#issuecomment-853380214 > ** Current Incorrect Behaviour ** > If I query a "StrField" type or a text field type Keyword Tokenized, I get two different behaviours : > sow=false -> it splits on whitespa

[GitHub] [solr] magibney commented on a change in pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-06-02 Thread GitBox
magibney commented on a change in pull request #129: URL: https://github.com/apache/solr/pull/129#discussion_r644299691 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -1771,6 +1775,35 @@ public void testSplitOnWhitespace_Basic() thr

[GitHub] [solr] magibney commented on a change in pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-06-02 Thread GitBox
magibney commented on a change in pull request #129: URL: https://github.com/apache/solr/pull/129#discussion_r644298892 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -1771,6 +1775,35 @@ public void testSplitOnWhitespace_Basic() thr

[GitHub] [solr] atris commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
atris commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853358369 Hi Christine, Yes, merging the two circuit breakers makes sense as long as we separate out the configurations distinctly. Alternative is to have the common code (and test co

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853347376 That is what this patch does, move the existing behavior to a load average circuit breaker and create a new CPU usage circuit breaker. Combining the two has a problem. The ra

[GitHub] [solr] cpoerschke commented on pull request #152: SOLR-15311: Filter ASYNC key in during collection update

2021-06-02 Thread GitBox
cpoerschke commented on pull request #152: URL: https://github.com/apache/solr/pull/152#issuecomment-85462 Maybe also update the https://solr.apache.org/guide/8_8/collection-management.html#modifycollection to mention the (now supported) `async` parameter. -- This is an automated me

[GitHub] [solr-operator] thelabdude opened a new issue #274: Bootstrapped security.json incorrectly assigns the "all" permission to the "users" role due to ordering of rules

2021-06-02 Thread GitBox
thelabdude opened a new issue #274: URL: https://github.com/apache/solr-operator/issues/274 The `security.json` that the Solr operator creates during security boostrapping when using: ``` spec: ... solrSecurity: authenticationType: Basic ``` Grants the `all` per

[GitHub] [solr] cpoerschke commented on pull request #156: SOLR-15446: Fix three off-by-one ArrayList initialCapacity choices when calling ZooKeeper.multi API.

2021-06-02 Thread GitBox
cpoerschke commented on pull request #156: URL: https://github.com/apache/solr/pull/156#issuecomment-853331275 > Not directly related to the PR, but is there a reason for using ZooKeeper.multi when only issuing 1 command? Interesting question! From a quick look at the ZooKeeper docs

[jira] [Commented] (SOLR-15337) Avoid XPath in solrconfig.xml parsing

2021-06-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355934#comment-17355934 ] Cassandra Targett commented on SOLR-15337: -- This is in the CHANGES.txt for 8.9 i

[GitHub] [solr] cpoerschke commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-02 Thread GitBox
cpoerschke commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853328967 So one possibility is to change the implementation of the existing `CPUCircuitBreaker` class and to add a new `LoadAverageCircuitBreaker` class which has the same behaviour as the e

[jira] [Created] (SOLR-15451) SQL endpoint returns the wrong error when authenticated user doesn't have read access /admin/luke

2021-06-02 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15451: - Summary: SQL endpoint returns the wrong error when authenticated user doesn't have read access /admin/luke Key: SOLR-15451 URL: https://issues.apache.org/jira/browse/SOLR-15451

[jira] [Updated] (SOLR-15118) Make /v2/collections APIs annotation-based

2021-06-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-15118: - Fix Version/s: 8.9 > Make /v2/collections APIs annotation-based > ---

[jira] [Commented] (SOLR-15146) Distribute Collection API command execution

2021-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355901#comment-17355901 ] David Smiley commented on SOLR-15146: - I don't believe Ilan's change is related to th

[GitHub] [solr] dsmiley commented on a change in pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-06-02 Thread GitBox
dsmiley commented on a change in pull request #129: URL: https://github.com/apache/solr/pull/129#discussion_r644187229 ## File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java ## @@ -1149,18 +1151,21 @@ protected Query getFieldQuery(String field, List q

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-06-02 Thread Tom Gilke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355884#comment-17355884 ] Tom Gilke commented on SOLR-12697: -- Hi [~cpoerschke], here is the link to the ticket: h

[jira] [Created] (SOLR-15450) Create possibility to prefetch stored fields needed for FieldValueFeatures

2021-06-02 Thread Tom Gilke (Jira)
Tom Gilke created SOLR-15450: Summary: Create possibility to prefetch stored fields needed for FieldValueFeatures Key: SOLR-15450 URL: https://issues.apache.org/jira/browse/SOLR-15450 Project: Solr

[jira] [Commented] (SOLR-15146) Distribute Collection API command execution

2021-06-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355839#comment-17355839 ] Mike Drob commented on SOLR-15146: -- Maybe something in your commit changed the usage of

[jira] [Commented] (SOLR-15406) Reliably Failing Seed for testParallelPriorityStream

2021-06-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355837#comment-17355837 ] Mike Drob commented on SOLR-15406: -- {{CA8ECC56E40D0FE3}} is another failing seed. > Rel

[jira] [Commented] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355831#comment-17355831 ] David Smiley commented on SOLR-15449: - Thanks. Ultimately I think this is good nit-p

[jira] [Comment Edited] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355811#comment-17355811 ] Alessandro Benedetti edited comment on SOLR-15449 at 6/2/21, 3:50 PM: -

[jira] [Commented] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355811#comment-17355811 ] Alessandro Benedetti commented on SOLR-15449: - I agree [~dsmiley], I changed

[jira] [Updated] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-15449: Description: h1. Intro in multi-field search where the text analysis per field prod

[GitHub] [solr] dsmiley commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
dsmiley commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644079174 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -1776,6 +1764,36 @@ private static String getParsedQuery(SolrQuery

[GitHub] [solr] epugh commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-06-02 Thread GitBox
epugh commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-853111093 Did you see the precommit failure on missing license header @tboeghk ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355786#comment-17355786 ] David Smiley commented on SOLR-15449: - >From your description (as I read this; may ev

[jira] [Commented] (SOLR-10059) In SolrCloud, every fq added via is computed twice.

2021-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355779#comment-17355779 ] Torsten Bøgh Köster commented on SOLR-10059: I added another Github Pull Requ

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
alessandrobenedetti commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644028793 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -1776,6 +1764,36 @@ private static String getParsedQue

[GitHub] [solr] tboeghk opened a new pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-06-02 Thread GitBox
tboeghk opened a new pull request #159: URL: https://github.com/apache/solr/pull/159 # Description In distributed requests, the `appends` section of a `RequestHandler` is evaluated not only on the non-distributed coordinator requests but also during the distributed requests. This mi

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
alessandrobenedetti commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644026887 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -1776,6 +1764,36 @@ private static String getParsedQue

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
alessandrobenedetti commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r644026748 ## File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java ## @@ -1159,8 +1160,13 @@ protected Query getFieldQuery(String fie

[GitHub] [solr] dsmiley commented on pull request #152: SOLR-15311: Filter ASYNC key in during collection update

2021-06-02 Thread GitBox
dsmiley commented on pull request #152: URL: https://github.com/apache/solr/pull/152#issuecomment-853076846 Can you please add a CHANGES.txt entry? Please add an 8.10 section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [solr] dsmiley commented on pull request #107: Address many Rawtypes warnings

2021-06-02 Thread GitBox
dsmiley commented on pull request #107: URL: https://github.com/apache/solr/pull/107#issuecomment-853062851 "Redundant suppression". AFAICT you can't restrict to particular suppressions, and be aware it's decisions may disagree with Gradle and thus we must adhere to Gradle. Many rawtypes

[GitHub] [solr] dsmiley commented on a change in pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
dsmiley commented on a change in pull request #158: URL: https://github.com/apache/solr/pull/158#discussion_r643958682 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -1776,6 +1764,36 @@ private static String getParsedQuery(SolrQuery

[jira] [Reopened] (SOLR-15090) Allow backups to GCS (Google Cloud Storage)

2021-06-02 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reopened SOLR-15090: Reopening this temporarily to reflect a bug fix I'm currently working on. The backport of this

[GitHub] [solr] madrob commented on pull request #107: Address many Rawtypes warnings

2021-06-02 Thread GitBox
madrob commented on pull request #107: URL: https://github.com/apache/solr/pull/107#issuecomment-852982397 What is the IntelliJ inspection called? I tried to find it but couldn’t. :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (SOLR-15316) Update Jetty to 9.4.41

2021-06-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355677#comment-17355677 ] Cassandra Targett commented on SOLR-15316: -- Thank you very much, Jan, for pickin

[GitHub] [solr] alessandrobenedetti commented on pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-06-02 Thread GitBox
alessandrobenedetti commented on pull request #129: URL: https://github.com/apache/solr/pull/129#issuecomment-852936901 Pull Request has been cleaned, only the fix related with the Jira issue is now present. i'll summarize it again. **Index Time** Configuring a field to be "Str

[jira] [Updated] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-15449: Description: h1. Intro in multi-field search with different analysis per field sow

[jira] [Commented] (SOLR-15407) eDismax sow=false doesn't work with string field types

2021-06-02 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355637#comment-17355637 ] Alessandro Benedetti commented on SOLR-15407: - Sister issue and PR has been a

[GitHub] [solr] alessandrobenedetti commented on pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-06-02 Thread GitBox
alessandrobenedetti commented on pull request #129: URL: https://github.com/apache/solr/pull/129#issuecomment-852925576 Sister issue and PR has been added: https://issues.apache.org/jira/browse/SOLR-15449 https://github.com/apache/solr/pull/158 I am going now to clean this PR ju

[GitHub] [solr] alessandrobenedetti commented on pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
alessandrobenedetti commented on pull request #158: URL: https://github.com/apache/solr/pull/158#issuecomment-852925108 @dsmiley @janhoy @madrob @munendrasn @romseygeek @sarowe , the issue with sow and mm found in: https://github.com/apache/solr/pull/129 has been isolated here and it's rea

[GitHub] [solr] alessandrobenedetti opened a new pull request #158: SOLR-15449: edismax sow and mm

2021-06-02 Thread GitBox
alessandrobenedetti opened a new pull request #158: URL: https://github.com/apache/solr/pull/158 https://issues.apache.org/jira/browse/SOLR-15449 # Description When a field text analysis is incompatible with the query text, mm is not fully respected: ``` sow = false m

[jira] [Updated] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-15449: Description: h1. Intro in multi-field search with different analysis per field sow

[jira] [Created] (SOLR-15449) edimax sow causes issues with minimum should match in case of multi field with different analysis

2021-06-02 Thread Alessandro Benedetti (Jira)
Alessandro Benedetti created SOLR-15449: --- Summary: edimax sow causes issues with minimum should match in case of multi field with different analysis Key: SOLR-15449 URL: https://issues.apache.org/jira/browse

[GitHub] [solr] NazerkeBS commented on a change in pull request #152: SOLR-15311: Filter ASYNC key in during collection update

2021-06-02 Thread GitBox
NazerkeBS commented on a change in pull request #152: URL: https://github.com/apache/solr/pull/152#discussion_r643776555 ## File path: solr/core/src/test/org/apache/solr/cloud/OverseerModifyCollectionTest.java ## @@ -42,29 +39,27 @@ public static void setupCluster() throws Exc

[jira] [Commented] (SOLR-15316) Update Jetty to 9.4.41

2021-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355572#comment-17355572 ] Jan Høydahl commented on SOLR-15316: There have been at least 9 test-runs in Jenkins

[jira] [Commented] (SOLR-15433) Replace basic LRU by Caffeine Cache for transient core cache

2021-06-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355564#comment-17355564 ] Bruno Roustant commented on SOLR-15433: --- I'm going to merge it in two days. > Repl

[jira] [Resolved] (SOLR-9887) Add KeepWordFilter, StemmerOverrideFilter, StopFilterFactory, SynonymFilter that reads data from a JDBC source

2021-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Kässmann resolved SOLR-9887. --- Resolution: Won't Fix outdated > Add KeepWordFilter, StemmerOverrideFilter, StopFilterFactory

[jira] [Resolved] (SOLR-9888) Add a boosting dismax query parser (bmax)

2021-06-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Kässmann resolved SOLR-9888. --- Resolution: Won't Fix outdated > Add a boosting dismax query parser (bmax) >