tboeghk opened a new pull request #159:
URL: https://github.com/apache/solr/pull/159
# Description
In distributed requests, the `appends` section of a `RequestHandler` is
evaluated not only on the non-distributed coordinator requests but also during
the distributed requests. This might lead to parameters (especially harmful for
`fq` params) being attached multiple times.
```xml
<requestHandler name="/myHandler" class="solr.SearchHandler">
<lst name="appends">
<str name="fq">{!collapse field=routingKey hint=top_fc}</str>
</lst>
</requestHandler>
```
The issue exists for some time in the bug tracker:
[SOLR-10059](https://issues.apache.org/jira/browse/SOLR-10059)
# Solution
The fix ignores the `appends` section of the handler definition during
distributed requests.
# Tests
I added a simple unit test, no cloud setup test though
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms
to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [ ] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
