wrunderwood commented on a change in pull request #96:
URL: https://github.com/apache/solr/pull/96#discussion_r644391283
##########
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##########
@@ -40,12 +41,15 @@
* solution. There will be a follow up with a SIP for a schema API design.
*/
public class CircuitBreakerManager implements PluginInfoInitialized {
+ private final SolrCore core;
Review comment:
I was unaware of SolrCoreAware, I'll go check it out. Thanks.
The other larger change is to have circuit breakers only interrupt external
requests and to not interrupt internal requests to shards. The current approach
multiples failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
