alessandrobenedetti commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644028793



##########
File path: 
solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java
##########
@@ -1776,6 +1764,36 @@ private static String getParsedQuery(SolrQueryRequest 
request) throws Exception
     return (String) BaseTestHarness.evaluateXPath(resp, 
"//str[@name='parsedquery']/text()", XPathConstants.STRING);
   }
   
+  public void testSplitOnWhitespace_shouldRespectMinimumShouldMatch(){

Review comment:
       I think I've done it, formatting is one of the things I hate the most, 
my opinion is that it shouldn't be the responsibility of single peers but it 
should be server side to avoid inconsistencies(which I often find also in 
Lucene/Solr and other Open Source code).
   Never really explored a solution for that either, so I hope, my changes are 
ok now :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to