atris commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853358369
Hi Christine, Yes, merging the two circuit breakers makes sense as long as we separate out the configurations distinctly. Alternative is to have the common code (and test code) in parent classes with both the circuit breakers and their infrastructure deriving from them. Your point about back compatibility is important. At work, we use the CPU circuit breaker, and I am sure many other users do, too. Renaming existing functionality will break that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
