wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853452250
I apologize for the personal comment. The documentation and name describe a CPU utilization circuit breaker. The implementation is a load average metric. Load average is not a CPU utilization metric. The limits on the circuit breaker don’t match the range of the metric for load average. The implementation makes an incorrect assumption. That is a bug. It is actually a double bug. The implementation does not match the documentation, but if you figure out the implementation, the limit on thresholds makes it unusable on multi-CPU systems. wunder Walter Underwood ***@***.*** http://observer.wunderwood.org/ (my blog) > On Jun 2, 2021, at 4:15 PM, Jan Høydahl ***@***.***> wrote: > > > Whoever implemented this did not understand how the load average metric works. > > Please keep the discussion factual and about the code, not the people. > > I think the chosen path of having separate LoadAvg and CpuPct implementations is better than some extra flag to choose. This keeps the configuration more direct and clear, and the documentation of cpuThreshold will not be conditional on another parameter - the two impls can be documented separate from each other. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/solr/pull/96#issuecomment-853442218>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACR4IILGJTAHOMGVXL6PA7DTQ23PXANCNFSM43T5FIZA>. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
