janhoy commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853442218
> Whoever implemented this did not understand how the load average metric works. Please keep the discussion factual and about the code, not the people. I think the chosen path of having separate LoadAvg and CpuPct implementations is better than some extra flag to choose. This keeps the configuration more direct and clear, and the documentation of `cpuThreshold` will not be conditional on another parameter - the two impls can be documented separate from each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
